Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate DynamicTableWriter constructors taking an array from the point of view of jpy. #1143

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

jcferretti
Copy link
Member

With two public constructors looking like:

DynamicTableWriter(final String[] columnNames, final Class<?>[] columnTypes)
DynamicTableWriter(final String[] columnNames, final Type<?>[] columnTypes)

jpy can't tell which to call with a list for the second argument:

r-Scheduler-Serial-1 | i.d.g.s.SessionState      | Internal Error '17a7b995-3319-470d-9452-7e0fadac8722' java.lang.RuntimeException: Error in Python interpreter:
Type: <class 'RuntimeError'>
Value: ambiguous Java method call, too many matching method overloads found

Creating an intermediate jpy.array on the python side works, but is a clunky API to be forced on users (see image attached).
Since we want to move to qst and away from Class anyway, I am making the constructors package-private, and replacing their use with the TableHeader based one.

Selection_095

@jcferretti jcferretti added this to the Aug 2021 milestone Aug 26, 2021
@jcferretti jcferretti requested a review from devinrsmith August 26, 2021 21:33
@jcferretti jcferretti self-assigned this Aug 26, 2021
devinrsmith
devinrsmith previously approved these changes Aug 26, 2021
@jcferretti jcferretti merged commit 602dfd9 into deephaven:main Aug 26, 2021
@jcferretti jcferretti deleted the cfs-dyntw-2 branch August 26, 2021 22:47
mofojed pushed a commit that referenced this pull request Nov 3, 2023
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.53.0

# [0.53.0](deephaven/web-client-ui@v0.52.0...v0.53.0) (2023-11-03)


### Bug Fixes

* DH-15864: Scroll position StuckToBottom shouldn't trigger sharing dot ([#1617](deephaven/web-client-ui#1617)) ([3d4499b](deephaven/web-client-ui@3d4499b))
* Panel focus throwing an exception ([#1609](deephaven/web-client-ui#1609)) ([9e8b7ae](deephaven/web-client-ui@9e8b7ae))
* Plugins were re-registering on every re-render ([#1613](deephaven/web-client-ui#1613)) ([5977389](deephaven/web-client-ui@5977389))


### Features

* Add support for multi-partition parquet:kv tables ([#1580](deephaven/web-client-ui#1580)) ([d92c91e](deephaven/web-client-ui@d92c91e)), closes [#1143](deephaven/web-client-ui#1143) [#1438](deephaven/web-client-ui#1438)
* Babel Plugin - Mock css imports ([#1607](deephaven/web-client-ui#1607)) ([787c542](deephaven/web-client-ui@787c542)), closes [#1606](deephaven/web-client-ui#1606)
* Convert DashboardPlugins to WidgetPlugins ([#1598](deephaven/web-client-ui#1598)) ([a260842](deephaven/web-client-ui@a260842)), closes [#1573](deephaven/web-client-ui#1573)


### Reverts

* "fix: stuck to bottom on filter clear" ([#1616](deephaven/web-client-ui#1616)) ([806a6b6](deephaven/web-client-ui@806a6b6)), closes [deephaven/web-client-ui#1579](deephaven/web-client-ui#1579) [#1615](deephaven/web-client-ui#1615)

Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants