non-contiguous row selection results in less transparent selection bg color #1619
Comments
|
Would be a good e2e screenshot candidate |
|
Duplicate of purged enterprise ticket: https://deephaven.atlassian.net/browse/DH-9637 |
dsmmcken
added a commit
that referenced
this issue
Nov 6, 2023
Fixes #1619 Draw selection was calling the fill/stroke inside the loop, which implicitly calls closePath, resulting the fill to be drawed over top of itself multiple times. Move the fill/stroke outside the loop the creates the selection rects. Adds an e2e test that makes a non-contiguous selection to prevent regressions.
mofojed
pushed a commit
to deephaven/deephaven-core
that referenced
this issue
Nov 10, 2023
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.54.0 # [0.54.0](deephaven/web-client-ui@v0.53.0...v0.54.0) (2023-11-10) ### Bug Fixes * Date argument non-optional for the onChange prop ([#1622](deephaven/web-client-ui#1622)) ([9a960b3](deephaven/web-client-ui@9a960b3)), closes [#1601](deephaven/web-client-ui#1601) * Fixing grid colors and grays ([#1621](deephaven/web-client-ui#1621)) ([9ab2b1e](deephaven/web-client-ui@9ab2b1e)), closes [#1572](deephaven/web-client-ui#1572) * Infinite loop with grid rendering ([#1631](deephaven/web-client-ui#1631)) ([4875d2e](deephaven/web-client-ui@4875d2e)), closes [#1626](deephaven/web-client-ui#1626) * Log figure errors, don't show infinite spinner ([#1614](deephaven/web-client-ui#1614)) ([75783d0](deephaven/web-client-ui@75783d0)) * non-contiguous table row selection background colour ([#1623](deephaven/web-client-ui#1623)) ([61d1a53](deephaven/web-client-ui@61d1a53)), closes [#1619](deephaven/web-client-ui#1619) * Panels not reinitializing if makeModel changes ([#1633](deephaven/web-client-ui#1633)) ([5ee98cd](deephaven/web-client-ui@5ee98cd)) * remove unecessary dom re-calc in grid render ([#1632](deephaven/web-client-ui#1632)) ([ce7cc3e](deephaven/web-client-ui@ce7cc3e)) ### Features * Add `LayoutManagerContext` and `useLayoutManager` ([#1625](deephaven/web-client-ui#1625)) ([0a6965a](deephaven/web-client-ui@0a6965a)) * Add ResizeObserver to Grid and Chart ([#1626](deephaven/web-client-ui#1626)) ([35311c8](deephaven/web-client-ui@35311c8)) * Added test:debug script ([#1628](deephaven/web-client-ui#1628)) ([80f29f5](deephaven/web-client-ui@80f29f5)), closes [#1627](deephaven/web-client-ui#1627) * Read settings from props/server config when available ([#1558](deephaven/web-client-ui#1558)) ([52ba2cd](deephaven/web-client-ui@52ba2cd)) * Theming - Charts ([#1608](deephaven/web-client-ui#1608)) ([d5b3b48](deephaven/web-client-ui@d5b3b48)), closes [#1572](deephaven/web-client-ui#1572) ### BREAKING CHANGES - ChartThemeProvider is now required to provide ChartTheme - ChartModelFactory and ChartUtils now require chartTheme args Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Selecting every other row in a table via (ctrl/cmd) results in the selection bg color getting less and less transparent. I am going to guess we are re-drawing the same selection over and over incorrectly.
Steps to reproduce:
Result:
Expected Result (just the bg color, can't make the same selection):
The text was updated successfully, but these errors were encountered: