chore(tests): Deprecate remaining usages of itest in check tests (#26962

) This PR progresses #22907 by deprecating the usage of `itest` in `tests/integration/check_tests.rs`
denoland · Dec 11, 2024 · 1e7baba · 1e7baba
1 parent 5da4db0
commit 1e7baba
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 15 deletions.
diff --git a/tests/integration/check_tests.rs b/tests/integration/check_tests.rs
@@ -3,23 +3,9 @@
 use deno_lockfile::NewLockfileOptions;
 use deno_semver::jsr::JsrDepPackageReq;
 use test_util as util;
-use test_util::itest;
 use util::TestContext;
 use util::TestContextBuilder;
 
-itest!(check_all {
-  args: "check --allow-import --quiet --all check/all/check_all.ts",
-  output: "check/all/check_all.out",
-  http_server: true,
-  exit_code: 1,
-});
-
-itest!(check_all_local {
-  args: "check --allow-import --quiet check/all/check_all.ts",
-  output_str: Some(""),
-  http_server: true,
-});
-
 #[test]
 fn cache_switching_config_then_no_config() {
   let context = TestContext::default();

diff --git a/tests/specs/check/check_all/__test__.jsonc b/tests/specs/check/check_all/__test__.jsonc
@@ -0,0 +1,5 @@
+{
+  "args": "check --allow-import --quiet --all check_all.ts",
+  "output": "check_all.out",
+  "exitCode": 1
+}
diff --git a/tests/testdata/check/all/check_all.out → tests/specs/check/check_all/check_all.out b/tests/testdata/check/all/check_all.out → tests/specs/check/check_all/check_all.out
diff --git a/tests/testdata/check/all/check_all.ts → tests/specs/check/check_all/check_all.ts b/tests/testdata/check/all/check_all.ts → tests/specs/check/check_all/check_all.ts
diff --git a/tests/specs/check/check_all_local/__test__.jsonc b/tests/specs/check/check_all_local/__test__.jsonc
@@ -0,0 +1,5 @@
+{
+  "args": "check --allow-import --quiet check_all_local.ts",
+  "output": "",
+  "exitCode": 0
+}
diff --git a/tests/specs/check/check_all_local/check_all_local.ts b/tests/specs/check/check_all_local/check_all_local.ts
@@ -0,0 +1,3 @@
+import * as a from "http://localhost:4545/subdir/type_error.ts";
+
+console.log(a.a);
diff --git a/tools/lint.js b/tools/lint.js
@@ -211,7 +211,7 @@ async function ensureNoNewITests() {
     "bench_tests.rs": 0,
     "cache_tests.rs": 0,
     "cert_tests.rs": 0,
-    "check_tests.rs": 2,
+    "check_tests.rs": 0,
     "compile_tests.rs": 0,
     "coverage_tests.rs": 0,
     "eval_tests.rs": 0,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		import * as a from "http://localhost:4545/subdir/type_error.ts";

		console.log(a.a);