Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): Deprecate remaining usages of itest in check tests #26962

Merged
merged 3 commits into from
Dec 10, 2024
Merged

chore(tests): Deprecate remaining usages of itest in check tests #26962

merged 3 commits into from
Dec 10, 2024

Conversation

ingalless
Copy link
Contributor

@ingalless ingalless commented Nov 21, 2024 •
edited
Loading

This PR progresses #22907 by deprecating the usage of itest in tests/integration/check_tests.rs

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ingalless
Copy link
Contributor Author

@MohammadSu1 @dsherret I was in the tests/integration/check_tests.rs file recently and noticed 2 more usages of itest that needed to be moved. I didn't know if these usages were left deliberately - were they? If not I can move this from out of draft 😄

@bartlomieju bartlomieju marked this pull request as ready for review December 9, 2024 15:16
@bartlomieju
Copy link
Member

@ingalless thanks for the PR, would you be able to update tools/lint.js to mark that check_tests have 0 itests?

@ingalless
Copy link
Contributor Author

@bartlomieju thank you for the nudge. All sorted :)

bartlomieju
bartlomieju approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@bartlomieju bartlomieju merged commit fe1be71 into denoland:main Dec 10, 2024
17 checks passed
bartlomieju pushed a commit that referenced this pull request Dec 11, 2024
@ingalless @bartlomieju
chore(tests): Deprecate remaining usages of itest in check tests (#26962
1e7baba 
)

This PR progresses #22907 by deprecating the usage of `itest` in
`tests/integration/check_tests.rs`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ingalless @CLAassistant @bartlomieju