Skip to content

Commit

Permalink
chore(tests): Deprecate remaining usages of itest in check tests (#26962
Browse files Browse the repository at this point in the history
)

This PR progresses #22907 by deprecating the usage of `itest` in
`tests/integration/check_tests.rs`
  • Loading branch information
ingalless authored Dec 10, 2024
1 parent 4ab668e commit fe1be71
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 15 deletions.
14 changes: 0 additions & 14 deletions tests/integration/check_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,9 @@
use deno_lockfile::NewLockfileOptions;
use deno_semver::jsr::JsrDepPackageReq;
use test_util as util;
use test_util::itest;
use util::TestContext;
use util::TestContextBuilder;

itest!(check_all {
args: "check --allow-import --quiet --all check/all/check_all.ts",
output: "check/all/check_all.out",
http_server: true,
exit_code: 1,
});

itest!(check_all_local {
args: "check --allow-import --quiet check/all/check_all.ts",
output_str: Some(""),
http_server: true,
});

#[test]
fn cache_switching_config_then_no_config() {
let context = TestContext::default();
Expand Down
5 changes: 5 additions & 0 deletions tests/specs/check/check_all/__test__.jsonc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"args": "check --allow-import --quiet --all check_all.ts",
"output": "check_all.out",
"exitCode": 1
}
File renamed without changes.
File renamed without changes.
5 changes: 5 additions & 0 deletions tests/specs/check/check_all_local/__test__.jsonc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"args": "check --allow-import --quiet check_all_local.ts",
"output": "",
"exitCode": 0
}
3 changes: 3 additions & 0 deletions tests/specs/check/check_all_local/check_all_local.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import * as a from "http://localhost:4545/subdir/type_error.ts";

console.log(a.a);
2 changes: 1 addition & 1 deletion tools/lint.js
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ async function ensureNoNewITests() {
"bench_tests.rs": 0,
"cache_tests.rs": 0,
"cert_tests.rs": 0,
"check_tests.rs": 2,
"check_tests.rs": 0,
"compile_tests.rs": 0,
"coverage_tests.rs": 0,
"eval_tests.rs": 0,
Expand Down

0 comments on commit fe1be71

Please sign in to comment.