Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[http] Promote use of enums #414

Closed
zekth opened this issue May 18, 2019 · 0 comments
Closed

[http] Promote use of enums #414

zekth opened this issue May 18, 2019 · 0 comments

Comments

@zekth
Copy link
Contributor

zekth commented May 18, 2019

After seeing this : https://github.com/denoland/deno_std/pull/411/files#diff-b462a10d351b72f15940c98312099c4eL11

I thought it would be revelant to promote the use of http_status enumerable in the doc instead of direct use of http code.

ref: https://github.com/denoland/deno_std/blob/master/http/http_status.ts
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this issue Oct 24, 2024
@iuioiua
feat: cursor-based pagination for comments using "Load more" button (d…
3aa15cd 
…enoland#438)

Simpler alternative to denoland#429

Towards denoland#414
CC @mbhrznr
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this issue Oct 24, 2024
@iuioiua
feat: REST API and cursor-based pagination for notifications (denolan…
44a16e4 
…d#442)

This change adds the `GET /api/users/[login]/notifications` REST API
endpoint.

Documentation will come in a follow-up PR.

Towards denoland#439 and denoland#414
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this issue Oct 24, 2024
@iuioiua
feat: cursor-based pagination for users table (denoland#446)
e27502e 
Closes denoland#398
Towards denoland#414
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this issue Oct 24, 2024
@iuioiua
feat: <ItemsList /> with cursor-based pagination (denoland#445)
853e6e6 
This change contains a few changes that affect interdependent features.
Changes include:
- Add `<ItemsList />` with cursor-based pagination
- Remove now unused code for the previous pagination solution
- Fix and rework voting functionality relating to denoland#427
- Tweak REST API endpoints return signature to be more generic, using a
`values` field
- `fetchValues()`
- Simplify and optimise `<VoteButton />`
- New `DELETE/GET /api/items/[id]/vote` endpoint
- New `GET /api/me/votes` endpoint
- Other various cleanups

Note: The migration script has been tested successfully locally.

Closes denoland#427
Closes denoland#414
Towards denoland#439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zekth @bartlomieju