Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch Stats Page | Deprecate stats pages #12991

Closed
1 of 2 tasks
leikkisa opened this issue Dec 16, 2019 · 2 comments
Closed
1 of 2 tasks

Dispatch Stats Page | Deprecate stats pages #12991

leikkisa opened this issue Dec 16, 2019 · 2 comments
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-intake Team: Foxtrot 🦊 Type: Tech-Improvement

Comments

@leikkisa
Copy link
Contributor

leikkisa commented Dec 16, 2019

Description

The stats pages aren't being visited, and their code is old. In addition, they are a source of accessibility audit violations.

Acceptance criteria

  • Remove stats pages
  • User sees a 404 message if they try to navigate to them

Background/context/resources

GH issue for deprecating intake stats page:
#11933

Sandra double checked in Google Analytics whether these pages were getting visits, and there were 0 visits since October 1st, 2019.

Technical notes

@msj0nes
Copy link

msj0nes commented Jan 27, 2020

@Sjones352 is this ticket entirely complete? Can you close it if so.

@Sjones352
Copy link
Contributor

@msj0nes I removed the Intake stat code from caseflow and disabled the Dispatch/ Certification code to return 404. This was done in phases as the it was a lot of files to remove. I will remove the rest of this code this sprint.

brandondorner added a commit that referenced this issue Jul 12, 2023
This functionality of the app has been deprecated.
More details will be placed in the corresponding PR but the original
deprecation comes from the PRs:
#11934
and
#12991

More specifically it looks like this was meant to be removed but was
not per:
#12991 (comment)

Last note is that there will also be other removed sections related
to this, `dispatch_stats` and potentially 'StatsContainer.

These will be in another commit/PR because those are more obscure
while the `certification_stats` stuff can for sure be removed.
brandondorner added a commit that referenced this issue Jul 12, 2023
DispatchStats functionality has been deprecated from the app a few
years ago but the code remains. It looks like it was intended to be
removed at some point but it fell under the radar:
#12991 (comment)

So now we are finally removing the code from the codebase to hopefully
clean it up a tiny bit.
brandondorner added a commit that referenced this issue Aug 29, 2023
DispatchStats functionality has been deprecated from the app a few
years ago but the code remains. It looks like it was intended to be
removed at some point but it fell under the radar:
#12991 (comment)

So now we are finally removing the code from the codebase to hopefully
clean it up a tiny bit.
brandondorner added a commit that referenced this issue Aug 29, 2023
This functionality of the app has been deprecated.
More details will be placed in the corresponding PR but the original
deprecation comes from the PRs:
#11934
and
#12991

More specifically it looks like this was meant to be removed but was
not per:
#12991 (comment)

Last note is that there will also be other removed sections related
to this, `dispatch_stats` and potentially 'StatsContainer.

These will be in another commit/PR because those are more obscure
while the `certification_stats` stuff can for sure be removed.
craigrva added a commit that referenced this issue Sep 12, 2023
…25341 (#18999)

* Remove deprecated `DispatchStats` code from app

DispatchStats functionality has been deprecated from the app a few
years ago but the code remains. It looks like it was intended to be
removed at some point but it fell under the radar:
#12991 (comment)

So now we are finally removing the code from the codebase to hopefully
clean it up a tiny bit.

* Remove StatsController, StatsContainer, and routes

Remove everything related to `StatsController`, `StatsContainer, the
stats route, and the show file.

We are essentially undoing parts of this commit:
ef1dd8c

The functionality of DispatchStats, CertificationStats, and the
StatsContainer have all be deprecated but were not fully removed.
This commit (and PR) removes the deprecated items.

* Remove all instances of CertificationStats

This functionality of the app has been deprecated.
More details will be placed in the corresponding PR but the original
deprecation comes from the PRs:
#11934
and
#12991

More specifically it looks like this was meant to be removed but was
not per:
#12991 (comment)

Last note is that there will also be other removed sections related
to this, `dispatch_stats` and potentially 'StatsContainer.

These will be in another commit/PR because those are more obscure
while the `certification_stats` stuff can for sure be removed.

* Remove methods and attributes that are deprecated

CertificationStats has been deprecated and is now finally being
removed from the codebase. As part of that endeavor we can remove
these methods and attributes that are no longer used.

* Remove obsolete certification stats specs

---------

Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-intake Team: Foxtrot 🦊 Type: Tech-Improvement
Projects
None yet
Development

No branches or pull requests

4 participants