Remove all instances of CertificationStats - APPEALS/24135 #18986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandondorner
commented
Jul 11, 2023
|
Code Climate has analyzed commit 0923827 and detected 0 issues on this pull request. View more on Code Climate. |
This functionality of the app has been deprecated. More details will be placed in the corresponding PR but the original deprecation comes from the PRs: #11934 and #12991 More specifically it looks like this was meant to be removed but was not per: #12991 (comment) Last note is that there will also be other removed sections related to this, `dispatch_stats` and potentially 'StatsContainer. These will be in another commit/PR because those are more obscure while the `certification_stats` stuff can for sure be removed.
brandondorner
force-pushed
the
dorner/appeal-24135
branch
from
7fd51a2
to
0923827
Compare
This was referenced Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://jira.devops.va.gov/browse/APPEALS-24135
Description
This functionality of CertificationStats has been removed from the app but the tests were erroneously left in. The original deprecation comes from the PRs: #1193,
#11934,
#12991, and
#13095
More specifically it looks like this was meant to be removed but was not per:
#12991 (comment)
Note:
There will also be other removed sections related to this =>
dispatch_statsand potentiallyStatsContainer.These will be in another commit/PR because those are more obscure while the
certification_statsstuff can for sure be removed.Related PRs:
#18988 | Removes deprecated DispatchStats code
Acceptance Criteria
Code Climate
Your code does not add any new code climate offenses? If so why?
Other Issues/PRs that are of use:
#12692 -> Team planning the includes the deprecation
#12991
#13255 -> It seems some of the stat monitoring has been reintroduced as
Metrics