Remove Deperecated DispatchStats - APPEALS/24135 #18988
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.devops.va.gov/browse/APPEALS-24135
Description
DispatchStats functionality has been deprecated from the app a few years ago but the code remains. It looks like it was intended to be removed at some point but it fell under the radar:
#12991 (comment)
So now we are finally removing the code from the codebase to hopefully clean it up a tiny bit.
Also Remove everything related to
StatsController
, `StatsContainer, the stats route, and the show file.We are essentially undoing parts of this commit: ef1dd8c
The functionality of DispatchStats, CertificationStats, and the StatsContainer have all been deprecated and now are removed.
The original deprecation comes from these PRs: #1193
#11934
#12991
#13095
More specifically it looks like this was meant to be removed but was not per:
#12991 (comment)
Related PRs:
#18986 | Removes the deprecated CertificationStats code
Acceptance Criteria
Code Climate
Your code does not add any new code climate offenses? If so why?