Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/APPEALS-17497 MST/PACT Act Special Identification #18472

Merged
merged 192 commits into from
Jul 19, 2023

Conversation

kristeja
Copy link
Contributor

@kristeja kristeja commented Apr 19, 2023

Resolves APPEALS-17497

APPEALS-17497

  • As a Intake user, I need the ability to easily identify and mark (or unmark where necessary) existing VBMS decisions or new issues as Military Sexual Trauma (MST) or PACT Act issues at the issue level when inputting a decision review.
  • As a Board member, I need the ability to easily identify and report on issues and appeals that are designated as MST or PACT Act.

Testing Plan

  1. Go to APPEALS-17497

Database Changes:

  1. New columns has been added to existing database tables
  • decision_issues db table new columns

  • mst_status
    
  • pact_status
    
  • request_issues db table new columns
    
  • mst_status
    
  • mst_status_update_reason_notes
    
  • pact_status
    
  • pact_status_update_reason_notes
    
  • vbms_mst_status
    
  • vbms_pact_status
    
  • request_issues_updates db table new columns

  • mst_edited_request_issue_ids
    
  • pact_edited_request_issue_ids
    
  1. New database tables that will be created during deployment
    special_issue_changes

jonathanh-va and others added 3 commits April 13, 2023 17:13
* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems
* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
@codeclimate
Copy link

codeclimate bot commented Apr 19, 2023

Code Climate has analyzed commit 965e712 and detected 292 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 70
Duplication 19
Style 202
Performance 1

Note: there is 1 critical issue.

View more on Code Climate.

jonathanh-va and others added 5 commits April 19, 2023 12:20
* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems
* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator
* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle
IsaiahBar and others added 10 commits April 19, 2023 16:02
* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* removed MST

---------

Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457)

* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator

* Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453)

* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle

* Info banner for Special Issues Page

* re-implement banner to ensure fontsize is consistent

* added some spacing under banner

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: Ki Mau <ki.mau@va.gov>
* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems
* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator
* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle
* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* removed MST

---------

Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457)

* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator

* Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453)

* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle

* Info banner for Special Issues Page

* re-implement banner to ensure fontsize is consistent

* added some spacing under banner

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: Ki Mau <ki.mau@va.gov>
HunJerBAH and others added 8 commits April 21, 2023 11:03
* Created Issues Update task model and methods for formatting instructions

* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* added issueUpdateTask bool check

* refactored format_instructions method to store in nested array

* refactored instruction logic and updated rendering/styling of task instructions

* updated css styling to match wireframes

* refactored special issue format and created tests

---------

Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
* Redoing branch because of previous errors.

* Added updated featureToggles.js that includes mstPactIdentification

---------

Co-authored-by: Ryan Marshall <Ryan.Marshall@lefant.org>
…odal (#18478)

* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle

* APPEALS-17507 - Connection Pieces Working

* APPEALS-17507 - Index work for Modal

* APPEALS-17507 - Fully working Modal component

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* Update warmup_vacols.rb

* Update warmup_vacols.rb

* Update warmup_vacols.rb

* Update warmup_vacols.rb

* Update ApiUtil.js

* Update ApiUtil.js

* ACD: Disable Legacy Docket and Non Priority distribution (#18463)

* Update by_docket_date_distribution.rb

* Update docket_coordinator.rb

* disable Legacy

* add feature toggle indicators to stats

* Update by_docket_date_distribution.rb

* Update push_priority_appeals_to_judges_job.rb

* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457)

* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator

* removed MST (#18455)

* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* removed MST

---------

Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* jHoang/APPEALS-17523 (#18466)

* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457)

* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator

* Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453)

* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle

* Info banner for Special Issues Page

* re-implement banner to ensure fontsize is consistent

* added some spacing under banner

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: Ki Mau <ki.mau@va.gov>

* revert timeouts

* HunJerBAH/APPEALS-17522: Create IssuesUpdate Task Model (#18465)

* Created Issues Update task model and methods for formatting instructions

* jHoang/APPEALS-17511 (#18444)

* migration to add mst and pact status to request_issues

* schema update

* typo in migration

* typo in schema

* set default status

* Revert "schema update"

This reverts commit 0d5df1a.

* Revert "typo in schema"

This reverts commit 9a74e6e.

* +1

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>

* Justin/appeals 17512 (#18443)

* feature toggle mst_pact_identification

* toggle added to queue, intake, and hearings erb

* replaced bracket that was accidentally removed

* hearings feature toggle to camelCase to match

* removing merge problems

* APPEALS-17506: MST & PACT Components (#18451)

* APPEALS-17506: MST & PACT Components

* +1

* updated storybook test args for rendering badges

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* added issueUpdateTask bool check

* refactored format_instructions method to store in nested array

* refactored instruction logic and updated rendering/styling of task instructions

* updated css styling to match wireframes

* refactored special issue format and created tests

---------

Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>

* removed console log and copy.json value

* removed commented code

* fixed minor syntax complaints and added proptypes

* APPEALS-17507 - Updated storybook

---------

Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: Matt Roth <roth_matthew@bah.com>
Co-authored-by: Matt Roth <mattcroth@gmail.com>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: IsaiahBar <107133331+IsaiahBar@users.noreply.github.com>
Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457)

* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator

* Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453)

* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle

* added methods that return mst/pact status

* added safety operator to contention

* refactored changes onto request issue model

* refactored hash check with has_value?

* added rspec tests

* added generator for mst + pact status contention

* added brackets

* refactored spec tests

* updated contention generation methods for special issues

* updated status return methods to conform to test cases

* updated serialize attr from snake case to camel case

---------

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: Ki Mau <ki.mau@va.gov>
* HunJerBAH/APPEALS-17509: Mocking BGS Contentions in Test Data (#18457)

* added mst and pact option to contention generator

* added mst and pact option to bgs_contention generator

* updated record maker to build epes with mst/pact contentions

* refactored to create both mst and pact contention cases for veterans

* added duplicate contention error handling in generator

* Ki/appeals 17508 v3 - Add Edit Issues Dropdown (#18453)

* APPEALs-17508 - feature branch update issues fix

* APPEALS-17508 - MST/PACT FeatureToggle

* adding feature toggle to intakes controller

* Adding checkbox to conditionally render

* attempting to add checkbox to state management

* pact box and code cleanup

* Redux state management

* Adding spec test for checkboxes

* Matching wireframe

* testing with 2 args, as 3 fails

* testing spec test idea

* re-writing spec method

* default state to false and merge fixes

* parity for redux variables for mstpact checkboxes

* feature toggle fix

---------

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: Ki Mau <ki.mau@va.gov>
Blake-Manus and others added 20 commits July 10, 2023 11:55
* Updated Task Row ordering in case timeline, and fixed timeline to order by issue id

* Refactor create_decision_issues! to order case timeline IssueUpdateTasks in line with requirements

---------

Co-authored-by: William Medders <medders_william@bah.com>
* APPEALS-24867 Corrected rspecs

* APPEALS-24867 Fixed some linting
* added logic to delete any open special issue tasks that prevent new ones from being made

* removed logic for establishment task

* updated IssueUpdateTask outstanding task logic so it only appeals to the current appeal
* added workflow for adding a legacy issue with MST/PACT and creating a task/record

* updated params to add distinction between edit and added issue

* edited task creation to pull from params instead of issue model

* removed typo

* updated level 1 description for N/A option

* added N/A option for notes

---------

Co-authored-by: kristeja <112115264+kristeja@users.noreply.github.com>
* hearing_prep_spec fix

* legacy_hearing_spec.rb:242 fix

* legacy_hearing_spec.rb fix 2

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: William Medders <medders_william@bah.com>
* added nil error handling to contentions unpacking

* added next for nil payload
* update the spec with decision review from response

* fixed typo

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* AMA queue workflow feature test draft

* Newest Changes

* All tests are ready to run on a working ENV

* Final edits all tests passing

* added sleep for page load

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* appeal_spec & supplemental_claim_spec fixes

* comments

* removed binding.pry

---------

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
@kristeja kristeja assigned kristeja and HunJerBAH and unassigned HunJerBAH and kristeja Jul 13, 2023
@kristeja kristeja merged commit b058136 into master Jul 19, 2023
8 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.