Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/appeals 22218 master #19129

Merged
merged 634 commits into from
Aug 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
634 commits
Select commit Hold shift + click to select a range
66d87a0
Merge branch 'hearings/pacman-triple-j-branch-of-excellence' of https…
j-n-t-l Jun 27, 2023
3ef15e6
updated failing tests. Green is Go.
JCohen642 Jun 27, 2023
4de22e4
Add early return
ThorntonMatthew Jun 27, 2023
3f616f9
Merge branch 'hearings/pacman-triple-j-branch-of-excellence' of https…
ThorntonMatthew Jun 27, 2023
d9c900d
Remove mocks
ThorntonMatthew Jun 27, 2023
d0e7102
DB migration to add UUID columns to Pacman tables
ThorntonMatthew Jun 27, 2023
ff2ad68
APPEALS-21118 fixed vbms factories
j-n-t-l Jun 27, 2023
bc0f41b
APPEALS-24643 Added pacman_uuid column to comm package, distribution,…
msteele96 Jun 27, 2023
1e69036
APPEALS-21118 pacman service rspec changes
j-n-t-l Jun 27, 2023
7bec4d0
APPEALS-21118 get_distribution_request in pacmanservice should take i…
j-n-t-l Jun 27, 2023
2a4d350
APPEALS-21118 pacmanservice spec: fixed get distribution tests by cha…
j-n-t-l Jun 27, 2023
d38eb98
Audit tables updates
ThorntonMatthew Jun 27, 2023
055a7f5
Merge branch 'MattT/APPEALS-24643' of https://github.com/department-o…
ThorntonMatthew Jun 27, 2023
15b0665
Change get distro route to look up using pkid
ThorntonMatthew Jun 27, 2023
de9becf
Revert "Audit tables updates"
ThorntonMatthew Jun 27, 2023
88bccf9
Use different column name
ThorntonMatthew Jun 27, 2023
38a63d1
Update schema
ThorntonMatthew Jun 27, 2023
5c955cb
Minor refactoring
ThorntonMatthew Jun 27, 2023
be99980
Add missing commas
ThorntonMatthew Jun 27, 2023
84b6cf8
missed another comma
ThorntonMatthew Jun 27, 2023
d09b4cf
More commas
ThorntonMatthew Jun 27, 2023
95b92e3
CC Fixes
ThorntonMatthew Jun 28, 2023
fd555cd
Preliminary merge of the triple J branch to line up the shot
ThorntonMatthew Jun 28, 2023
ef98d61
Add pacman_uuid to factories
ThorntonMatthew Jun 28, 2023
086c12a
pacman_uuid to uuid to ease transition
ThorntonMatthew Jun 28, 2023
8254e61
Fix typo
ThorntonMatthew Jun 28, 2023
3e7e0bd
Alter fake
ThorntonMatthew Jun 28, 2023
4534b17
Missed a word
ThorntonMatthew Jun 28, 2023
afb462d
Fix distributions_controller_spec tests
ThorntonMatthew Jun 28, 2023
195965b
Try new mail_request_spec setup
ThorntonMatthew Jun 28, 2023
dbbd778
Update comm package factory
ThorntonMatthew Jun 28, 2023
ca062fa
Fix pacman_service_spec tests
ThorntonMatthew Jun 28, 2023
0c04376
Refactor
ThorntonMatthew Jun 28, 2023
505583e
Update comm package and distros with pacman ids as uuids
ThorntonMatthew Jun 28, 2023
4953e99
Remove UUID from destinations table since those just get lumped with …
ThorntonMatthew Jun 28, 2023
e05d696
APPEALS-24590 added logic to handle an edge case mapping dissn to pul…
kristeja Jun 28, 2023
e1c11f6
Remove uuid from dest factory
ThorntonMatthew Jun 28, 2023
a2d506d
More tests
ThorntonMatthew Jun 28, 2023
501bf39
APPEALS-21118 moved vbms package creation into begin block
j-n-t-l Jun 28, 2023
70c03a3
Merge branch 'hearings/pacman-triple-j-branch-of-excellence' of https…
j-n-t-l Jun 28, 2023
24d8be0
APPEALS-21118 initilialized PacmanApiError
j-n-t-l Jun 28, 2023
66c670d
APPEALS-21118 removed chunk of comments
j-n-t-l Jun 28, 2023
15258cd
Fix a spec failure
ThorntonMatthew Jun 28, 2023
db6154f
APPEALS-21118 fixed vbms comm package factory
j-n-t-l Jun 28, 2023
20f024d
APPEALS-24590 updated rating issue method logic in rating model
kristeja Jun 28, 2023
a5b0688
Will/appeals 24129 benefit type (#18887)
wmedders21 Jun 28, 2023
8cc772e
APPEALS-21118 changed rspec
j-n-t-l Jun 28, 2023
3ee3075
APPEALS-21118 added 500 error to error code hash
j-n-t-l Jun 28, 2023
a31ae32
APPEALS-21118 moved package creation outside of begin block
j-n-t-l Jun 28, 2023
bcfca90
APPEALS-21118 package is created only if post request is successful
j-n-t-l Jun 28, 2023
a55ca9f
APPEALS-21118 put code outside begin rescue block in else statement a…
j-n-t-l Jun 28, 2023
d8a0e67
Spec test tweaks
ThorntonMatthew Jun 28, 2023
0a69610
Will/appeals 24663 (#18890)
wmedders21 Jun 28, 2023
a8cae8d
Use bearer token
ThorntonMatthew Jun 28, 2023
f1dfb99
APPEALS-21118 fixed vbms destination factory validations
j-n-t-l Jun 28, 2023
a3ad480
Merge branch 'hearings/pacman-triple-j-branch-of-excellence' of https…
j-n-t-l Jun 28, 2023
55f6fcc
APPEALS-21118 fixed document_referenced document_version_reference_id
j-n-t-l Jun 28, 2023
30cc504
hearings/APPEALS-21118 and APPEALS-21121 APPEALS-21123 (#18814)
ThorntonMatthew Jun 29, 2023
1f31089
Merge remote-tracking branch 'origin/hearings/pacman-triple-j-branch-…
ThorntonMatthew Jun 29, 2023
38a165a
Add back in UUIDs
ThorntonMatthew Jun 29, 2023
f45e5c9
Merge remote-tracking branch 'origin/hearings/pacman-triple-j-branch-…
ThorntonMatthew Jun 29, 2023
907a83f
Merge remote-tracking branch 'origin/feature/APPEALS-19983' into Matt…
ThorntonMatthew Jun 29, 2023
f0ade18
Handle cases where we get an unforeseen error code
ThorntonMatthew Jun 29, 2023
efc3b16
Fix test
ThorntonMatthew Jun 29, 2023
9b93345
Merge branch 'master' into feature/APPEALS-17497
kristeja Jun 29, 2023
4bd792a
APPEALS-24590 updated logic to handle rating decision deserialize spe…
kristeja Jun 29, 2023
1cbd805
APPEALS-24578 update correct verbiage
kristeja Jun 29, 2023
1659836
Merge pull request #18884 from department-of-veterans-affairs/MattT/A…
ThorntonMatthew Jun 29, 2023
bd7215c
Merge branch 'master' into feature/APPEALS-19983
ThorntonMatthew Jun 29, 2023
ea5aa5c
HunJerBAH/APPEALS-23698 (#18748)
HunJerBAH Jun 29, 2023
39831c9
initial commit (#18901)
jonathanh-va Jun 29, 2023
6645081
APPEALS-24590 fix to get rba contention data
kristeja Jun 29, 2023
4f816f5
Merge remote-tracking branch 'origin/master' into feature/APPEALS-19983
ThorntonMatthew Jun 29, 2023
c7903bf
Feature Tests Legacy Queue Workflow (#18904)
Kevma50287 Jun 30, 2023
206cf73
Will/appeals 22928 vbms (#18906)
wmedders21 Jun 30, 2023
25391a1
jefftmarks/APPEALS-21125 (#18702)
jefftmarks Jun 30, 2023
196c3b4
Merge branch 'master' into feature/APPEALS-17497
kristeja Jun 30, 2023
1b35fc9
APPEALS-24578 fix pact special issues verbiage
kristeja Jun 30, 2023
ed7206c
HunJerBAH legacy seed script edits (#18913)
HunJerBAH Jun 30, 2023
2791072
:bulb: Add to comment
jcroteau Jul 1, 2023
fd89a81
:recycle: Reference Constants::BENEFIT_TYPES instead of local constant
jcroteau Jul 1, 2023
58306c7
:recycle: Extract factory for VRE business line
jcroteau Jul 1, 2023
4e6dc9b
:pencil2: Fix typo
jcroteau Jul 1, 2023
d4a563a
Will/appeals 24807 (#18911)
wmedders21 Jul 2, 2023
edfd953
Merge branch 'master' into feature/APPEALS-19983
ThorntonMatthew Jul 3, 2023
130990b
APPEALS-24844 update core contention pact special issues verbiage
kristeja Jul 3, 2023
b6b66b1
HunJerBAH/APPEALS-24844 (#18923)
HunJerBAH Jul 3, 2023
ef1a1d5
MattT/APPEALS-24860: Add JWT Support to Package Manager Service (#18920)
ThorntonMatthew Jul 3, 2023
b0b4f49
added 3 issues to the legacy generator (#18927)
HunJerBAH Jul 3, 2023
49bc012
Remove use of ERB::Util.url_encode (#18930)
ThorntonMatthew Jul 3, 2023
56f2e4b
Add back url var
ThorntonMatthew Jul 4, 2023
e38bea3
Fix spacing
ThorntonMatthew Jul 4, 2023
48d6ea4
Enable feature toggle (#18924)
SanthiParakal133 Jul 5, 2023
a257576
JHoang-17497 rspec fixes (#18926)
jonathanh-va Jul 5, 2023
4a6ccbb
Add issues spec updating failing feature tests. (#18929)
wmedders21 Jul 5, 2023
233e787
added logic to have decision special issues go to cavc remand (#18931)
HunJerBAH Jul 5, 2023
bf56678
added incrementing vacols id numbers to seed script (#18937)
HunJerBAH Jul 5, 2023
a4b7278
APPEALS-24844 updated contention pact special issues constant
kristeja Jul 5, 2023
4646121
Merge branch 'master' into feature/APPEALS-19983
ThorntonMatthew Jul 5, 2023
8c60d04
Fix uuid not being an attribute of string
ThorntonMatthew Jul 5, 2023
d4b8136
:loud_sound: Log time elapsed
jcroteau Jul 5, 2023
7ca851e
:recycle: Extract constant
jcroteau Jul 5, 2023
532b537
Incremental fixes
ThorntonMatthew Jul 5, 2023
f5c6ed6
:recycle: Refactor tests
jcroteau Jul 5, 2023
8bf6512
More tweaks
ThorntonMatthew Jul 5, 2023
7d9631d
Loop over distros in response
ThorntonMatthew Jul 5, 2023
3e124bd
MattT/19983-fixes (#18947)
ThorntonMatthew Jul 6, 2023
dcf89c3
:loud_sound: Log total tasks for cancellation
jcroteau Jul 5, 2023
4d04b76
:loud_sound: Log cancelled task ids
jcroteau Jul 6, 2023
28b4eed
:loud_sound: Log errored cancellations
jcroteau Jul 6, 2023
863788a
:recycle: Extract method
jcroteau Jul 6, 2023
4a4540c
:bug: Task #descendants already includes self
jcroteau Jul 6, 2023
008c750
:bug: Only include open tasks in total
jcroteau Jul 6, 2023
ab2f930
:bug: Only log cancellable (open) task ids
jcroteau Jul 6, 2023
e307156
:recycle: Extract method
jcroteau Jul 6, 2023
ebd3baa
:recycle: Replace query with temp
jcroteau Jul 6, 2023
1074d5b
:loud_sound: Log total cancelled
jcroteau Jul 6, 2023
7905710
:recycle: Slide statements into block
jcroteau Jul 6, 2023
a12f8f9
:recycle: Combine logging of cancellable tasks before/after into sing…
jcroteau Jul 6, 2023
fdbeaa0
:recycle: Rearrange method definitions
jcroteau Jul 6, 2023
ac40f89
:recycle: Rename method
jcroteau Jul 6, 2023
229d4be
:bulb: Add comments
jcroteau Jul 6, 2023
4e1ee8f
removing skip and making test work (#18943)
pamatyatake2 Jul 6, 2023
247dc97
Fixing the flaky test (#18944)
pamatyatake2 Jul 6, 2023
0bb6947
Request Issue Model spec test fix (#18940)
Kevma50287 Jul 6, 2023
289de11
JHoang-17497-rspec-fixes 2 (#18941)
jonathanh-va Jul 6, 2023
a2a656e
fix special issues display on review remand reasons for ama appeal (#…
jonathanh-va Jul 6, 2023
be2fd48
All tests passing (#18946)
wmedders21 Jul 6, 2023
454d558
Remove rspec skip: "flake" (#18928)
brandondorner Jul 6, 2023
102e913
Refactor IssueUpdater#create_issues_update_task (#18951)
wmedders21 Jul 6, 2023
d9967c6
Fix format_response
ThorntonMatthew Jul 6, 2023
2a2bd69
Log error if response body isn't able to be parsed as JSON
ThorntonMatthew Jul 6, 2023
df247af
Merge branch 'master' into feature/APPEALS-17497
kristeja Jul 6, 2023
e9ccd94
Add distro id to error log
ThorntonMatthew Jul 6, 2023
832f0b7
TYLERB/APPEALS-24082: Remove task_filter_spec.rb flakey test tag (#18…
TylerBroyles Jul 6, 2023
41ad030
Updated appeals and issues controllers to reposition benefit type. (#…
Blake-Manus Jul 6, 2023
551702c
Appeals 24989 - MST/PACT Badge Rendering during Judge decision review…
Kevma50287 Jul 6, 2023
c9b1216
:loud_sound: Append logs to stdout
jcroteau Jul 6, 2023
7fbca3a
:necktie: Ensure PaperTrail versions reflect appropriate whodunnit an…
jcroteau Jul 6, 2023
277e309
Merge branch 'master' into jcroteau/APPEALS-23894-close-vrr-tasks-for…
jcroteau Jul 7, 2023
04b61b9
Remove flake test skip for case_details_spec.rb
brandondorner Jul 6, 2023
162b74e
Merge branch 'master' into dev-support/skipped-test-updates
craigrva Jul 7, 2023
3f51eb8
HunJerBAH/APPEALS-25107 (#18964)
HunJerBAH Jul 7, 2023
30c582d
Merge branch 'master' into feature/APPEALS-17497
kristeja Jul 10, 2023
c85ad83
Merge branch 'master' into jcroteau/APPEALS-23894-close-vrr-tasks-for…
jcroteau Jul 10, 2023
c99cc68
Pamatya/appeals 24085 (#18966)
pamatyatake2 Jul 10, 2023
fd28618
appeals 25076 (#18975)
Blake-Manus Jul 10, 2023
528eeb0
Fixed failing rspecs (#18978)
Kevma50287 Jul 10, 2023
4262284
IssuesUpdateTask model Rspecs updated for format_instructions (#18921)
Kevma50287 Jul 10, 2023
54d429b
HunJerBAH/APPEALS-25276 (#18979)
HunJerBAH Jul 10, 2023
6b67f3e
HunJerBAH/APPEALS-25131 and APPEALS-25275 (#18973)
HunJerBAH Jul 10, 2023
6be56f7
JHoang-17497-rspec-fixes-3 (#18963)
jonathanh-va Jul 10, 2023
4305d22
Changed comparison to handle more than 10 records being present. (#18…
Rnmarshall93 Jul 10, 2023
5d1fab4
Fixed tests on ama_queue_spec.rb (#18967)
wmedders21 Jul 10, 2023
5ab000a
Removed redundant test because a more complete test for this exists i…
Rnmarshall93 Jul 10, 2023
8285baa
mock mst and pact on vacolsissue (#18957)
SanthiParakal133 Jul 10, 2023
87ad812
fix certification model flaky test (#18977)
csheepy Jul 10, 2023
d7fc53a
:rotating_light: Lint
jcroteau Jul 10, 2023
fdc394b
:white_check_mark: Fix broken spec
jcroteau Jul 10, 2023
9282bcc
HunJerBAH APPEALS-25283 (#18980)
HunJerBAH Jul 11, 2023
121eab9
Craig/appeals 24754 (#18976)
craigrva Jul 11, 2023
2ca8092
Add openapi spec for pacman
ThorntonMatthew Jul 11, 2023
1131c75
update the spec with decision review from response (#18969)
SanthiParakal133 Jul 11, 2023
2a20bd2
Ratings fix (#18985)
youfoundmanesh Jul 11, 2023
b028172
init upload examples
ThorntonMatthew Jul 11, 2023
9836541
recipient type is absent
ThorntonMatthew Jul 11, 2023
e4b9420
First name
ThorntonMatthew Jul 11, 2023
f27303b
Last name
ThorntonMatthew Jul 11, 2023
5e035ce
Treat lines as errors
ThorntonMatthew Jul 11, 2023
b3a5142
addresses
ThorntonMatthew Jul 11, 2023
36010b0
Add to other upload
ThorntonMatthew Jul 11, 2023
36865ff
Other upload
ThorntonMatthew Jul 11, 2023
8e36f8a
half of error scenarios
msteele96 Jul 11, 2023
4af42ef
Merge branch 'Matt/add-pacman-validation-errors' of https://github.co…
msteele96 Jul 11, 2023
65da2cb
Merge branch 'Matt/add-pacman-validation-errors' of https://github.co…
ThorntonMatthew Jul 11, 2023
ed3b207
Added routes to outcode
msteele96 Jul 11, 2023
ba1dce4
Merge branch 'Matt/add-pacman-validation-errors' of https://github.co…
msteele96 Jul 11, 2023
add8a3f
error cleanup
msteele96 Jul 11, 2023
6675237
Tweaks
ThorntonMatthew Jul 11, 2023
d011a28
Merge branch 'master' into feature/APPEALS-19983
ThorntonMatthew Jul 12, 2023
92d56fe
ThorntonMatthew Jul 12, 2023
6a02784
Revert accidental commit to master
ThorntonMatthew Jul 12, 2023
51362c0
Merge branch 'master' into feature/APPEALS-19983
ThorntonMatthew Jul 12, 2023
551ced7
ThorntonMatthew Jul 12, 2023
42cabe2
removing flake test (#18982)
pamatyatake2 Jul 12, 2023
e6bd5d0
Merge branch 'master' into dev-support/skipped-test-updates
craigrva Jul 12, 2023
257a0a1
Ensured original responses show in dropdown for swagger ui
msteele96 Jul 12, 2023
c2d998f
Merge branch 'Matt/add-pacman-validation-errors' into feature/APPEALS…
ThorntonMatthew Jul 12, 2023
2e5abad
Fix spelling error
brandondorner Jul 12, 2023
29e3405
Reinstate MTV changes
ThorntonMatthew Jul 12, 2023
f9230c6
nil handling fix
kristeja Jul 12, 2023
93d1fed
Removed the skip tag from docket_spec.rb spec test (#18984)
TylerBroyles Jul 12, 2023
d23f113
Revert
ThorntonMatthew Jul 13, 2023
a047064
Merge branch 'master' into lauren/APPEALS-24410
laurenberrybah Jul 13, 2023
9e6af29
Craig/appeals 24719 (#18987)
craigrva Jul 13, 2023
8b5a3f3
Fix flake spec "access the appeal's case details" (#18981)
brandondorner Jul 13, 2023
959bcc2
added handling for nil, single contention, and array of contentions i…
HunJerBAH Jul 13, 2023
5a16da8
Merge pull request #18959 from department-of-veterans-affairs/dev-sup…
craigrva Jul 13, 2023
43199c9
Khalin/appeals 22929 (#18989)
Dev-KRedd Jul 13, 2023
379ff92
JHoang/17497-rspec-fixes-4 (#18994)
jonathanh-va Jul 13, 2023
2e502c4
updated cavc dashboard to show all issues from source appeal regardle…
Jul 13, 2023
68badd5
Merge branch 'master' into JHoang/APPEALS-23520/23521
jonathanh-va Jul 13, 2023
7aa8cfb
removed comment
Jul 13, 2023
09043e7
Merge branch 'master' into feature/APPEALS-19983
ThorntonMatthew Jul 13, 2023
c3a82f5
Merge branch 'master' into feature/APPEALS-9414
ThorntonMatthew Jul 13, 2023
675325c
Merge branch 'master' into feature/APPEALS-17497
kristeja Jul 13, 2023
9a6b420
Update MAC_INTEL.md (#18997)
zurbergram Jul 13, 2023
c301f8a
Merge branch 'master' into feature/APPEALS-9414
ThorntonMatthew Jul 13, 2023
7e23a74
Merge branch 'master' into feature/APPEALS-19983
ThorntonMatthew Jul 13, 2023
55094c9
Merge branch 'master' into jcroteau/APPEALS-23894-close-vrr-tasks-for…
jcroteau Jul 13, 2023
c6fd98d
Merge branch 'master' into dorner/APPEALS-25338
craigrva Jul 13, 2023
b9462c0
Merge pull request #18991 from department-of-veterans-affairs/feature…
ThorntonMatthew Jul 13, 2023
9180022
Merge branch 'master' into feature/APPEALS-19983
ThorntonMatthew Jul 13, 2023
f0e85e8
Merge pull request #18625 from department-of-veterans-affairs/feature…
ThorntonMatthew Jul 13, 2023
af5ec12
Merge branch 'master' into lauren/APPEALS-24410
raymond-hughes Jul 13, 2023
59dadc8
Merge branch 'master' into dorner/APPEALS-25338
craigrva Jul 13, 2023
291b3dd
Merge pull request #18990 from department-of-veterans-affairs/dorner/…
craigrva Jul 13, 2023
97f1a9d
Merge branch 'master' into lauren/APPEALS-24410
raymond-hughes Jul 13, 2023
dd103f5
Merge branch 'master' of github.com:department-of-veterans-affairs/ca…
raymond-hughes Jul 13, 2023
6fec32a
updated bgs gem with latest ref
kristeja Jul 13, 2023
c192aed
Merge branch 'master' into feature/APPEALS-17497
kristeja Jul 13, 2023
cfd7f72
set rai with ternary instead of if/else
Jul 14, 2023
78bec5c
Remove deprecated stats specs - APPEALS/25431 (#18998)
brandondorner Jul 14, 2023
67dc572
Removing skip made this test pass (#18993)
pamatyatake2 Jul 14, 2023
c2c07e6
revert change to non-spec file
craigrva Jul 14, 2023
d52267f
Merge pull request #19002 from department-of-veterans-affairs/dev-sup…
craigrva Jul 17, 2023
95ad661
update m1 setup instructions (#19005)
craigrva Jul 17, 2023
930a8ec
Merge branch 'master' into feature/APPEALS-17497
kristeja Jul 17, 2023
1b3640c
remove checks for cache values and change from call_original to retur…
craigrva Jul 17, 2023
a2f50de
Merge branch 'master' into jcroteau/APPEALS-23894-close-vrr-tasks-for…
raymond-hughes Jul 17, 2023
22c427f
Merge pull request #18948 from department-of-veterans-affairs/jcrotea…
raymond-hughes Jul 17, 2023
965e712
Merge branch 'master' into feature/APPEALS-17497
kristeja Jul 17, 2023
c247c50
fix potentially flaky finds (#19014)
craigrva Jul 18, 2023
d27460e
Merge branch 'master' of https://github.com/department-of-veterans-af…
craigrva Jul 18, 2023
7644d0e
PR Template Fixes
ThorntonMatthew Jul 18, 2023
5d64701
Merge pull request #19011 from department-of-veterans-affairs/dev-sup…
craigrva Jul 18, 2023
d83fb2a
modify formatting, add notes and foreword (#19015)
craigrva Jul 18, 2023
1b13fe0
Add a comment
ThorntonMatthew Jul 18, 2023
e169121
Add another comment
ThorntonMatthew Jul 18, 2023
5c725dc
Merge branch 'dev-support/PR-template-spelling-fix'
ThorntonMatthew Jul 18, 2023
d5f2fcc
Merge branch 'master' into JHoang/APPEALS-23520/23521
zurbergram Jul 19, 2023
37cd114
add checks back in for cavc_remands_with_dashboard
Jul 19, 2023
768c372
Merge branch 'JHoang/APPEALS-23520/23521' of https://github.com/depar…
Jul 19, 2023
1a8d0fb
Merge branch 'master' into feature/APPEALS-17497
kristeja Jul 19, 2023
b058136
Merge pull request #18472 from department-of-veterans-affairs/feature…
kristeja Jul 19, 2023
21f05ac
Revert "Feature/APPEALS-17497 MST/PACT Act Special Identification"
zurbergram Jul 20, 2023
d3dac4d
Merge pull request #19032 from department-of-veterans-affairs/revert-…
zurbergram Jul 20, 2023
9ded555
Merge branch 'master' into JHoang/APPEALS-23520/23521
zurbergram Jul 21, 2023
2d72925
Merge pull request #19000 from department-of-veterans-affairs/JHoang/…
zurbergram Jul 21, 2023
e7c0e49
Merge branch 'master' into feature/APPEALS-22218-master
mikefinneran Aug 3, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ Rails/LexicallyScopedActionFilter:
Rails/SkipsModelValidations:
Enabled: false

Rails/ApplicationController:
Exclude:
- app/controllers/idt/api/v1/base_controller.rb

Rails/FilePath:
Enabled: false

Expand Down
91 changes: 44 additions & 47 deletions MAC_INTEL.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
[<< Back](README.md)

**Pre-requisites for setup:**
**Some steps require completing VA On-boarding**

1. Create GitHub user account [VA github access process](https://department-of-veterans-affairs.github.io/github-handbook/guides/onboarding/getting-access)

Expand All @@ -20,46 +21,37 @@
2. Install Homebrew
* a. Using BAH Self Service if BAH employee Run ```brew install git-lfs .``` This is required to clone caseflow-facols repo

3. Create a caseflow-setup folder by typing: `mkdir caseflow-setup` (step can be skipped if you have the file transfer files)
3. Create an appeals folder by typing: `mkdir ~/appeals`

4. Change directory to caseflow-setup by typing: `cd caseflow-setup`
4. Change directory to appeals by typing: `cd appeals`

5. Navigate to [instant client](https://www.oracle.com/database/tecdchnologies/instant-client/linux-x86-64-downloads.html)

6. Download the following zip files to caseflow-setup directory (Copy from downloads to the caseflow-setup directory if they download to downloads) (Step can be skipped if you received the file transfer files)
6. Download the following zip files (Step can be skipped if you received the file transfer files)
* instantclient-basic-linux.x64-12.2.0.1.0.zip
* instantclient-sqlplus-linux.x64-12.2.0.1.0.zip
* instantclient-sdk-linux.x64-12.2.0.1.0.zip

7. Clone caseflow repositories required for setup into caseflow-setup directory (caseflow-facols requires github account and the account has to be in the VA org in github and can be found in the file transfer files) pwd
* HTTP protocol
* `git clone https://github.com/department-of-veterans-affairs/caseflow.git`
* `git clone https://github.com/department-of-veterans-affairs/caseflow-facols.git`
* Upon completion, navigate to caseflow-facols (`cd ~/caseflow-setup/caseflow-facols`)
* Run: `git lfs install` (needed to initialize large file storage in repo)
* Run: `git lfs pull` (this will pull the large zipfile)
* If you do not have VA access yet to clone caseflow-vacols can contact (Your Tech lead or the bid_appeals_mac_support channel) to receive a zip of the repository
7. Clone the following caseflow repositories required into appeals directory
* https://github.com/department-of-veterans-affairs/caseflow
* https://github.com/department-of-veterans-affairs/caseflow-facols

**SSH protocol**
8. Upon completion, navigate to caseflow-facols (`cd ~/appeals/caseflow-facols`)
1. Run: `git lfs install` (needed to initialize large file storage in repo)
2. Run: `git lfs pull` (this will pull the large zipfile)
3. Copy the `~/appeals/caseflow-facols/build_facols` directory into `~/appeals/caseflow/local/vacols/` directory.

1. `git clone git@github.com:department-of-veterans-affairs/caseflow.git`
9. Navigate to the caseflow directory in your terminal (type: `cd ~/appeals/caseflow`) and checkout the grant/setup-no-aws branch `git checkout grant/setup-no-aws`

2. `git clone git@github.com:department-of-veterans-affairs/caseflow-facols.git`
* Upon completion, navigate to caseflow-facols (`cd ~/caseflow-setup/caseflow-facols`)
* Run: `git lfs install` (needed to initialize large file storage in repo)
* Run: `git lfs pull` (this will pull the large zipfile)
10. Navigate to caseflow/docker-bin directory (type: `cd docker-bin`)

3. Navigate to the caseflow directory in your terminal (type: `cd ~/caseflow-setup/caseflow`) and checkout the grant/setup-no-aws branch `git checkout grant/setup-no-aws`
11. Create oracle_libs subdirectory (type: `mkdir oracle_libs`)

4. Navigate to caseflow/docker-bin directory (type: `cd docker-bin`)
12. Copy the 3 instant-client zip files from step 6 into the oracle_libs directory

5. Create oracle_libs subdirectory (type: `mkdir oracle_libs`)
13. Navigate to the caseflow root directory (type: `cd ~/appeals/caseflow`)

6. Copy the 3 instant-client zip files from the caseflow-setup directory into the oracle_libs directory

7. Navigate to the caseflow root directory (type: `cd ..`)

8. Run scripts/dev_env_setup_step1.sh script from bash terminal (How to run script in Mac Terminal) (Will be prompted for a password will be the SUDO password which is the password used to log into mac after restart)
14. Run `scripts/dev_env_setup_step1.sh` script from bash terminal [[How to run script in Mac Terminal](https://apple.stackexchange.com/questions/235128/how-do-i-run-a-sh-or-command-file-in-terminal)] (Will be prompted for a password will be the SUDO password which is the password used to log into mac after restart)
* If/When mac says Chromedriver cannot be opened do this:
* Click cancel on the warning modal
* Push Command + Space
Expand All @@ -68,50 +60,55 @@
* Click General tab
* Click the lock icon and put in your BAH pin Click allow anyway on chromedriver warning Click the lock icon to re lock

9. Setup Docker to use 4 CPUs and 8G memory and sign-in to your personal DockerHub account
15. Setup Docker to use 4 CPUs and 8G memory and sign-in to your personal DockerHub account
* To get to these settings:
* Command + Space
* Type docker
* Click docker desktop
* Click the gear icon
* Click Resources

10. The script updated your bash profile and you need to resource it into the terminal by typing: `source ~/.bash_profile`
16. The script updated your bash profile and you need to resource it into the terminal by typing: `source ~/.bash_profile`
* If using zsh, will need to update and `source ~/.zshrc` instead

11. `brew install shared-mime-info`
17. `brew install shared-mime-info`

12. `brew install v8@3.15`
18. `brew install v8@3.15`

13. Run scripts/dev_env_setup_step2.sh script (may take a while to run)
19. Run `scripts/dev_env_setup_step2.sh` script (may take a while to run)

14. Run `gem install bundler`
* Copy the caseflow-facols/build_facols directory to the caseflow/local/vacols subdirectory. (Ensure you have a caseflow/local/vacols/build_facols directory with all the files before continuing to the next step)
20. Run `gem install bundler`

15. Navigate to caseflow/local/vacols in terminal `cd ~/caseflow- setup/caseflow/local/vacols`
21. Navigate to `~/appeals/caseflow/local/vacols` in terminal (type: `cd ~/appeals/caseflow/local/vacols`)

16. Run `./build_push.sh local`
* Requires the oracle database image to have been pulled after running scripts/dev_env_setup_step1.sh script
22. To install the latest and enterprise Oracle Database version follow (https://seanstacey.org/deploying-an-oracle-database-19c-as-a-docker-container/2020/09/) guide.
1. Go to http://container-registry.oracle.com/ (Here log in and opt for Database)
2. On command line `docker login container-registry.oracle.com`
3. On command line `docker pull container-registry.oracle.com/database/enterprise:latest`

17. Navigate to caseflow root directory `cd ~/caseflow-setup/caseflow`
23. Run `./build_push.sh local`

18. Run `docker-compose up –d`
24. Navigate to caseflow root directory `cd ~/appeals/caseflow`

19. Run `bundle exec rake db:create`
* If you get connection issues stating no file to be found, run the following:
* `rm /opt/homebrew/var/postgres/postmaster.pid` or possibly `rm /usr/local/var/postgres/postmaster.pid`
* `brew services restart postgresql`
25. Run `ln -s Makefile.example Makefile`

20. Run `bundle exec rake local:vacols:seed`
26. Run `make up`

21. Run `bundle exec rake db:schema:load db:seed`
27. Run `make reset`
* If issues occur:
1. Run `bundle exec rake db:create`
* If you get connection issues stating no file to be found, run the following:
* `rm /opt/homebrew/var/postgres/postmaster.pid` or possibly `rm /usr/local/var/postgres/postmaster.pid`
* `brew services restart postgresql`
2. Run `bundle exec rake local:vacols:seed`
3. Run `bundle exec rake db:schema:load db:seed`

22. Open a new tab in terminal
27. Open a new tab in terminal

23. In new tab run make: ```run-backend```
28. In new tab run make: ```run-backend```

24. In the old tab run: ```make run-frontend```
29. In the old tab run: ```make run-frontend```

25. Navigate to localhost:3000 in browser to see the application
30. Navigate to localhost:3000 in browser to see the application

[<< Back](README.md)
Loading
Loading