Feature/appeals 22218 master #19129

…://github.com/department-of-veterans-affairs/caseflow into hearings/pacman-triple-j-branch-of-excellence

… and destination audit tables and functions

…n int not string

…nging distribution id and communicationpackageid from string to int

…f-veterans-affairs/caseflow into MattT/APPEALS-24643

This reverts commit d38eb98.

…distros in pacman

…l core contentions special issues if the disabilities does not have any special issues

…://github.com/department-of-veterans-affairs/caseflow into hearings/pacman-triple-j-branch-of-excellence

* Added benefit type to decision review issues update task * Added benefit type to intake edit issues update task * Added benefit type to legacy decision review issues update task * revert flash message * Refactor flash message logic for legacy intake edit * restored schema from feature branch --------- Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

…nd added/updated test for unsuccessful execution of mailrequestjob

* Added benefit type to establishment task * Capitalize IssuesUpdateTask benefit type for AMA edit * Change condition to contested_issue_description --------- Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

…://github.com/department-of-veterans-affairs/caseflow into hearings/pacman-triple-j-branch-of-excellence

* branch init * Appeals-21123 updated create method in upload_vbms_document_controller to utilize distribution/destination params * Appeals-21123 updated error.rb, providing a new error type that can be sent back to IDT client. * linting changes to exiting lines of code. Added new error for use in vbms_document_upload_controller when expected params aren't included * APPEALS-21123 created new mail_request class that will handle object creation and also keep controller thin. * APPEALS-21118 created job file * APPEALS-21118 added pacman calls * APPEALS-21118 updated response * APPEALS-21118 added error handling * APPEALS-21118 extra logging and added rspec file * APPEALS-21118 added fakes for vbms package, dist, and dist dest * APPEALS-21118 updated factories and rspec * APPEALS-21123 included activeModel valitations. provided Logic for validation within mailrequest.rb * added conditional logic for param checking and object creation along with error logging. * cleaned up controller code. leaving majority of logic to the new mail_request.rb workflow. * logic implemented that creates a vbms_distribution and vbms_distribution_destination. currenlty raw JSON is being saved(no parsing of the values). * Passed MailRequest object and VBMS document to MailRequestJob * removed email/phone number param checks and validation logic. * created factory to help with specs for mail_request workflow. * removed the optional attribute on the belongs_to relationship expressed in the beginning of the file. * Passed MailObject to MailObjectJob after successful VBMS document upload: * Undid changes yet to be merged from APPEALS-21123 * Used uploaded_to_vbms_at property instead of processed_at * Added tentative unit tests to UploadDocumentToVbmsJob * Incorporated new recipient_info param * Refactored to reflect change to array of multiple recipients * Simplified workflow in anticipation of changes to AC * inserted conditional logic. providing expected behavior as stated by the AC. * chaged constant array to anticipate nested params. * added test in controller to check for creation of mail req object * factories for valid mail request object and invalid mail request object created. * Refactored mail_request default value * Added logging * Refactored UploadVbmsDocumentController#create to be more DRY * Refactored private methods * Changed variable names * Changed method names to be more descriptive * Changed mail_request back to object instead of array of objects to meet new AC * Completed unit test * APPEALS-21123 provided functionality for multiple recipient_info parameters. * APPEALS-21123 removed frozen array. made adjustments to init method. place create methods under the private keyword. * APPEALS-21123 spec clean-up. * Updated unit tests with instance and class doubles * APPEALS-21118 updated perform method parameters * APPEALS-21123 controller fixed to return distribution_ids along with message as JSON * Fixed spacing in rails log message * APPEALS-21123 made edit to missing_recipient_info error in file. * added begin/ensure blocks. providing functionality that will allow code to continue even if an exception rises. * updated logic in file adding and additional attribute to the accessor block. * APPEALS-21123 added code to handle incomplete params. * APPEALS-21123 added accessors. adjusted call method. * APPEALS-21123 added code to handle incomplete params. * APPEALS-21118 updated create_distribution with recipient and destination hashes * APPEALS-21118 added comments to methods * added comments to new code for possible future dev support. * Refactored controller * Abstracted validations into a shared concern to make available to MailRequest object * APPEALS-21123 controller testing completed. Changes made to mail_request factory. MailRequest spec is created. * Added comments * spec updates, comment change in controller. * method refactor * Updated controller to validate copies and pass to MailRequestJob * validation methods updated * spec changes, All Green, appropriate codecoverage. edit to one of the validations in mail_request file.Update the factory for mail_request as well * Changed name of method * Use concern * Merged APPEALS-21121 and APPEALS-21123 in UploadVbmsDocumentController * Uncommented out arguments * Refactored code in controller and fixed formatting of error messages * Fixed issue of global variable in mail request validator * Fixed so it only checks for recipient errors after mapping through all recipients instead of erroring out at first invalid request * Implemented tap method to consolidate code * Consolidated mail_requests and copies params into one payload to pass through workflow * Condensed number of arguments for upload job into a parameter object * Fixed line too long in distribution destination spec * Removing instance variables to comply with reek * Refactor params to resolve reek issues * Rolled back refactoring changes * Removed unnecessary method * Fixed linting * Reformated instance variables * One last shot at fixing reek parameters issuegit add . * Fixed error and updated spec * Fixed spacing in base controller * APPEALS-21118 added to rspec * changes made to mail_request syntax. * Updated spec to account for MailRequestJob queue * Oops * updated mail_request method to set the created_by_id attribute of a created vbms_distribution at the time of creation. * APPEALS-21118 updated mail_request usage * Created MailPackageConcern and refactored controller to implement concern * Updated spec files to reflect introduction of MailRequestJob * Refactored mail package concern to remove unnecessary included_do black * Added created_by_id to mail package payload * Convert mail requests to json instead of array of mail requests to json * APPEALS-21118 fixed parameters * APPEALS-21118 organized comments * Updated spec file * Changed comment * APPEALS-21118 fakes->externalapi * made rubocop changes in spec file. * Remove deprecated URI.escape method * Key name to camelCase * APPEALS-21118 fixed code based on feedback * provided changes to spec files per PR request. Also Fixed failing tests in MailRequestSpec. * Add some lint ignores to methods that will no need to change * APPEALS-21118 error handling changes * APPEALS-21118 removed fakes * APPEALS-21118 removed unnecessary error handling * APPEALS-21118 updated rspec * APPEALS-21118 PacMan -> Pacman * APPEALS-21118 fixed current_user in rspec * Corrected validation on copies attribute of VbmsCommunicationPackage * Correct unit test for VbmsDistribution to reflect optional communication package * APPEALS-21118 fixed pacman service spec: participant_id to participantId * updated failing tests. Green is Go. * Add early return * Remove mocks * APPEALS-21118 fixed vbms factories * APPEALS-21118 pacman service rspec changes * APPEALS-21118 get_distribution_request in pacmanservice should take in int not string * APPEALS-21118 pacmanservice spec: fixed get distribution tests by changing distribution id and communicationpackageid from string to int * CC Fixes * APPEALS-21118 moved vbms package creation into begin block * APPEALS-21118 initilialized PacmanApiError * APPEALS-21118 removed chunk of comments * APPEALS-21118 fixed vbms comm package factory * APPEALS-21118 changed rspec * APPEALS-21118 added 500 error to error code hash * APPEALS-21118 moved package creation outside of begin block * APPEALS-21118 package is created only if post request is successful * APPEALS-21118 put code outside begin rescue block in else statement and added/updated test for unsuccessful execution of mailrequestjob * Spec test tweaks * Use bearer token * APPEALS-21118 fixed vbms destination factory validations * APPEALS-21118 fixed document_referenced document_version_reference_id --------- Co-authored-by: Jonathan Cohen <cohen_jonathan@bah.com> Co-authored-by: j-n-t-l <611441@bah.com> Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com> Co-authored-by: Jonathan Cohen <121630615+JCohDev@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>

…of-excellence' into MattT/APPEALS-24643

…of-excellence' into feature/APPEALS-19983

…T/APPEALS-24643

…cial issue hash method

…PPEALS-24643 MattT/APPEALS-24643

* created special_issue_changes table * created record for established issues * made edit mst/pact and vbms mst/pact not mandatory * added special issue change log for AMA edit * updated establishment special issues record * added legacy appeal Special Issue record * added legacy Special Issue change record for decisions * added special issue change record to case reviews for AMA * added justification FT to MST/PACT justification field * updated AMA decisions workflow to match decision tracking changes * fixed bug with legacy success message on edit page * added decision issue id to special issue changes table * moved mst/pact task/reporting creation to issue updater * added decision review mst/pact overruling issue mst/pact status

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>

* Preliminary Changes to feature test * APPEALS-22932 Features tests legacy appeal issue edit * Created all four scenarios * refactor * APPEALS-22932 Specified node element - all tests pass * Last Refactor * Revmoed pseudocode --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* WIP AMA intake workflow feature tests Finished tests not coming from contention * Test: WIP mst contention coming from VBMS * WIP VBMS contention mock * remove setup before refactor * Feature tests for MST/PACT coming from VBMS during intake. --------- Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* Created MailRequest object and passed from control to dispatch workflows: * Changed name of method to create mail request distributions * Condensed calls to params with a method * Mocked up sending back distribution ids * Added comments and logging * Reformatted AmaAppealDispatch spec and added mail request examples * Added comments * Updated comments * Updated workflow to pass multiple mail requests and copies attribute * Refactored to mirror UploadDocumentToVbmsController * Completed unit test for AmaAppealDispatch * Refactored spec for LegacyAppealDisaptch * Completed unit tets for LegacyAppealsDispatch and AmaAppealDispatch * Refactored code to pass unit tests * Completed unit tests for AppealsController * Changed global variable * Refactored with MailPackageConcern * Removed mail package concern and moved to APPEALS-21121 * Updated unit tests after merging in MailRequest object and MailRequestJon * Added check in spec file for invalid recipient info * Reordered examples in spec file * Refactored workflow to pass DecisionDocument into MailRequestJob * Added columns to DecisionDocument and update reference columns after Vbms upload * Updated polymorphic associations between CommPackage, VbmsUploadedDoc, and DecisionDoc * Changed column names and added index for polymorphic document association for VbmsCommPackage * Updated MailRequestJob to fit polymorphic association * Remove byebug * Update columns in audit tables and triggers * Remove defunct columns * Adjust comm package factory * Updated spec for comm package and made polymorphic assoc not optional * Fix a couple spec files * Adjust AmaAppealDispatch spec * Adjust BvaDispatchTask specs * Ignore our new attrs on DecisionDocument * Add all_dbs tag to LegacyAppealDispatch spec * Break out notification type seeds to a before all * Try forcibly cleaning up after legacy dispatch tests * Oops, we're not paralellizing here * Allow outcode items to wrap --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>

* test script edits for legacy appeal rake task * take 2 building a task tree * staff_attrs and decass_attrs * added toggle to create special issues * removed old code and added user inputs * made css id input to upper case by default * added docket number incrementing * update bfcurloc, remove disposition off issue, lessen appeal total count creation * woops first not last * set decision date to nil * lowered appeal count for testing --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>

* Refactored TaskRows for IssuesUpdateTask styling and sequence * Refactored issue description for Legacy Appeals in IssuesUpdateTask * Uncomment validations --------- Co-authored-by: William Medders <medders_william@bah.com>

* added PEES1 to PACT contention spis_tc code search * added pees1 code search for request issue contention search

* Remove TOKEN from default header * Add JWT generation to pacman service * Bring over base64url * Tweak env vars * Change comment * Create JwtGenerator conncern * Add concern file * Remove comment * Going to place SAML token into store in non-UTF-8 * Add env vars to Rails env configs --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>

Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>

* spec update for withdrawn_request_issues, contestable_issue, decision_review, and initial_tasks_factory * fix bva_dispatch_return_flow_spec * fix bva_dispatch_return_flow_spec * quality_review_flow_spec update --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>

* Test: MST and PACT checkboxes DO NOT appear after selecting decision in higher level review * MST and PACT checkboxes render a justification field when checked * Updated failing specs * Test: all relevant tests passing --------- Co-authored-by: William Medders <medders_william@bah.com>

* Adjust destination hash creation * Alter get_recipient_hash * Change hash syntax * Pass in comm package uuid as ID * Fix endpoint * Fix transaction * Add comment * Paranoia mode * Another backup plan * Comments * More paranoia --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>

* Updated Request Issue model specs * DRY Refactor --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* apeals_details_serializer_spec.rb * fix decision_document_syncer_spec & decision_issue_syncer_spec * nonrating_request_issue_modal_spec * delete_request_issues_spec --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>

…18945) Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

In the process of maintaining a better testing suite we are attempting to remove all rspec tests that are skipped. This specific instance there was a skip that is no longer needed as the test does not fail. We can also remove supplemental claims being created as they aren't relevant to the test.

Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

) * Removed flakey tag from a test in task_filter_spec and a test in hearings_controller_spec. * Updated the appeal_series_issue_spec. * Changed expect to properly match the subject for one test. * Removed an expect statement that was no longer valid.

…18955) Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

… process (#18954) * APPEALS-24989 Fixed MST PACT Badges rendering during dispatch * APPEALS-24989 Added code comments --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

…t_id for cancelled tasks

…-vre-business-line

In the process of maintaining a better testing suite we are attempting to remove all rspec tests that are skipped. This specific instance there was a skip that is no longer needed as the test does not fail when ran. Upon further research it looks like the pagination has been fixed and now allows the test to work correctly.

* added check for decision issues instead of all issues for mst pact badges * refactored mst/pact badges to check for issues in flight before status on appeal model.

…-vre-business-line

* APPEALS-24085: removing skip * APPEALS-24150: flaky has seems to fix by itself

* Updated Task Row ordering in case timeline, and fixed timeline to order by issue id * Refactor create_decision_issues! to order case timeline IssueUpdateTasks in line with requirements --------- Co-authored-by: William Medders <medders_william@bah.com>

* APPEALS-24867 Corrected rspecs * APPEALS-24867 Fixed some linting

* added logic to delete any open special issue tasks that prevent new ones from being made * removed logic for establishment task * updated IssueUpdateTask outstanding task logic so it only appeals to the current appeal

* added workflow for adding a legacy issue with MST/PACT and creating a task/record * updated params to add distinction between edit and added issue * edited task creation to pull from params instead of issue model * removed typo * updated level 1 description for N/A option * added N/A option for notes --------- Co-authored-by: kristeja <112115264+kristeja@users.noreply.github.com>

* hearing_prep_spec fix * legacy_hearing_spec.rb:242 fix * legacy_hearing_spec.rb fix 2 --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>

)

Co-authored-by: William Medders <medders_william@bah.com>

…n issues_update_task_spec.rb (#18965)

* added nil error handling to contentions unpacking * added next for nil payload

* refactor test to use factories instead of Model.create, fix associations * remove hardcoded CSS IDs * fix lint * tweaks to tests with failures in GHA

* update the spec with decision review from response * fixed typo --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

…m/department-of-veterans-affairs/caseflow into Matt/add-pacman-validation-errors

This reverts commit 92d56fe.

* removing flake test * removing commented code * removing typo and nocov * removing commented code

…-19983

VLJs are reporting that their Unassigned tabs are misspelled as "Unassgined"

* modify test data and setup * fix hearings controller spec assertion * replace array sorting with match_array in dispatch task spec where applicable * added comment for why time is 11:30pm

…n the BGS response (#18996)

…port/skipped-test-updates Dev support/skipped test updates

* AMA queue workflow feature test draft * Newest Changes * All tests are ready to run on a working ENV * Final edits all tests passing * added sleep for page load --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* appeal_spec & supplemental_claim_spec fixes * comments * removed binding.pry --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

…ss of issues on the remand

* Update MAC_INTEL.md * Update MAC_INTEL.md * Update MAC_INTEL.md * update setup scripts * Update MAC_INTEL.md

…-vre-business-line

…/APPEALS-9414 feature/APPEALS-4011: Tracking Branch

…/APPEALS-19983 Tracking PR for APPEALS-19983

…APPEALS-25338 Fix spelling error - "Unassgined" to "Unassigned" - APPEALS/25338

…seflow

* Remove obsolete Dispatch_stats specs The dispatch_stats logic is deprecated and is now being fully deleted. We can remove the specs as part of that process. * Remove certification_stats specs The certification_stats logic is deprecated and is now being fully deleted. We can remove the specs as part of that process.

* Removing skip made this test pass * Adding puts to see what value does response body has * testing database result * testing database result * running db cleaner before to make sure hearing day is always contains 1 and 2 * resetting Pk in hearing table before all

…port/skipped-test-updates-2 Remove deprecated stats specs - APPEALS/25431 (#18998)

* update m1 setup instructions * add how to determine procssor type

…n an obj (#19010)

…-vre-business-line

…u/APPEALS-23894-close-vrr-tasks-for-vre-business-line jcroteau/APPEALS-23894 - Close VeteranRecordRequest tasks for Veterans Readiness and Employment (VRE) business line

* ✨ Introduce method object CancelTasksAndDescendants * ✨ Introduce rake task remediations:cancel_vrr_tasks_open_for_vre * 🚚 Move VeteranRecordRequestsOpenForVREQuery into its own namespace * 💡 Add to comment * ♻️ Reference Constants::BENEFIT_TYPES instead of local constant * ♻️ Extract factory for VRE business line * ✏️ Fix typo * 🔊 Log time elapsed * ♻️ Extract constant * ♻️ Refactor tests * 🔊 Log total tasks for cancellation * 🔊 Log cancelled task ids * 🔊 Log errored cancellations * ♻️ Extract method * 🐛 Task #descendants already includes self * 🐛 Only include open tasks in total * 🐛 Only log cancellable (open) task ids * ♻️ Extract method * ♻️ Replace query with temp * 🔊 Log total cancelled * ♻️ Slide statements into block * ♻️ Combine logging of cancellable tasks before/after into single method * ♻️ Rearrange method definitions * ♻️ Rename method * 💡 Add comments * 🔊 Append logs to stdout * 👔 Ensure PaperTrail versions reflect appropriate whodunnit and request_id for cancelled tasks * 🚨 Lint * ✅ Fix broken spec * fix potentially flaky finds --------- Co-authored-by: Jeremy Croteau <jeremiah.croteau@va.gov> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>

…fairs/caseflow into dev-support/test-updates

…port/test-updates dev-support/test-updates

* modify formatting, add notes and foreword * add missing parenthesis

…tment-of-veterans-affairs/caseflow into JHoang/APPEALS-23520/23521

…/APPEALS-17497 Feature/APPEALS-17497 MST/PACT Act Special Identification

…18472-feature/APPEALS-17497 Revert "Feature/APPEALS-17497 MST/PACT Act Special Identification"

…APPEALS-23520/23521 APPEALS-23521 CAVC Dashboard not showing all issues for Remand

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/appeals 22218 master #19129

Feature/appeals 22218 master #19129

Commits on Jun 27, 2023

Commits on Jun 28, 2023

Commits on Jun 29, 2023

Commits on Jun 30, 2023

Commits on Jul 1, 2023

Commits on Jul 2, 2023

Commits on Jul 3, 2023

Commits on Jul 4, 2023

Commits on Jul 5, 2023

Commits on Jul 6, 2023

Commits on Jul 7, 2023

Commits on Jul 10, 2023

Commits on Jul 11, 2023

Commits on Jul 12, 2023

Commits on Jul 13, 2023

Commits on Jul 14, 2023

Commits on Jul 17, 2023

Commits on Jul 18, 2023

Commits on Jul 19, 2023

Commits on Jul 20, 2023

Commits on Jul 21, 2023

Commits on Aug 3, 2023