-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caceves/appeals 27311 31542 #21430
Closed
Closed
Caceves/appeals 27311 31542 #21430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial Commit * Running tests * Adding appellant phone number to serializer * Adding paper case attribute * Add attributes to search hash * add KNAPSACK_PRO_FIXED_QUEUE_SPLIT to workflow.yml (#20329) * add KNAPSACK_PRO_FIXED_QUEUE_SPLIT to workflow.yml * update deprecated method for knapsack * add comment --------- Co-authored-by: AimanK <Aiman.Kayad@va.gov> Co-authored-by: raymond-hughes <raymond.hughes2@va.gov> Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>
This reverts commit 084cd98.
* Test spec fixes * lint issue
* Refactor Correspondence Controller - Move intake processing logic to new service. - Clean up some class variables in controller to use method. * Create Tasks Not Related To Appeal * Fix Issues with Creating Unrelated Appeal Tasks * Task Routing: Mail Tasks additions * Fix Create Mail Tasks Bugs - Fix issues preventing mail tasks from being created. - Enhance specs for creating mail tasks and tasks not related to an appeal. - Fix linting errors. * Add Exemptions when Creating Correspondence Tasks * Refactor Task Creating Edge Case Handling - Update the Correspondence class to responde to Appeal methods vs. littering the code with conditionals. * Fix Linting Error * Update correspondence_controller_spec.rb Fix spec failure --------- Co-authored-by: Dev-KRedd <khalin.redding@va.gov>
* Fixed UAT seed data * fix in uat seed data veteran save * Added in missing fields --------- Co-authored-by: Kevin Ma <magavakevin10@gmail.com> Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
* remove package * Added Correspondence Task Serializer to show type * Added isReadOnly check to tasks on initial fetch * Jest test fix * Removed duplicate method * Remove dropdown for readOnly page * Added feature test * Added extra check for banner * Typo fix * Fixed packageActionModal jest test * Add Banner * spec files * fix rubocop error * fix modal * Fix spec file * Disabled all buttons --------- Co-authored-by: Kevin Ma <magavakevin10@gmail.com> Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com>
* Refactored task ID logic for related tasks. * Updated logic to be cleaner. --------- Co-authored-by: Jim Foley <james.foley4@va.gov>
* Added Correspondence Task Serializer to show type * Added isReadOnly check to tasks on initial fetch * Jest test fix * Removed duplicate method * Remove dropdown for readOnly page * Added feature test * Added extra check for banner * Typo fix * Fixed packageActionModal jest test * Added guard to error handling * Spec fix * Missing comma * Piedram/appeals 36343 (#20350) * remove package * Added Correspondence Task Serializer to show type * Added isReadOnly check to tasks on initial fetch * Jest test fix * Removed duplicate method * Remove dropdown for readOnly page * Added feature test * Added extra check for banner * Typo fix * Fixed packageActionModal jest test * Add Banner * spec files * fix rubocop error * fix modal * Fix spec file * Disabled all buttons --------- Co-authored-by: Kevin Ma <magavakevin10@gmail.com> Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com> --------- Co-authored-by: piedram <110848569+piedram@users.noreply.github.com>
… is disabled (#20335) * Adding under construction page for authorized users * fixing cmp spec * routing more specs to under_construction - rspec job 12,5 * Test run helpers * adding test for unauthorized * Changing from mail intake to mail team in helpers * adding unauthorized user check * Fix to correspondence intake spec --------- Co-authored-by: Jim Foley <james.foley4@va.gov>
* Refactor Correspondence Controller - Move intake processing logic to new service. - Clean up some class variables in controller to use method. * Create Tasks Not Related To Appeal * Fix Issues with Creating Unrelated Appeal Tasks * Task Routing: Mail Tasks additions * Test for completed mail tasks & add tasks not related to an appeal * Bug fix and passing failure test. --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> Co-authored-by: Jim Foley <james.foley4@va.gov>
* review package status to in progress * Efloder error banner display * Ability to resume review package specs * Split package other option place holder fix --------- Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
* APPEALS-35703 - Update Task Type Labels * APPEALS-35703 - Correspondence CSS Work * APPEALS-35703 - Update CSS * APPEALS-35703 - Fix Table, Removed unused styling * APPEALS-35703 - Linting * APPEALS-35703 - Lint 2 To Too * Update _correspondence.scss --------- Co-authored-by: Jim Foley <james.foley4@va.gov>
Co-authored-by: Jim Foley <james.foley4@va.gov>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
…ction (#20407) Co-authored-by: Jim Foley <james.foley4@va.gov>
Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* Added create_veteran to helper module and used in multi_correspondences * Added seed_helper module to cavc_ama_appeals * Added seed_helper module to test_case_data * Added seed_helper module to seeds/tasks.rb * Adjust formatting * Added seed_helper module to static test data * Added seed_helper module to static dispatched test data * Added seed_helper module to remanded legacy appeals * Added seed_helper module to remanded ama appeals * Added seed_helper module to cavc dashboard data * Relocate duplicate correspondence intake setup to CorrespondenceHelpers * Relocated duplicate create_child_class methods to shared parent * Moved create_child_class to private section * Move autotext table seeding to CorrespondenceHelpers * Codeclimate fixes and ignores * Update validation syntax on CorrespondenceIntake * Refactor method naming convention inCorrespondenceRelation * Update validation syntax on CorrespondenceRelation * Fixing requires * replaces timeout with sleep to fix offense * scss linting fix * Updated Time.local to Time.zone.local (reran tests) * parameter lint fix. * fixed linter issue. * Several linting fixes * fixed cyclomatic complexity * refactored logging statement * Converted statement to one line for better readability. * fixed element count * fixed incorrect element being clicked * Fix other motion bug --------- Co-authored-by: William Medders <medders_william@bah.com>
* upload static correspondence document * update spec --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* PdfDocument is hard-coded to access only the first N documents available * Add limit so we're not pulling the entire table for testing purposes * Removed loading message from jest test. Updated lint --------- Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
… populating. (#21035) * updates query to prevent efolderuploadfailed tasks * updated query to look better * Fixed task sorting. --------- Co-authored-by: Jim Foley <james.foley4@va.gov>
* Add new correspondence tasks not related to appeal * Fix error when submitting correspondence intake * Add scope tasks_not_related_to_appeal * Change intake processor to create new correspondence tasks * Refactor to have new Correspondence task class names * Refactor to simplify and be less flaky * Refactor with the updated class names * add veteran full name * create abstract base class for tasks not related to an appeal * remove task not related to appeal scope * move correspondence mail tasks to folder * correspondence mail tasks inherit from CorrespondenceMailTask * remove hard coded true return for task creation verification * abstract class and create child class override * replace deleted verification bypass * revert task creation refactor
…fixes (#21047) Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
* adding correspondence intake controller * moving methods that seem to be suited for the intake-specific controller * refactor conditional * updating the routes * Updating the remainder of intake routes * removing a repeated method found * moving intake specs to new intake controller spec * fixing file for failing tests * Fixing failing specs --------- Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: Jim Foley <james.foley4@va.gov>
* creating review package controller, moving methods, editing routing * Moving review package spec tests to new RP Spec file * cleaning up code from intake controller spec
Code Climate has analyzed commit 887ee14 and detected 10 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Code Scanning Policy FindingsYour repository contains unresolved code scanning alerts. Policy requires that all code scanning alerts ofcritical severity be resolved within 30 days.In the future, if your repository contains unresolved code scanning alerts older than 30 days, you will not be able to merge this pull request. Learn more about how to triage and remediate these alerts in the GitHub Code Scanning documentation. If this pull request remediates these alerts, after your pull requests CodeQL scan has completed, follow this link to re-run the policy check and select Re-run all jobs at the top of the page: https://github.com/department-of-veterans-affairs/caseflow/actions/runs/8788511739You may also re-run this required check by simply commenting on this pull request with the following command: /actions-bot rerun-required-workflows
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Jira Issue Title
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling