Caceves/appeals 27311 31542 #21430

* Initial Commit * Running tests * Adding appellant phone number to serializer * Adding paper case attribute * Add attributes to search hash * add KNAPSACK_PRO_FIXED_QUEUE_SPLIT to workflow.yml (#20329) * add KNAPSACK_PRO_FIXED_QUEUE_SPLIT to workflow.yml * update deprecated method for knapsack * add comment --------- Co-authored-by: AimanK <Aiman.Kayad@va.gov> Co-authored-by: raymond-hughes <raymond.hughes2@va.gov> Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>

This reverts commit 084cd98.

* Test spec fixes * lint issue

* Refactor Correspondence Controller - Move intake processing logic to new service. - Clean up some class variables in controller to use method. * Create Tasks Not Related To Appeal * Fix Issues with Creating Unrelated Appeal Tasks * Task Routing: Mail Tasks additions * Fix Create Mail Tasks Bugs - Fix issues preventing mail tasks from being created. - Enhance specs for creating mail tasks and tasks not related to an appeal. - Fix linting errors. * Add Exemptions when Creating Correspondence Tasks * Refactor Task Creating Edge Case Handling - Update the Correspondence class to responde to Appeal methods vs. littering the code with conditionals. * Fix Linting Error * Update correspondence_controller_spec.rb Fix spec failure --------- Co-authored-by: Dev-KRedd <khalin.redding@va.gov>

* Fixed UAT seed data * fix in uat seed data veteran save * Added in missing fields --------- Co-authored-by: Kevin Ma <magavakevin10@gmail.com> Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>

* remove package * Added Correspondence Task Serializer to show type * Added isReadOnly check to tasks on initial fetch * Jest test fix * Removed duplicate method * Remove dropdown for readOnly page * Added feature test * Added extra check for banner * Typo fix * Fixed packageActionModal jest test * Add Banner * spec files * fix rubocop error * fix modal * Fix spec file * Disabled all buttons --------- Co-authored-by: Kevin Ma <magavakevin10@gmail.com> Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com>

* Refactored task ID logic for related tasks. * Updated logic to be cleaner. --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

* Added Correspondence Task Serializer to show type * Added isReadOnly check to tasks on initial fetch * Jest test fix * Removed duplicate method * Remove dropdown for readOnly page * Added feature test * Added extra check for banner * Typo fix * Fixed packageActionModal jest test * Added guard to error handling * Spec fix * Missing comma * Piedram/appeals 36343 (#20350) * remove package * Added Correspondence Task Serializer to show type * Added isReadOnly check to tasks on initial fetch * Jest test fix * Removed duplicate method * Remove dropdown for readOnly page * Added feature test * Added extra check for banner * Typo fix * Fixed packageActionModal jest test * Add Banner * spec files * fix rubocop error * fix modal * Fix spec file * Disabled all buttons --------- Co-authored-by: Kevin Ma <magavakevin10@gmail.com> Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com> --------- Co-authored-by: piedram <110848569+piedram@users.noreply.github.com>

… is disabled (#20335) * Adding under construction page for authorized users * fixing cmp spec * routing more specs to under_construction - rspec job 12,5 * Test run helpers * adding test for unauthorized * Changing from mail intake to mail team in helpers * adding unauthorized user check * Fix to correspondence intake spec --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

* Refactor Correspondence Controller - Move intake processing logic to new service. - Clean up some class variables in controller to use method. * Create Tasks Not Related To Appeal * Fix Issues with Creating Unrelated Appeal Tasks * Task Routing: Mail Tasks additions * Test for completed mail tasks & add tasks not related to an appeal * Bug fix and passing failure test. --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> Co-authored-by: Jim Foley <james.foley4@va.gov>

* review package status to in progress * Efloder error banner display * Ability to resume review package specs * Split package other option place holder fix --------- Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>

* APPEALS-35703 - Update Task Type Labels * APPEALS-35703 - Correspondence CSS Work * APPEALS-35703 - Update CSS * APPEALS-35703 - Fix Table, Removed unused styling * APPEALS-35703 - Linting * APPEALS-35703 - Lint 2 To Too * Update _correspondence.scss --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

Co-authored-by: Jim Foley <james.foley4@va.gov>

Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>

…ction (#20407) Co-authored-by: Jim Foley <james.foley4@va.gov>

Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

This reverts commit 7b1d529.

* Added create_veteran to helper module and used in multi_correspondences * Added seed_helper module to cavc_ama_appeals * Added seed_helper module to test_case_data * Added seed_helper module to seeds/tasks.rb * Adjust formatting * Added seed_helper module to static test data * Added seed_helper module to static dispatched test data * Added seed_helper module to remanded legacy appeals * Added seed_helper module to remanded ama appeals * Added seed_helper module to cavc dashboard data * Relocate duplicate correspondence intake setup to CorrespondenceHelpers * Relocated duplicate create_child_class methods to shared parent * Moved create_child_class to private section * Move autotext table seeding to CorrespondenceHelpers * Codeclimate fixes and ignores * Update validation syntax on CorrespondenceIntake * Refactor method naming convention inCorrespondenceRelation * Update validation syntax on CorrespondenceRelation * Fixing requires * replaces timeout with sleep to fix offense * scss linting fix * Updated Time.local to Time.zone.local (reran tests) * parameter lint fix. * fixed linter issue. * Several linting fixes * fixed cyclomatic complexity * refactored logging statement * Converted statement to one line for better readability. * fixed element count * fixed incorrect element being clicked * Fix other motion bug --------- Co-authored-by: William Medders <medders_william@bah.com>

* upload static correspondence document * update spec --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>

* PdfDocument is hard-coded to access only the first N documents available * Add limit so we're not pulling the entire table for testing purposes * Removed loading message from jest test. Updated lint --------- Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>

Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>

…20440)

* displaying correct reason on the modal * fix error * fix spec file * fix spec * fix error in review_package_spec.rb

* Edit modal VADOR upadeted the error message text * Merge package other option placeholder fix --------- Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>

Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* APPEALS-35703 - Update Task Type Labels * APPEALS-35703 - Correspondence CSS Work * APPEALS-35703 - Update CSS * APPEALS-35703 - Fix Table, Removed unused styling * APPEALS-35703 - Linting * APPEALS-35703 - Lint 2 To Too * Page 3 conditional rending complete * APPEALS-35254 - Updated CSS Issues, Mail Fix, Adds * APPEALS-35254 - Linting * SCSS Linting * APPEALS-35254 - Horizontal rule for AC 4 --------- Co-authored-by: Jim Foley <james.foley4@va.gov> Co-authored-by: Dev-KRedd <khalin.redding@va.gov>

* Use FeatureToggle for non-prod Uploads - When not in production, use a new feature toggle to control the success/failure of the ClaimEvidenceService document upload for correspondences vs. the old, hard-coded boolean that was being used. - Add spec to test upload behavior. * Rearrange Code Put primary case first in if statement for better readability. * Fix Correspondence Bugs and Issues - Move eFolder doc uploading to a new service and update code to use it. - Refactor CorrespondenceIntakeProcessor based on missed requirements so that it correctly uses the result of doc uploads to control flow. - Add specs throughout and fix some Rubocop violations. * Improve Error Reporting Messages * Fix Issues Causing Spec Failures - Restore removed correspondence_document methods. - Add mocks for doc upload to intake form submit specs. * Fix check for veteran ID * Fix correspondence_document_spec * Fix efolder uploader Spec Failures - Update spec based on new check for existing failed task. - Enhance existing specs. --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

* wrap Intake appeal upload behind feature toggle * update static doc path * rubocop fix efolder uploader * refactor intake_update in correspondence controller * Ignore feature envy code climate * Reek ignore warning --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: Kevin Ma <magavakevin10@gmail.com>

* Added create_veteran to helper module and used in multi_correspondences * Added seed_helper module to cavc_ama_appeals * Added seed_helper module to test_case_data * Added seed_helper module to seeds/tasks.rb * Adjust formatting * Added seed_helper module to static test data * Added seed_helper module to static dispatched test data * Added seed_helper module to remanded legacy appeals * Added seed_helper module to remanded ama appeals * Added seed_helper module to cavc dashboard data * Relocate duplicate correspondence intake setup to CorrespondenceHelpers * Relocated duplicate create_child_class methods to shared parent * Moved create_child_class to private section * Move autotext table seeding to CorrespondenceHelpers * Codeclimate fixes and ignores * Update validation syntax on CorrespondenceIntake * Refactor method naming convention inCorrespondenceRelation * Update validation syntax on CorrespondenceRelation * Fixing requires * replaces timeout with sleep to fix offense * scss linting fix * Updated Time.local to Time.zone.local (reran tests) * parameter lint fix. * fixed linter issue. * Several linting fixes * fixed cyclomatic complexity * refactored logging statement * Converted statement to one line for better readability. * fixed element count * fixed incorrect element being clicked * Fix other motion bug * Fix codeclimate issues * Fix codeclimate issues * Fix conditional logic for Ruby style * Update current user creation in CorrespondenceHelpers to avoid fk violation --------- Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com>

* Added create_veteran to helper module and used in multi_correspondences * Added seed_helper module to cavc_ama_appeals * Added seed_helper module to test_case_data * Added seed_helper module to seeds/tasks.rb * Adjust formatting * Added seed_helper module to static test data * Added seed_helper module to static dispatched test data * Added seed_helper module to remanded legacy appeals * Added seed_helper module to remanded ama appeals * Added seed_helper module to cavc dashboard data * Relocate duplicate correspondence intake setup to CorrespondenceHelpers * Relocated duplicate create_child_class methods to shared parent * Moved create_child_class to private section * Move autotext table seeding to CorrespondenceHelpers * Codeclimate fixes and ignores * Update validation syntax on CorrespondenceIntake * Refactor method naming convention inCorrespondenceRelation * Update validation syntax on CorrespondenceRelation * Fixing requires * replaces timeout with sleep to fix offense * scss linting fix * Updated Time.local to Time.zone.local (reran tests) * parameter lint fix. * fixed linter issue. * Several linting fixes * fixed cyclomatic complexity * refactored logging statement * Converted statement to one line for better readability. * fixed element count * fixed incorrect element being clicked * Fix other motion bug * Fix codeclimate issues * Fix codeclimate issues * Fix conditional logic for Ruby style * Update current user creation in CorrespondenceHelpers to avoid fk violation * Ignore reek warning --------- Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com>

Only allow creation of classes listed in allow list.

* Increase wait time to help tests pass in CI * Add using wait time to address flakiness * Added wait time to submit intakeformspec and arialabel to confirm button * silence rubocop methodlength * Update snapshots --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

#20495)

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* presence validation added. * fixed failing tests due to validations * changed data to be less confusing * fixed failing test * added foreign key validation at the db level * Fixed failing tests. * Added additional let! statements to stub data * fixed linting * Fixed failing specs (all of them) by stubbing more correspondence data * Updated correspondence factors to supply all required foreign key objects. * modified correspondence helpers to use only factory. * Fixed failing specs * removed redundant info * updated spec to fix failing validations * Changed seed order to support Correspondence validations * fixed linting issues * Added correspondence_type factory * Modified correspondence factory so that it uses user, veteran, correspondence_type factories. * Added package_document_type factory, changed correspondence factory to use it. * Added association for assigned_by * Updated to use factories for user, removed useless assignments * Removed redundant code * fixed failing spec. * fixed failing spec * added updated_to_id to all correspondences --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* Refactor to avoid passing a zero index value * Add evidence_submission_task to AppealSerializer * Update correspondence.rake --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

* correspondence letter selection file * updating the response widnow options

* creating coreespondence response letters table * Update 20240122174056_create_correspondence_response_letters.rb * resolving code comments * adding schema changes

…fairs/caseflow into feature/APPEALS-27311

* Initial commit for correspondence migration * Commit for seed data updations with the AC * Commit for generating few othere tasks * Commit for the changes mentioned for task file and reverting the changes in task file * Reverted the changes as per the comments and updated with new seed files * Fixing few more issues while generating the reviewpackage task * Changing the correspondence_type_id with Table value --------- Co-authored-by: Matt Roth <roth_matthew@bah.com>

* WIP correspondence config * Update correspondence_config to use correspondence related classes * Temporarily default column filtering to false * Override methods to work with correspondence tasks * allow correspondence tasks * add correspondence queue tabs for org * update column names * update column names * add correspondence org queue tabs * add task column serializer for correspondence queue * add helper to be able to call correspondence on correspondence tasks instead of appeal * revert controller changes * create fixtures for individual and team correspondence config * update task tab attributes * Revert changes to CorrespondenceCases.jsx * Revert changes to QueueTableBuilder.jsx * remove fixtures * Test: correspondence_config * add column names to JSON file * update columns * Added testing for correspondence_config * Add test for correspondence_team json response * remove temporary helper methods * Add fetch to /queue/correspondence/team * Added strings for tasks tabs to constants file * Moved strings into constants file

…20585) * APPEALS-35714 - Initial WIP Commit * APPEALS-35714 - Clear comments, update controller * Update correspondence_controller.rb Updated naming for correspondence_config; Temporary notes * Update constants.js Title * APPEALS-35714 - Tasks 2 Config * Update CorrespondenceCases.jsx * APPEALS-35714 - Title Update * added dynamic routing to correspondence cases * checkpoint * Undid unintended push. * APPEALS-35714 - Route fixes; temporary user fix WIP * Add BvaIntake User * Remove comments * Access Update * Title Update --------- Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com>

* corrspondence response letter changes * specs and refactoring * rubocop fix * Update migration and rubocop fixes --------- Co-authored-by: Christopher Aceves <christopher.aceves@va.gov>

* Refactor code for class to functional componets * Removed some commented lines * Changes to call the ApiUtil outside of the function and calling it in CorrespondenceActions

* WIP Branch * AC 1.1, 1.2,2.1, 2.2 done * Linting errors * Corrected Comments * Feature test correction

* Updated gem file reference to ruby ce api * Updated gemfile lock

* APPEALS-35714 - Initial WIP Commit * WIP correspondence config * Initial commit for correspondence migration * APPEALS-35714 - Clear comments, update controller * Commit for seed data updations with the AC * Update correspondence_config to use correspondence related classes * Temporarily default column filtering to false * Override methods to work with correspondence tasks * allow correspondence tasks * add correspondence queue tabs for org * update column names * update column names * add correspondence org queue tabs * add task column serializer for correspondence queue * add helper to be able to call correspondence on correspondence tasks instead of appeal * revert controller changes * Update correspondence_controller.rb Updated naming for correspondence_config; Temporary notes * Update constants.js Title * APPEALS-35714 - Tasks 2 Config * Update CorrespondenceCases.jsx * APPEALS-35714 - Title Update * added dynamic routing to correspondence cases * Commit for generating few othere tasks * create fixtures for individual and team correspondence config * update task tab attributes * Revert changes to CorrespondenceCases.jsx * Revert changes to QueueTableBuilder.jsx * remove fixtures * Test: correspondence_config * Commit for the changes mentioned for task file and reverting the changes in task file * add column names to JSON file * connect to config * Update columns * Experimental changes * fix pagination for individual correspondence queue table * fix pagination for organization correspondence queue table * Fix extra end * fix indentation * RuboCop Fixes * Merge Issues * minor changes to get the component rendering * Fixed redux issue * Removed duplicates * Fixed rubocop warning in a correct way. * Removed React.Fragments and replaced with <> --------- Co-authored-by: KiMauVA <Ki.Mau@va.gov> Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: divyadasari-va <divya.dasari@va.gov>

* Update gem ref * Updated reference * Update gem ref (#20725) * Updated gem reference

* APPEALS-29410 Response letter section * create componenet to add letter * fix button * enabled and disabled continue buttom * custom part * selector element * move state variable * slector value * error in selector * Selectors * Selectors 2 * change selector * change selector * remove part * Response windows * Response windows again * updation radio * clean values * Fix option for custom radio * fix reason value * Fix option in the radio buttom * Fix rubocop error * Add spec file * Add spec file * Remove comments for the code * modified options in the response wimdows and refactor de code * remove import in AddCorrespondenceView * fix custom field * fix response windows * refactor * continue funcionality * contiue button --------- Co-authored-by: Kamala Madamanchi <kamala.madamanchi@va.gov> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* adding correspondence task default route * adding intake and review package route overrides * adding efolder ulpoad failed logic for routing * adding efolder failed upload task depending on parent task * fixing intake scoping * adding task_url attribute to column serializer * attempting a correspondence root task addition * Moved constant file for access * removing root task method, since all defaults to /under_construction * replacing task urls from a newly created constants file * code cleanup * adding tests * rubocop and linting errors * rubocop fixes * Serialize attributes regardless of values --------- Co-authored-by: William Medders <medders_william@bah.com>

Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* APPEALS-29410 Response letter section * create componenet to add letter * fix button * enabled and disabled continue buttom * custom part * selector element * move state variable * slector value * error in selector * Selectors * Selectors 2 * change selector * change selector * remove part * Response windows * Response windows again * updation radio * clean values * Fix option for custom radio * fix reason value * Fix option in the radio buttom * Fix rubocop error * Add spec file * Add spec file * Remove comments for the code * modified options in the response wimdows and refactor de code * remove import in AddCorrespondenceView * confirmation of response letters * fix custom field * adding dispatch * fix response windows * refactor * continue funcionality * contiue button * adding response letter section * fixing lint * fixing table * lint fixes * refactoring * appending days to custom value * fixing lint errors * fixing lint * fixing lint --------- Co-authored-by: Kamala Madamanchi <kamala.madamanchi@va.gov> Co-authored-by: piedram <maite.piedrayera@va.gov>

Co-authored-by: Kevin Ma <magavakevin10@gmail.com>

* APPEALS-29410 Response letter section * create componenet to add letter * fix button * enabled and disabled continue buttom * custom part * corrspondence response letter changes * specs and refactoring * selector element * move state variable * slector value * error in selector * Selectors * Selectors 2 * change selector * change selector * remove part * Response windows * Response windows again * updation radio * clean values * Fix option for custom radio * rubocop fix * fix reason value * Fix option in the radio buttom * Fix rubocop error * Update migration and rubocop fixes * Add spec file * Add spec file * Remove comments for the code * modified options in the response wimdows and refactor de code * remove import in AddCorrespondenceView * confirmation of response letters * fix custom field * adding dispatch * fix response windows * refactor * continue funcionality * contiue button * adding response letter section * fixing lint * fixing table * lint fixes * Add continue botton * Save data in DB * change style * Save values * fix continue buttom * dix submit button --------- Co-authored-by: Kamala Madamanchi <kamala.madamanchi@va.gov> Co-authored-by: piedram <maite.piedrayera@va.gov> Co-authored-by: vinner57 <128258952+vinner57@users.noreply.github.com>

* adding correspondence task default route * adding intake and review package route overrides * adding efolder ulpoad failed logic for routing * adding efolder failed upload task depending on parent task * fixing intake scoping * adding task_url attribute to column serializer * attempting a correspondence root task addition * Moved constant file for access * removing root task method, since all defaults to /under_construction * replacing task urls from a newly created constants file * code cleanup * adding tests * rubocop and linting errors * rubocop fixes * Serialize attributes regardless of values * Make CorrespondenceTask an abstract class * Make package action tasks inherit from CorrespondenceTask * Update to not intatiate abstract CorrespondenceTasks * Refactor queue correspondences seeds * Fix broken pagination on Correspondence Cases team page * Merge with feature 32900 * Randomize va date of receipt * Remove expectation to find instance of CorrespondenceTask - an abstract class * Remove expectation for abstract class to appear in task tree * Assign ReviewPackageTask before creating EfolderUploadFailedTask * Rubocop fixes --------- Co-authored-by: sulak-j <justin.sulak@va.gov> Co-authored-by: Christopher Aceves <christopher.aceves@va.gov>

* adding correspondence task default route * adding intake and review package route overrides * adding efolder ulpoad failed logic for routing * adding efolder failed upload task depending on parent task * fixing intake scoping * adding task_url attribute to column serializer * attempting a correspondence root task addition * Moved constant file for access * removing root task method, since all defaults to /under_construction * replacing task urls from a newly created constants file * code cleanup * adding tests * rubocop and linting errors * rubocop fixes * Serialize attributes regardless of values * Make CorrespondenceTask an abstract class * Make package action tasks inherit from CorrespondenceTask * Update to not intatiate abstract CorrespondenceTasks * Refactor queue correspondences seeds * Fix broken pagination on Correspondence Cases team page * Merge with feature 32900 * Randomize va date of receipt * Remove expectation to find instance of CorrespondenceTask - an abstract class * Remove expectation for abstract class to appear in task tree * Merge in task url work * Add ability to link veterans details to tasks or modals * Route to under construction if closed * Assign ReviewPackageTask before creating EfolderUploadFailedTask * give ids and labels to column items * Add CorrespondenceTaskHelpers module * Test: correspondene queue task links spec * Move url strings into constants file * Fix extra space --------- Co-authored-by: sulak-j <justin.sulak@va.gov>

* APPEALS-39894 - Fixes for Linting and Props * Spec Updates --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* change continue buttom * Continue button * add space for taskupdatecallback --------- Co-authored-by: Kamala Madamanchi <kamala.madamanchi@va.gov> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* Test: verifies no other open package action task on correspondence before creation * Rubocop style fixes * Update expectation to match new requirements * add more wait time to address flakiness in CI * fix issue where EfolderFailedUploadTasks had parent task belonging to wrong Correspondence * fix issue where correspondence queue breaks after completing intake form * fix wrong url for reassign package task * Fix test: when remove package task is pending review * use_history not needed * Revert "Fix test: when remove package task is pending review" This reverts commit f2dd043.

…m field (#20893) * align letter * fix size of selector --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* cherrypicked files * second cherrypick * more cherry picking. * Reformatted code to be more OOP friendly and less verbose. * big fix in logic * added appeal_type, fixing many errors. * added appeal type to factory * improved filter, and fixed some unit tests. * fixed efolder uploader spec * fixed task_spec * potential fix * unit test fix * fixed Correspondence Intake Task * fixed linting issues. * removed comments and binding pry --------- Co-authored-by: Jim Foley <james.foley4@va.gov> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* basic edit letters canges * edit section * refactoring and lint fixes * resolving conflicts * bug fix for date and custom value * fixing remove letter bug * fixing lint * fies for lint error * lint fix * adding response letters

* update seed file to create package action tasks with assigned_by value * Update tasks call for action required tab * Update columns in QUEUE_COLUMN constants file * Add sorting to columns * refactor query to use scope * always use task pages api for this workflow * ensure assigned by is a user * merge with ryan/APPEALS-35479-check * add cancel link to package action modals * add tests for action required tab * remove pry * refactor tasks method * refactor correspondence task filter * include appeal_type when creating * refactor test setup * remove duplicate tests * add current user * add appeal type * refactor to remove magic string * Add required fields for correspondence_intake_task creation * Add modal titles to constants file * remove pry * update test for new tab requirements * update jest snapshot

@appeals

* correspondence_queue_colomn.rb shell * Removing binding.pry * Reverted some changes on queue column * Updated correspondence_queue_colomn.rb shell * temporary seed data waiting for clarification * Initial commit for Veteran Detail sorting * resolved merge conflicts * CorrespondenceTask is now abstract * Correspondence Root Task no longer creates (it's abstract) * jolly postman seed data update * fixed error on corr queue column. * Sorting feature for Veteran details * sorting on Notes * Task filter setup * added filter option to VA DOR column * added isReceiptFilter to TableFilter props. * Added isReceiptFilter props to TableFilter. * Added empty recieptdaterPicker component * fixed spelling mistakes. * Fixed the bug when changing to mailteamSupervisor user * Days waiting sorting functionality * Front end reciepdate picker now has basic functionality. Backend query sent. * Displaying tasks queues according to the Correspondence Cases and Your Correspondence Case * rubocop fixes * rubocop fixes * Commit for rubocop fix * checkpoint * Fixed team page pager issue * fixed list items showing for vaDor filter * Missing features from merge request * Updated changes to frontend. * Completed functionality for everything but between date filters. * Filter options for VA DOR * Updated ReceiptDatePicker to be standalone * updated filter to be a little more clear * add seed file to populate judges and attorneys from VACOLS * Revert "Revert "Feature/appeals 26736"" * hotfix/APPEALS-39368: fix bug where nil ends up in @appeals array (#20668) * fix bug where nil ends up in @appeals array * add ama_statistics error handling * clarify error message when rescuing in ama_statistics * fix priority push job * fix tests * added nonpriority iterations to until clause in requested_distribution * add tests for limiting nonpriority iterations * change iterations limit to batch_size * fix test * Ki/APPEALS-39894 - Update Test & Linting Errors (#20776) * APPEALS-39894 - Fixes for Linting and Props * Spec Updates --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * Commit for frontend changes for Date Completed column * debug and linting fix * Re-enabled filtering by veteran details. * Cleaned up code and fixed a bug in the filtering. * Added proptypes, removed unused variables. * Frontend datePicker changes for DateCompleted * Fixed receipt spelling. * fixed rubocop issues * Frontend datepicker changes * DateCompleted filtering updated with required options * reorganized the code so that styles don't get overwritten. * changed name column to be more consistent with wireframes. * Lint fixes * fixed linting issues and made UI match wireframes. * add seed file to populate judges and attorneys from VACOLS * Revert "Revert "Feature/appeals 26736"" * hotfix/APPEALS-39368: fix bug where nil ends up in @appeals array (#20668) * fix bug where nil ends up in @appeals array * add ama_statistics error handling * clarify error message when rescuing in ama_statistics * fix priority push job * fix tests * added nonpriority iterations to until clause in requested_distribution * add tests for limiting nonpriority iterations * change iterations limit to batch_size * fix test * Wmedders21/appeals 39237 (#20834) * Test: verifies no other open package action task on correspondence before creation * Rubocop style fixes * Update expectation to match new requirements * add more wait time to address flakiness in CI * fix issue where EfolderFailedUploadTasks had parent task belonging to wrong Correspondence * fix issue where correspondence queue breaks after completing intake form * fix wrong url for reassign package task * Fix test: when remove package task is pending review * use_history not needed * Revert "Fix test: when remove package task is pending review" This reverts commit f2dd043. * Removed to_json and renamed method (#20839) * Reimplemented disabling of receiptdate filter. * fixed clear filters, made clicking the reset button more consistent in the UI. * filtering enabled and disabled feature * Lint issues * Lint fixes * updated notes to be a little more varied. * added support for correctly filtering veteran info & notes. * fixed VA DOR sorting. * fixed sorting for receipt date filter * Date filter dropdown issue fixed * Commit for lint fix and feature test cases * Removed commented lines * lint issues * PG::NotNullViolation issue fix * Jest errors snapshots updated * Modified the changes as requested * Rubocop fixes * Improvement for filter logic * Spec failing fixes * Some other rspec fail fix * Spec fixes * Spec fixes after merge * Modified completed tasks to aviod eager loading message in the logs --------- Co-authored-by: Dev-KRedd <khalin.redding@va.gov> Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com> Co-authored-by: IsaiahBar <isaiah.barnett@va.gov> Co-authored-by: Craig Reese <Reese_Craig@bah.com> Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> Co-authored-by: Ki Mau <ki.mau@va.gov> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> Co-authored-by: Will Medders <93014155+wmedders21@users.noreply.github.com> Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com>

* merge into feature * refactoring the code * Fix style issue * Add space in _table.css file

* basic edit letters canges * edit section * refactoring and lint fixes * resolving conflicts * bug fix for date and custom value * fixing remove letter bug * fixing lint * fies for lint error * lint fix * adding response letters * fix for continue button after Edit section and space issue --------- Co-authored-by: vinner57 <128258952+vinner57@users.noreply.github.com> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* update seed file to create package action tasks with assigned_by value * Update tasks call for action required tab * Update columns in QUEUE_COLUMN constants file * Add sorting to columns * refactor query to use scope * always use task pages api for this workflow * ensure assigned by is a user * merge with ryan/APPEALS-35479-check * add cancel link to package action modals * add tests for action required tab * remove pry * refactor tasks method * refactor correspondence task filter * include appeal_type when creating * APPEALS-35482 - CSS Fix * APPEALS-35482 - Linting and RSpecs * APPEALS-35482 - Rspecs, Filtering, Snapshots * Update QueueDropdownFilter.jsx --------- Co-authored-by: William Medders <medders_william@bah.com>

* update seed file to create package action tasks with assigned_by value * Update tasks call for action required tab * Update columns in QUEUE_COLUMN constants file * Add sorting to columns * refactor query to use scope * always use task pages api for this workflow * ensure assigned by is a user * merge with ryan/APPEALS-35479-check * add cancel link to package action modals * add tests for action required tab * remove pry * refactor tasks method * refactor correspondence task filter * include appeal_type when creating * APPEALS-35482 - CSS Fix * APPEALS-35482 - Linting and RSpecs * APPEALS-35482 - Rspecs, Filtering, Snapshots * Update QueueDropdownFilter.jsx * updated task for Assigned tab --------- Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: KiMauVA <Ki.Mau@va.gov> Co-authored-by: Jim Foley <james.foley4@va.gov>

…es (#20920) Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* Change correspondence_task to abstract class * Refactor correspondence root task to not have a parent task * do not expect abstract correspondence_task to appear in task tree * Update test to not look for a now abstract class instance -CorrespondenceTask * Fix for appeals not loading on step 2 of intake form * add evidence submission window attribute to re-serializer * Remove package document type column to fix flaky test * Refresh to fix flaky test

…20960) * Package action task refactor for create verification and inheritance * fix typo

* randomize closed at for correspondence root task seeds * update seeds to have varying values to be able to test sorting columns

* update seed file to create package action tasks with assigned_by value * Update tasks call for action required tab * Update columns in QUEUE_COLUMN constants file * Add sorting to columns * refactor query to use scope * always use task pages api for this workflow * ensure assigned by is a user * merge with ryan/APPEALS-35479-check * add cancel link to package action modals * add tests for action required tab * remove pry * refactor tasks method * refactor correspondence task filter * include appeal_type when creating * APPEALS-35482 - CSS Fix * APPEALS-35482 - Linting and RSpecs * APPEALS-35482 - Rspecs, Filtering, Snapshots * Update QueueDropdownFilter.jsx * updated task for Assigned tab * fix test * modified expect * fix tasks filter * test for tasks filter * fixed tasks * updating Tasks filter * update query for tasks --------- Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: KiMauVA <Ki.Mau@va.gov> Co-authored-by: Jim Foley <james.foley4@va.gov> Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* APPEALS-35482 - Conditional assign button for mail team super * APPEALS-35482 - QueueTable pagination update * APPEALS-35482 - Undo currentPage Issue * Delete client/test/app/queue/__snapshots__/QueueTable.test.js.snap * Update snapshot

* Rubocop stying errors fixed * Duplication Issues * Duplication issues * Duplication fix * Complexity Reek Errors WIP * De-couple CorrespondenceConfig from QueueConfig Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com> * Replace conditional with Polymorphism * Reek Attribute comment * Removal of dead code * frozen_string_literal addition * Removal of dead code & addition of DataClump comment * Styling fixes * styling * Adding process_correspondence method back * Revert "Replace conditional with Polymorphism" This reverts commit 4fa20e9. * Revert "De-couple CorrespondenceConfig from QueueConfig" This reverts commit 7b8e450. * Revert "Removal of dead code" This reverts commit b9ac6fc. * Revert "Removal of dead code & addition of DataClump comment" This reverts commit bb7ffe8. * Adding back from merge conflict * Wmedders21/appeals 40978 on my local(Will revert before PR) * Fixing tests * Syling Fixes * Rubocop Styling fixes * Complexity fixes * Duplication fix * Styling fix * Styling fix --------- Co-authored-by: Jim Foley <james.foley4@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

…21003)

* To get mail team users in the dropdown * made mail team users populate as a prop. * Added checkboxes that are functional, retain state after tab / index changes. * Backend update for mailteam users with selected tasks * Updated the flash message with the required banner status * Updated the flash message with the required banner status * Status update with assigned * prototype page reload * Banner success message * Syntax error fix * added tasks filter test for mail team admin * Banner message work updated * Commit for Assign button disable and enable * Modified dropdown fix for Assign button * code cleanup checkpoint * refactored correspondence_controller to handle different banner results * Feature test spec for batch assignment for unassigned tab * feature test cases for cob user * fixed COB issue and added feature flag. * added failure case for tasks * Removed the banner stuff for Nod * fixed logic on set_banner_params * swapped banner type to info * Clean up the code and lint issues * Changes to Reassigned work * Feature tests for Assigned tab for batch assignment * Spec issues fixes * Modified the suggested changes --------- Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com>

* merge issue on activrecord * Fixed tasks filter with multiple options * refactored to be cleaner * refactored CorrespondenceTaskFilter to be OOP best practices and added clarification comments. * Made suggested changes and fixed efolder upload failed task link on the backend. --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

* fix feature test * Revert "fix feature test" This reverts commit 948d637. * pushing up tests for ryan to run * feature tests --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

… populating. (#21035) * updates query to prevent efolderuploadfailed tasks * updated query to look better * Fixed task sorting. --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

* Add new correspondence tasks not related to appeal * Fix error when submitting correspondence intake * Add scope tasks_not_related_to_appeal * Change intake processor to create new correspondence tasks * Refactor to have new Correspondence task class names * Refactor to simplify and be less flaky * Refactor with the updated class names * add veteran full name * create abstract base class for tasks not related to an appeal * remove task not related to appeal scope * move correspondence mail tasks to folder * correspondence mail tasks inherit from CorrespondenceMailTask * remove hard coded true return for task creation verification * abstract class and create child class override * replace deleted verification bypass * revert task creation refactor

This reverts commit 66172ae, reversing changes made to 2726e64.

…fixes (#21047) Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* adding correspondence intake controller * moving methods that seem to be suited for the intake-specific controller * refactor conditional * updating the routes * Updating the remainder of intake routes * removing a repeated method found * moving intake specs to new intake controller spec * fixing file for failing tests * Fixing failing specs --------- Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: Jim Foley <james.foley4@va.gov>

* creating review package controller, moving methods, editing routing * Moving review package spec tests to new RP Spec file * cleaning up code from intake controller spec

Commits on Jan 25, 2024

update document_types (#20626 )

SanthiParakal133 authored Jan 25, 2024

Configuration menu

View commit details

Copy full SHA for 6f9d190

Browse repository at this point

Copy the full SHA

6f9d190 View commit details

Browse the repository at this point in the history

Caceves/appeals 27311 31542 #21430

Caceves/appeals 27311 31542 #21430

Commits on Dec 26, 2023

Commits on Dec 27, 2023

Commits on Dec 28, 2023

Commits on Dec 29, 2023

Commits on Dec 30, 2023

Commits on Jan 2, 2024

Commits on Jan 3, 2024

Commits on Jan 4, 2024

Commits on Jan 5, 2024

Commits on Jan 8, 2024

Commits on Jan 9, 2024

Commits on Jan 10, 2024

Commits on Jan 11, 2024

Commits on Jan 12, 2024

Commits on Jan 17, 2024

Commits on Jan 19, 2024

Commits on Jan 22, 2024

Commits on Jan 24, 2024

Commits on Jan 25, 2024

Commits on Jan 26, 2024

Commits on Jan 30, 2024

Commits on Jan 31, 2024

Commits on Feb 1, 2024

Commits on Feb 2, 2024

Commits on Feb 6, 2024

Commits on Feb 7, 2024

Commits on Feb 8, 2024

Commits on Feb 9, 2024

Commits on Feb 12, 2024

Commits on Feb 13, 2024

Commits on Feb 14, 2024

Commits on Feb 15, 2024

Commits on Feb 20, 2024

Commits on Feb 21, 2024

Commits on Feb 22, 2024

Commits on Feb 23, 2024

Commits on Feb 27, 2024

Commits on Feb 28, 2024

Commits on Mar 4, 2024

Commits on Mar 5, 2024

Commits on Mar 6, 2024

Commits on Mar 7, 2024

Commits on Mar 8, 2024

Commits on Mar 12, 2024

Commits on Mar 14, 2024

Commits on Mar 15, 2024

Commits on Mar 20, 2024

Commits on Mar 22, 2024

Commits on Mar 25, 2024

Commits on Mar 26, 2024

Commits on Apr 1, 2024

Commits on Apr 5, 2024

Commits on Apr 11, 2024

Commits on Apr 22, 2024