#vebt-470 #removing 22-1990n entry in registry.json #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div
* update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
* added feedback button to checklist drupal template * moved element to under back-to-top element
* creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
* Update SCO registry.json route * Update registry.json for sco url * Making separate PR * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com>
GovCIOLiz
approved these changes
Sep 9, 2024
Merged
14 tasks
14 tasks
davidmpickett
added a commit
that referenced
this pull request
Sep 17, 2024
* VACMS 17954 - remove italics from common conditions (#2238) * VACMS 17954 - remove italics * move to p instead of div * VACMS 16362: Make only published Vet Center Services display (#2243) * filterBy status:true services * fix accordion labeling ids * remove debugging * Adding arrow_circle_right to sprite sheet (#2244) * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * VEBT-423 Update SCO registry.json route to match prod (#2245) * Update SCO registry.json route * Update registry.json for sco url * Making separate PR * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> * bump web-components (#2258) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * VEBT-424 React SCO page to prod (#2253) * Update SCO registry.json route * vagovprod to true for sco page * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * VEBT-423 Update SCO registry.json route to match prod (#2245) * Update SCO registry.json route * Update registry.json for sco url * Making separate PR * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> * direct links to hashreference of taxonomy name in facility (#2262) * VACMS 18711 - vet center banner image (#2251) * VC Banner image * Add entry for Benefit Eligibility Questionnaire (#2170) * update FMP name (#2257) Co-authored-by: Rachel <rachele.eiting@copilot.llc> * VACMS-18876 Fix breadcrumbs on checklist pages (#2266) * VEBT-468 remove 1990E from registry.json (#2260) * VEBT-468 Remove 1990e from production. * VEBT-468 remove 1990E from registry.json * Add navigation svg icons to site/img directory (#2237) * adds svgs for nav icons * correct svg icon * remove custom event (#2263) * [ARF-87799] Remove 21a (#2269) [Corresponding `vets-website` PR](department-of-veterans-affairs/vets-website#31352) * #vebt-469 remove 1990s from registry.json (#2261) Co-authored-by: Chad Chotikasatien <chad.chotikasatien@va.gov.com> * add sign-in-changes app to registry (#2271) * Updating web-components version to latest (#2272) * wrapping (#2268) * #vebt-470 #removing 22-1990n entry in registry.json (#2264) * Update SCO registry.json route * vagovprod to true for sco page * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * VEBT-423 Update SCO registry.json route to match prod (#2245) * Update SCO registry.json route * Update registry.json for sco url * Making separate PR * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * bump version Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> * #vebt-470 #removing 22-1990n entry in registry.json --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: GovCIOLiz <ewendlinggovcio@gmail.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> Co-authored-by: GovCIOLiz <elizabeth.wendling@va.gov> Co-authored-by: Chad Chotikasatien <chad.chotikasatien@va.gov.com> * VACMS-18855 Add Find Forms download modal back to form detail page (#2239) * VACMS-18855 Add Find Forms download modal back to form detail page * adding ID to container * Add feature flag * finishing up feature flag --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Eli Selkin <eli.selkin@agile6.com> Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us> Co-authored-by: Kevin Duensing <kjduensing@gmail.com> Co-authored-by: Micah Chiang <micahkchiang@gmail.com> Co-authored-by: Aubrey Arcangel <aubreyarcangel@users.noreply.github.com> Co-authored-by: GovCIOLiz <elizabeth.wendling@va.gov> Co-authored-by: Aaron Kriegler <159946297+vetskrieg@users.noreply.github.com> Co-authored-by: Rachel Eiting <reiting1@gmail.com> Co-authored-by: Rachel <rachele.eiting@copilot.llc> Co-authored-by: Randi Mays <randimays1024@gmail.com> Co-authored-by: Napoleon K. <95312667+GcioNapoleon@users.noreply.github.com> Co-authored-by: Ray Messina <48040208+rmessina1010@users.noreply.github.com> Co-authored-by: Oren Mittman <nihil2501@gmail.com> Co-authored-by: govcioChad <162637891+govcioChad@users.noreply.github.com> Co-authored-by: Chad Chotikasatien <chad.chotikasatien@va.gov.com> Co-authored-by: Alexander Garcia <67602137+asg5704@users.noreply.github.com> Co-authored-by: GovCIOLiz <ewendlinggovcio@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
- (Summarize the changes that have been made to the platform)
Related issue(s)
Jira -> https://jira.devops.va.gov/browse/VEBT-470
As a...
VEBT developer
I want...
all references to the GovCIO version of 22-1990n from the va.gov code base
So that...
we can get rid of some tech debt
Acceptance Criteria:
GovCIO EDU form 22-1990n no longer exists in the code base
Remove everywhere
Testing done
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?