Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bin/console calls in shopware recipe #3512

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

dahormez
Copy link
Contributor

  • [ x ] Bug fix: Shopware bin/console calls with default bin/php and not with {{bin/php}}
    I was running the recipe with {{bin/php}} = /opt/local/bin/php8.2 but my default cli version is php7.4 the deployment stopped caused of the wrong php version by calling bin/console directly.

@antonmedv antonmedv merged commit aeec635 into deployphp:master Feb 24, 2023
@Schrank
Copy link
Contributor

Schrank commented Feb 26, 2023

Awesome, thanks @dahormez! <3

midweste pushed a commit to midweste/deployer that referenced this pull request Mar 7, 2023
* origin/master: (23 commits)
  Magento 2: Only set maintenance mode once if needed (deployphp#3469)
  Adds Comments to magento2 recipe and modifies DocGen, to be able to explain artifact deployment (deployphp#3510)
  Added missing deploy task to recipe/common (deployphp#3526)
  Added support for ntfy.sh notifications, contrib/ntfy (deployphp#3522)
  Teams, Telegram, Slack contrib recipe no longer fails silently if no webhook is configured (deployphp#3523)
  [automatic] Update docs with bin/docgen
  Contrib supervisord monitor (deployphp#3486)
  Doc update about new default value of writable_recursive (deployphp#3521)
  Added a note about missing ssh-option. Fixes issue deployphp/deployer… (deployphp#3520)
  Fix branch deploy for clone strategy
  Shopware Flex has no `build.sh` anymore (deployphp#3513)
  Fixed bin/console calls in shopware recipe (deployphp#3512)
  fix typo in magento recipe (deployphp#3498)
  Add PUT to Httpie.php (deployphp#3497)
  Add remote option to update_code_strategy to rename remote to repository (deployphp#3466)
  Prevent type errors when supplied timeout options are not numeric (deployphp#3484)
  Magento: allow subdirectory and create variable for bin/magento (deployphp#3460)
  docs(github-action): improve & update (deployphp#3482)
  docs(selector): correct env config option to array (deployphp#3481)
  Fixes deployphp#3472 (deployphp#3473)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants