Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for ntfy.sh notifications, contrib/ntfy #3522

Merged
merged 3 commits into from
Mar 2, 2023

Conversation

HereticPilgrim
Copy link
Contributor

  • Bug fix #…?

  • New feature: added support for ntfy.sh notifications

  • BC breaks?

  • Tests added? --> No. If you can give me some pointers on how to do it, I will gladly add them.

  • Docs added?

    Please, regenerate docs by running next command:
    $ php bin/docgen
    

@HereticPilgrim
Copy link
Contributor Author

All other contrib recipes use {{target}} for the default notification.
This results in notifications like:
_HereticPilgrim_ deploying `main` to *main*

I used {{hostname}} as it's more intuitive for me, resulting in:
_HereticPilgrim_ deploying `main` to *example.com*

If you want, I can standardize on {{target}}

@antonmedv antonmedv merged commit 4a4e69a into deployphp:master Mar 2, 2023
@antonmedv
Copy link
Member

Lets fix info messages)

@HereticPilgrim
Copy link
Contributor Author

Can you elaborate on what you mean by "fix"?
Would you prefer {{hostname}} in the other contrib-recipes or should I change my version to include {{target}}?

@antonmedv
Copy link
Member

Can you show an example of what do you think?

midweste pushed a commit to midweste/deployer that referenced this pull request Mar 7, 2023
* origin/master: (23 commits)
  Magento 2: Only set maintenance mode once if needed (deployphp#3469)
  Adds Comments to magento2 recipe and modifies DocGen, to be able to explain artifact deployment (deployphp#3510)
  Added missing deploy task to recipe/common (deployphp#3526)
  Added support for ntfy.sh notifications, contrib/ntfy (deployphp#3522)
  Teams, Telegram, Slack contrib recipe no longer fails silently if no webhook is configured (deployphp#3523)
  [automatic] Update docs with bin/docgen
  Contrib supervisord monitor (deployphp#3486)
  Doc update about new default value of writable_recursive (deployphp#3521)
  Added a note about missing ssh-option. Fixes issue deployphp/deployer… (deployphp#3520)
  Fix branch deploy for clone strategy
  Shopware Flex has no `build.sh` anymore (deployphp#3513)
  Fixed bin/console calls in shopware recipe (deployphp#3512)
  fix typo in magento recipe (deployphp#3498)
  Add PUT to Httpie.php (deployphp#3497)
  Add remote option to update_code_strategy to rename remote to repository (deployphp#3466)
  Prevent type errors when supplied timeout options are not numeric (deployphp#3484)
  Magento: allow subdirectory and create variable for bin/magento (deployphp#3460)
  docs(github-action): improve & update (deployphp#3482)
  docs(selector): correct env config option to array (deployphp#3481)
  Fixes deployphp#3472 (deployphp#3473)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants