Shopware Flex has no build.sh anymore
#3513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new [Shopware template](https://developer.shopware.com/docs/guides/installation/template) does not have a `bin/build.sh` file anymore. The missing executable executed `composer install` and `bin/build-js.sh`. Since requiring the new Symfony flex recipe requires running `composer` manually, we just execute `bin/build-js.sh` now. This could be a breaking change for some users. Don't know if you want to state that somewhere or allow a way to restore the old behavior via flag (although one can just override the `sw-build-without-db:build` task anytime).
midweste
pushed a commit
to midweste/deployer
that referenced
this pull request
Mar 7, 2023
* origin/master: (23 commits) Magento 2: Only set maintenance mode once if needed (deployphp#3469) Adds Comments to magento2 recipe and modifies DocGen, to be able to explain artifact deployment (deployphp#3510) Added missing deploy task to recipe/common (deployphp#3526) Added support for ntfy.sh notifications, contrib/ntfy (deployphp#3522) Teams, Telegram, Slack contrib recipe no longer fails silently if no webhook is configured (deployphp#3523) [automatic] Update docs with bin/docgen Contrib supervisord monitor (deployphp#3486) Doc update about new default value of writable_recursive (deployphp#3521) Added a note about missing ssh-option. Fixes issue deployphp/deployer… (deployphp#3520) Fix branch deploy for clone strategy Shopware Flex has no `build.sh` anymore (deployphp#3513) Fixed bin/console calls in shopware recipe (deployphp#3512) fix typo in magento recipe (deployphp#3498) Add PUT to Httpie.php (deployphp#3497) Add remote option to update_code_strategy to rename remote to repository (deployphp#3466) Prevent type errors when supplied timeout options are not numeric (deployphp#3484) Magento: allow subdirectory and create variable for bin/magento (deployphp#3460) docs(github-action): improve & update (deployphp#3482) docs(selector): correct env config option to array (deployphp#3481) Fixes deployphp#3472 (deployphp#3473) ...
|
@UlrichThomasGabor our deployment fails due to the task could this have something to do with this PR? |
|
@gutschik No, this has nothing to do with this PR. Feel free to hire me, if you need assistance with your setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Shopware template does not have a
bin/build.shfile anymore. The missing executable executedcomposer installandbin/build-js.sh. Since requiring the new Symfony flex recipe requires runningcomposermanually, we just executebin/build-js.shnow.This could be a breaking change for some users. Don't know if you want to state that somewhere or allow a way to restore the old behavior via flag? (Although one can just override the
sw-build-without-db:buildtask anytime)Bug fix #…?
New feature?
BC breaks?
Tests added?
Docs added?