Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1065: Add SHA-256 checksum generator to url-updater #1093

Merged
merged 7 commits into from
Apr 14, 2023

Conversation

alfeilex
Copy link
Member

@alfeilex alfeilex commented Apr 3, 2023

This PR adds a checksum generator that calculates the checksum of the download files covered by download urls of each tool and its OS. The hash algorithm used is SHA256.

Example:
Windows_x64.urls will have a Windows_x64.urls.sha256

@github-actions github-actions bot added the bash related to bash shell or scripts label Apr 3, 2023
@alfeilex alfeilex linked an issue Apr 3, 2023 that may be closed by this pull request
@alfeilex alfeilex marked this pull request as ready for review April 3, 2023 13:48
@github-actions github-actions bot added the SCM software-configuration-management (github actions, internal processes, git or github utilization) label Apr 7, 2023
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex thanks for your PR. Your way to compute the hashes looks fine now. 👍
I left some review comments for improvements. Can you have a look?

@github-actions github-actions bot removed the SCM software-configuration-management (github actions, internal processes, git or github utilization) label Apr 11, 2023
@alfeilex alfeilex closed this Apr 12, 2023
@alfeilex alfeilex force-pushed the feature/url-checksum-generator branch from bfdd976 to 7a3dcf7 Compare April 12, 2023 13:08
@github-actions github-actions bot removed the bash related to bash shell or scripts label Apr 12, 2023
@alfeilex alfeilex reopened this Apr 12, 2023
@github-actions github-actions bot added the bash related to bash shell or scripts label Apr 12, 2023
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex thanks for rework. 👍
I addressed the last open review comment so now ready for merge.

@hohwille hohwille merged commit d8e0b26 into devonfw:master Apr 14, 2023
@hohwille hohwille added this to the release:2023.04.001 milestone Apr 14, 2023
@alfeilex alfeilex deleted the feature/url-checksum-generator branch April 26, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bash related to bash shell or scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compute checksum of binary downloads
2 participants