-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1065: Add SHA-256 checksum generator to url-updater #1093
#1065: Add SHA-256 checksum generator to url-updater #1093
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alfeilex thanks for your PR. Your way to compute the hashes looks fine now. 👍
I left some review comments for improvements. Can you have a look?
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlChecksum.java
Outdated
Show resolved
Hide resolved
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlChecksum.java
Outdated
Show resolved
Hide resolved
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlChecksum.java
Outdated
Show resolved
Hide resolved
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlChecksum.java
Outdated
Show resolved
Hide resolved
url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/UrlChecksum.java
Outdated
Show resolved
Hide resolved
bfdd976
to
7a3dcf7
Compare
…lfeilex/ide into feature/url-checksum-generator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alfeilex thanks for rework. 👍
I addressed the last open review comment so now ready for merge.
This PR adds a checksum generator that calculates the checksum of the download files covered by download urls of each tool and its OS. The hash algorithm used is SHA256.
Example:
Windows_x64.urls will have a Windows_x64.urls.sha256