Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken tests: sklearn.cross_validation has been removed from scikit-learn 0.20 #3730

Closed
hcho3 opened this issue Sep 26, 2018 · 0 comments
Closed

Broken tests: sklearn.cross_validation has been removed from scikit-learn 0.20 #3730

hcho3 opened this issue Sep 26, 2018 · 0 comments

Comments

@hcho3
Copy link
Collaborator

hcho3 commented Sep 26, 2018

Scikit-learn 0.20 has been released today, and this version removes sklearn.cross_validation, which has been deprecated. See http://scikit-learn.org/0.19/modules/classes.html#to-be-removed-in-0-20. As a result of the removal, the Python tests are broken.

Solution: Replace sklearn.cross_validation with sklearn.sklearn.model_selection.
hcho3 added a commit to hcho3/xgboost that referenced this issue Sep 27, 2018
@hcho3
Fix dmlc#3730: scikit-learn 0.20 compatibility fix
b67f229 
sklearn.cross_validation has been removed from scikit-learn 0.20,
so replace it with sklearn.model_selection
@hcho3 hcho3 mentioned this issue Sep 27, 2018
Merged
hcho3 added a commit that referenced this issue Sep 27, 2018
@hcho3
Fix #3730: scikit-learn 0.20 compatibility fix
c45cd2f 
sklearn.cross_validation has been removed from scikit-learn 0.20,
so replace it with sklearn.model_selection
hcho3 added a commit to hcho3/xgboost that referenced this issue Sep 27, 2018
@hcho3
Fix dmlc#3730: scikit-learn 0.20 compatibility fix
d254de1 
sklearn.cross_validation has been removed from scikit-learn 0.20,
so replace it with sklearn.model_selection
hcho3 added a commit to hcho3/xgboost that referenced this issue Sep 27, 2018
@hcho3
Fix dmlc#3730: scikit-learn 0.20 compatibility fix
5a966ea 
sklearn.cross_validation has been removed from scikit-learn 0.20,
so replace it with sklearn.model_selection
hcho3 added a commit that referenced this issue Sep 27, 2018
@hcho3
Fix #3730: scikit-learn 0.20 compatibility fix (#3731)
51478a3 
* Fix #3730: scikit-learn 0.20 compatibility fix

sklearn.cross_validation has been removed from scikit-learn 0.20,
so replace it with sklearn.model_selection

* Display test names for Python tests for clarity
hcho3 added a commit that referenced this issue Sep 27, 2018
@hcho3
Fix #3730: scikit-learn 0.20 compatibility fix (#3731)
c0bd296 
* Fix #3730: scikit-learn 0.20 compatibility fix

sklearn.cross_validation has been removed from scikit-learn 0.20,
so replace it with sklearn.model_selection

* Display test names for Python tests for clarity
hcho3 added a commit that referenced this issue Sep 28, 2018
@hcho3
Fix #3730: scikit-learn 0.20 compatibility fix (#3731)
bc35b8e 
* Fix #3730: scikit-learn 0.20 compatibility fix

sklearn.cross_validation has been removed from scikit-learn 0.20,
so replace it with sklearn.model_selection

* Display test names for Python tests for clarity
alois-bissuel pushed a commit to criteo-forks/xgboost that referenced this issue Dec 4, 2018
@hcho3 @alois-bissuel
Fix dmlc#3730: scikit-learn 0.20 compatibility fix (dmlc#3731)
7b138ab 
* Fix dmlc#3730: scikit-learn 0.20 compatibility fix

sklearn.cross_validation has been removed from scikit-learn 0.20,
so replace it with sklearn.model_selection

* Display test names for Python tests for clarity
@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hcho3