Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3730: scikit-learn 0.20 compatibility fix #3731

Merged
merged 2 commits into from
Sep 27, 2018

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Sep 27, 2018

sklearn.cross_validation has been removed from scikit-learn 0.20, so replace it with sklearn.model_selection

Fixes #3730.

sklearn.cross_validation has been removed from scikit-learn 0.20,
so replace it with sklearn.model_selection
@hcho3 hcho3 merged commit 51478a3 into dmlc:master Sep 27, 2018
@hcho3 hcho3 deleted the fix_sklearn_ver branch September 27, 2018 22:03
hcho3 added a commit that referenced this pull request Sep 27, 2018
* Fix #3730: scikit-learn 0.20 compatibility fix

sklearn.cross_validation has been removed from scikit-learn 0.20,
so replace it with sklearn.model_selection

* Display test names for Python tests for clarity
hcho3 added a commit that referenced this pull request Sep 28, 2018
* Fix #3730: scikit-learn 0.20 compatibility fix

sklearn.cross_validation has been removed from scikit-learn 0.20,
so replace it with sklearn.model_selection

* Display test names for Python tests for clarity
alois-bissuel pushed a commit to criteo-forks/xgboost that referenced this pull request Dec 4, 2018
* Fix dmlc#3730: scikit-learn 0.20 compatibility fix

sklearn.cross_validation has been removed from scikit-learn 0.20,
so replace it with sklearn.model_selection

* Display test names for Python tests for clarity
@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant