Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DMatrix does not parse libsvm txt format when # comment is present #4135

Closed
kkonevets opened this issue Feb 13, 2019 · 2 comments · Fixed by dmlc/dmlc-core#514 or #4430
Closed

DMatrix does not parse libsvm txt format when # comment is present #4135

kkonevets opened this issue Feb 13, 2019 · 2 comments · Fixed by dmlc/dmlc-core#514 or #4430

Comments

@kkonevets
Copy link

For example, libsvm format is this one
https://sourceforge.net/p/lemur/wiki/RankLib%20File%20Format/

When # comment is present at the end of line DMatrix crashes on loading. Error is unreadable at all
@kkonevets kkonevets changed the title DMatrix does not parse libsvm txt format when # comment present DMatrix does not parse libsvm txt format when # comment is present Feb 13, 2019
trivialfis added a commit to trivialfis/dmlc-core that referenced this issue Mar 10, 2019
@trivialfis
Ignore comments in LIBSVM parser.
ef8d3b1 
Fix dmlc/xgboost#4135.
@trivialfis trivialfis mentioned this issue Mar 10, 2019
Merged
@trivialfis
Copy link
Member

@hcho3 Could you take a look at dmlc/dmlc-core#514 ?

@trivialfis
Copy link
Member

@hcho3 Any update? :)

hcho3 pushed a commit to dmlc/dmlc-core that referenced this issue Apr 30, 2019
@trivialfis @hcho3
Ignore comments in LIBSVM parser. (#514)
2880556 
Fix dmlc/xgboost#4135.
@hcho3 hcho3 removed the known-issue label May 2, 2019
@hcho3 hcho3 mentioned this issue May 2, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@hcho3 @trivialfis @kkonevets