Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dmlc-core, to handle comments in LIBSVM files #4430

Merged
merged 1 commit into from
May 2, 2019
Merged

Upgrade dmlc-core, to handle comments in LIBSVM files #4430

merged 1 commit into from
May 2, 2019

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented May 2, 2019

Fixes #4135.

Now XGBoost is able to handle LIBSVM files with comments

cc @trivialfis

@trivialfis trivialfis merged commit c1e4a0f into dmlc:master May 2, 2019
@hcho3 hcho3 deleted the upgrade_dmlc branch May 2, 2019 12:15
@hcho3 hcho3 mentioned this pull request May 3, 2019
Closed
18 tasks
@hcho3 hcho3 mentioned this pull request May 17, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DMatrix does not parse libsvm txt format when # comment is present
2 participants
@hcho3 @trivialfis