[jvm-packages] Refactor XGBoost.scala to put all params processing in one place #4815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodingCat
changed the title
CodingCat
changed the title
trivialfis
reviewed
Aug 29, 2019
| if (overridedParams.contains("nthread")) { | ||
| val nThread = overridedParams("nthread").toString.toInt | ||
| require(nThread <= coresPerTask, | ||
| s"the nthread configuration ($nThread) must be no larger than " + |
There was a problem hiding this comment.
Reasonable, but why is it a requirement?
There was a problem hiding this comment.
the logic is nthread are threads used by xgb to train
coresPerTasks is how many cores allocated to each task by cluster manager,
so nthread > coresPerTasks does not make sense
| if (numEarlyStoppingRounds > 0 && | ||
| !overridedParams.contains("maximize_evaluation_metrics")) { | ||
| if (overridedParams.contains("custom_eval")) { | ||
| throw new IllegalArgumentException("custom_eval does not support early stopping") |
There was a problem hiding this comment.
What's hurdle for supporting it?
There was a problem hiding this comment.
we need a mechanism to support metrics sync, but we didn't reach to the agreement
| validateSparkSslConf | ||
|
|
||
| if (overridedParams.contains("tree_method")) { | ||
| require(overridedParams("tree_method") == "hist" || |
There was a problem hiding this comment.
I think we have gpu hist now. But sure when it can be upstreamed. Just trying to take a note.
CodingCat
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
several pattern matching needs to be changed when adding a new param now, e.g. #4805
this PR is to refactor XGBoost.scala to make code cleaner