[jvm-packages] update rabit, surface new changes to spark, add parity and failure tests #4966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
changed the title
CodingCat
reviewed
Oct 21, 2019
| "minimal counts of enable allreduce/broadcast with ring based topology", | ||
| ParamValidators.gtEq(1)) | ||
|
|
||
| final def reduceBuffer: Param[String] = new Param[String](this, "rabitReduceBuffer", |
There was a problem hiding this comment.
I would suggest exposing less to users
...ckages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/params/RabitParams.scala
Outdated
Show resolved
Hide resolved
...ckages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/params/RabitParams.scala
Outdated
Show resolved
Hide resolved
...boost4j-spark/src/test/scala/ml/dmlc/xgboost4j/scala/spark/XGBoostRabitRegressionSuite.scala
Outdated
Show resolved
Hide resolved
chenqin
force-pushed
the
master
branch
2 times, most recently
from
c682b96
to
aeb3e22
Compare
|
Merging latest master to fix test-python-cpu, which has been timing out. See #4973. |
Codecov Report
@@ Coverage Diff @@
## master #4966 +/- ##
=======================================
Coverage 71.82% 71.82%
=======================================
Files 11 11
Lines 2300 2300
=======================================
Hits 1652 1652
Misses 648 648Continue to review full report at Codecov.
|
CodingCat
reviewed
Oct 22, 2019
...ackages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/CheckpointManager.scala
Outdated
Show resolved
Hide resolved
jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoost.scala
Outdated
Show resolved
Hide resolved
jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoost.scala
Show resolved
Hide resolved
jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoost.scala
Show resolved
Hide resolved
...boost4j-spark/src/test/scala/ml/dmlc/xgboost4j/scala/spark/XGBoostRabitRegressionSuite.scala
Outdated
Show resolved
Hide resolved
trams
approved these changes
Oct 24, 2019
...boost4j-spark/src/test/scala/ml/dmlc/xgboost4j/scala/spark/XGBoostRabitRegressionSuite.scala
Outdated
Show resolved
Hide resolved
CodingCat
approved these changes
Oct 29, 2019
...boost4j-spark/src/test/scala/ml/dmlc/xgboost4j/scala/spark/XGBoostRabitRegressionSuite.scala
Outdated
Show resolved
Hide resolved
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@CodingCat
cc @trivialfis