Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use latest dask #4973

Merged
merged 3 commits into from
Oct 22, 2019
Merged

[CI] Use latest dask #4973

merged 3 commits into from
Oct 22, 2019

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Oct 22, 2019

Dask tests are stuck and timing out due to dask/dask#5465: https://xgboost-ci.net/blue/organizations/jenkins/xgboost/detail/PR-4971/2/pipeline/40/#step-75-log-1677. The cause of the timeout is because one of dependencies of Dask, distributed, changed its semantics in recent versions in ways that are not compatible with Dask 2.0.0. Fix: Pin version of distributed.

@hcho3 hcho3 requested a review from trivialfis October 22, 2019 08:06
@trivialfis
Copy link
Member

I thought 2.5 is available now? Can we remove the version number and stick with the latest version?

@hcho3
Copy link
Collaborator Author

hcho3 commented Oct 22, 2019

@trivialfis What is our commitment with Dask support? Is it sufficient to use the latest all the time, or should we accommodate users of older versions? (I'm assuming we'd need at least 2.0.0) In #4617, I updated XGBoost so as to be compatible with both 1.2.x and 2.0.0. Let us pick the oldest version of Dask we are willing to support.

cc @RAMitchell @mt-jones @mrocklin

@hcho3 hcho3 requested a review from RAMitchell October 22, 2019 08:18
@trivialfis
Copy link
Member

trivialfis commented Oct 22, 2019

No. Just keep running with the latest version. Dask is very light weight(aside from the fact that pandas is involved) and uses small releases. Also we don't use any internal API so if something breaks we can fix it in dask.

@hcho3
Copy link
Collaborator Author

hcho3 commented Oct 22, 2019

@trivialfis When Dask 2.0 was released, it renamed an internal variable and broke XGBoost, so I had to submit #4617. I wonder whether something like this could happen again. We could choose the middle ground and only specify the major release of Dask, e.g. dask>=2.0.0,<3.0.0.

@trivialfis
Copy link
Member

trivialfis commented Oct 22, 2019 via email

@hcho3 hcho3 changed the title [CI] Use correct version for 'distributed' dependency of 'dask' [CI] Use latest dask Oct 22, 2019
@hcho3
Copy link
Collaborator Author

hcho3 commented Oct 22, 2019

Thanks for clarification.

@trivialfis trivialfis merged commit 95295ce into dmlc:master Oct 22, 2019
@trivialfis
Copy link
Member

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
@hcho3 hcho3 deleted the fix_dask_dep branch February 19, 2020 03:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants