Model IO in JSON. #5110
Model IO in JSON. #5110
Conversation
| } | ||
|
|
||
| { | ||
| model = Json::Load({model_str.c_str(), model_str.size()}); |
There was a problem hiding this comment.
Nit: It took me a little bit to realize that StringView object was being implicitly constructed. Personally I'd prefer declaring StringView constructor to be explicit.
|
|
||
| { | ||
| model = Json::Load({model_str.c_str(), model_str.size()}); | ||
| model = model["model"]; |
There was a problem hiding this comment.
Question: Is this simply a shallow copy (pointer assignment), or is this involving a deep copy?
There was a problem hiding this comment.
@hcho3 It involves a deep copy. Use reference if you don't want a copy
| { | ||
| model = Json::Load({model_str.c_str(), model_str.size()}); | ||
| model = model["model"]; | ||
| auto weights = get<Array>(model["weights"]); | ||
| ASSERT_EQ(weights.size(), 17); // 16 + 1 (bias) | ||
| } |
There was a problem hiding this comment.
Isn't this block a duplicate of line 38-45?
There was a problem hiding this comment.
@hcho3 No, the model is reloaded. But I will structure it more clearly.
There was a problem hiding this comment.
So the model is loaded from model_str twice?
| auto& j_model = model["model"]; | ||
| model["parameters"] = Object(); | ||
|
|
||
| gbm->SaveModel(&j_model); |
There was a problem hiding this comment.
Nice, this snippet is a good exhibit of the power and flexibility of a nested key-value store.
| for (int32_t iter = 0; iter < kIters; ++iter) { | ||
| learner->UpdateOneIter(iter, p_dmat.get()); | ||
| } | ||
| learner->SetAttr("bset_score", "15.2"); |
There was a problem hiding this comment.
@hcho3 Typo, opening a new PR for addressing your comments.
The "model" part of #4732. Follow up PRs will be for "Configuration".