Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refinements for JSON model. #5112

Merged
merged 4 commits into from
Dec 11, 2019
Merged

Small refinements for JSON model. #5112

merged 4 commits into from
Dec 11, 2019

Conversation

trivialfis
Copy link
Member

@trivialfis
Copy link
Member Author

@hcho3 @RAMitchell

@trivialfis trivialfis mentioned this pull request Dec 11, 2019
Merged
hcho3
hcho3 requested changes Dec 11, 2019
View reviewed changes
tests/cpp/test_learner.cc Show resolved Hide resolved
@trivialfis trivialfis mentioned this pull request Dec 11, 2019
Merged
@trivialfis trivialfis merged commit ad4a1c7 into dmlc:master Dec 11, 2019
@trivialfis trivialfis deleted the model-fixes branch December 11, 2019 11:49
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hcho3 hcho3 hcho3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @hcho3