Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated matplotlib installation #5322

Closed
wants to merge 3 commits into from
Closed

Remove duplicated matplotlib installation #5322

wants to merge 3 commits into from

Conversation

Wei-1
Copy link

@Wei-1 Wei-1 commented Feb 18, 2020

In Dockerfile.cpu matplotlib was installed twice.
Removing the duplication for cleanness

In Dockerfile.cpu matplotlib was installed twice.
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Wei-1
Copy link
Author

Wei-1 commented Feb 20, 2020

Error log shows that Client: not connected while testing xgboost.dask
Is this an occasional failure?

@trivialfis
Copy link
Member

No. Let me take a look, there is a fix by removing use of test fixture in master branch, I'm not sure if your branch has that commit.

@Wei-1
Copy link
Author

Wei-1 commented Feb 20, 2020

I can see the latest commit is: Display Sponsor button, link to OpenCollective (#5325)
l will rebase this PR to that.

@trivialfis
Copy link
Member

That's weird ... Only this PR is having trouble. @hcho3 Have you seen similar issue in other build?

@Wei-1
Copy link
Author

Wei-1 commented Feb 20, 2020

Will the order of the matplotlib installation make a difference?
Maybe caused by version dependency or something?

@Wei-1
Copy link
Author

Wei-1 commented Mar 3, 2020

Close because fixed by #5336

@Wei-1 Wei-1 closed this Mar 3, 2020
@Wei-1 Wei-1 deleted the patch-2 branch March 3, 2020 10:21
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants