Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port patches from 1.0.0 branch #5336

Merged
merged 4 commits into from
Feb 21, 2020
Merged

Port patches from 1.0.0 branch #5336

merged 4 commits into from
Feb 21, 2020

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Feb 21, 2020

Also, when I was working on 1.0.1 patch release, I fixed two bugs:

  • Enforce only major version in JSON model schema: The schema had 1.0.0 version hard-coded in, so any bump in the version in the codebase would cause schema violation. I revised the schema to only fix the major version. Any major revision of the model schema would bump up the major version.
  • Fix a unit test that mistook MINOR ver for PATCH ver: This appears to be a typo in the unit test.

* Remove f-string, since it's not supported by Python 3.5

* Add Python 3.5 to CI, to ensure compatibility

* Remove duplicated matplotlib

* Show deprecation notice for Python 3.5

* Fix lint

* Fix lint
@hcho3 hcho3 requested a review from trivialfis February 21, 2020 18:34
python-package/xgboost/sklearn.py Show resolved Hide resolved
tests/ci_build/test_python.sh Show resolved Hide resolved
python-package/xgboost/__init__.py Show resolved Hide resolved
@mli
Copy link
Member

mli commented Feb 21, 2020

Codecov Report

Merging #5336 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5336      +/-   ##
==========================================
- Coverage   83.76%   83.75%   -0.02%     
==========================================
  Files          11       11              
  Lines        2409     2413       +4     
==========================================
+ Hits         2018     2021       +3     
- Misses        391      392       +1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aa8ef1...75ca766. Read the comment docs.

@hcho3 hcho3 merged commit 7ac7e87 into dmlc:master Feb 21, 2020
@hcho3 hcho3 deleted the port_100 branch February 21, 2020 21:13
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants