Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge main #52156

Merged
92 commits merged into from
Mar 26, 2021
Merged

merge main #52156

92 commits merged into from
Mar 26, 2021

Commits on Dec 30, 2020

  1. Configuration menu
    Copy the full SHA
    7fd7fc9 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2020

  1. Configuration menu
    Copy the full SHA
    c826253 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2021

  1. Configuration menu
    Copy the full SHA
    be60917 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5855620 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. Configuration menu
    Copy the full SHA
    a42c08b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7012145 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8be47a7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    99403fc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d403720 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Configuration menu
    Copy the full SHA
    dfedff7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1988173 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9c3c6b9 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. Configuration menu
    Copy the full SHA
    09910b5 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Add intellicode API for generating code action edits from intents and

    start implementation of generate ctor intent
    dibarbet committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    8668378 View commit details
    Browse the repository at this point in the history
  2. review feedback

    dibarbet committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    1a4f96e View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Configuration menu
    Copy the full SHA
    58f295e View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2021

  1. Configuration menu
    Copy the full SHA
    23df180 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1960213 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bd010fb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8140401 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e0b4669 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c61f64b View commit details
    Browse the repository at this point in the history
  7. Clean up some of the LazySyntaxTree constructors/factory methods

    - Don't take a cancellation token, since the whole point is not to
      do expensive work
    - Just keep fields and parameters in a consistent order
    jasonmalinowski committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    4ecdc8c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b733708 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b99bcbd View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    87ba423 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    272a4bc View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2021

  1. Configuration menu
    Copy the full SHA
    9ddcfb6 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2021

  1. Configuration menu
    Copy the full SHA
    b254587 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    942e5a4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d2cf831 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8f67fdc View commit details
    Browse the repository at this point in the history
  5. Fix for: "Information Loss" caused by use of default in SyntaxNode-Up…

    …date methods dotnet#51997 (dotnet#52036)
    
    Co-authored-by: Bernd Baumanns <familiebaumanns@googlemail.com>
    bernd5 and Bernd Baumanns authored Mar 22, 2021
    Configuration menu
    Copy the full SHA
    9ddf51f View commit details
    Browse the repository at this point in the history
  6. Merge pull request dotnet#52056 from JoeRobich/slnf-separators

    Use absolute project paths when loading a Solution Filter
    JoeRobich authored Mar 22, 2021
    Configuration menu
    Copy the full SHA
    b47625a View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. Configuration menu
    Copy the full SHA
    7becc52 View commit details
    Browse the repository at this point in the history
  2. Merge pull request dotnet#52055 from dotnet/dev/jorobich/downgrade-te…

    …xt-json
    
    Downgrade System.Text.Json reference version to 4.7.2
    JoeRobich authored Mar 23, 2021
    Configuration menu
    Copy the full SHA
    672e565 View commit details
    Browse the repository at this point in the history
  3. Update API shape to take in rewind edits and allow multiple results. …

    …Also add external access for intellicode dll
    dibarbet committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    e59c2e2 View commit details
    Browse the repository at this point in the history
  4. update comment

    dibarbet committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    1a77506 View commit details
    Browse the repository at this point in the history
  5. Add missing [Fact] in ConversionCompletionProviderTests

    Follow up to dotnet#47511
    
    I missed placing the `[Fact]` attribute on one test method. @CyrusNajmabadi
    MaStr11 authored Mar 23, 2021
    Configuration menu
    Copy the full SHA
    1b56a44 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    887150e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    23a079d View commit details
    Browse the repository at this point in the history
  8. Add clarifying comments

    JoeRobich committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    f3462ac View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5deb53a View commit details
    Browse the repository at this point in the history
  10. Initialize fields before registering event handlers

    Fixes a NullReferenceException in DocumentFileChangeContext_FileChanged
    observed in local debugging.
    sharwell committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    5228f97 View commit details
    Browse the repository at this point in the history
  11. Merge pull request dotnet#52073 from Youssef1313/patch-38

    Obsolete ImportingConstructor
    sharwell authored Mar 23, 2021
    Configuration menu
    Copy the full SHA
    9552f01 View commit details
    Browse the repository at this point in the history
  12. Merge pull request dotnet#52071 from MaStr11/patch-2

    Add missing [Fact] in ConversionCompletionProviderTests
    sharwell authored Mar 23, 2021
    Configuration menu
    Copy the full SHA
    14cdeb2 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    f554f62 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    06a421e View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    c30efad View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    d09f248 View commit details
    Browse the repository at this point in the history
  17. Merge pull request dotnet#52088 from dotnet/revert-47360-normalizewhi…

    …tespace-xmlcomments
    
    Revert "Make DocumentationCommentCompiler work after NormalizeWhitespace"
    jaredpar authored Mar 23, 2021
    Configuration menu
    Copy the full SHA
    9995cfd View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    7e1f4b7 View commit details
    Browse the repository at this point in the history
  19. review feedback

    dibarbet committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    80dc0c2 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    e0d76c8 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    58e6128 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. Configuration menu
    Copy the full SHA
    7507fd0 View commit details
    Browse the repository at this point in the history
  2. Simplify

    CyrusNajmabadi committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    da13839 View commit details
    Browse the repository at this point in the history
  3. Simplify

    CyrusNajmabadi committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    d8843e8 View commit details
    Browse the repository at this point in the history
  4. Merge pull request dotnet#52082 from sharwell/init-order

    Initialize fields before registering event handlers
    sharwell authored Mar 24, 2021
    Configuration menu
    Copy the full SHA
    ef50316 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7859e2d View commit details
    Browse the repository at this point in the history
  6. Merge pull request dotnet#51826 from JoeRobich/update-publish-dev17

    Update PublishData for dev17.0
    msftbot[bot] authored Mar 24, 2021
    Configuration menu
    Copy the full SHA
    651609d View commit details
    Browse the repository at this point in the history
  7. Add overload

    CyrusNajmabadi committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    760aeb1 View commit details
    Browse the repository at this point in the history
  8. Merge pull request dotnet#51456 from JoeRobich/add-customtags-to-code…

    …action
    
    Add CustomTags to CodeAction
    JoeRobich authored Mar 24, 2021
    Configuration menu
    Copy the full SHA
    a02ee4e View commit details
    Browse the repository at this point in the history
  9. Merge pull request dotnet#52093 from dotnet/dev/jorobich/downgrade-stj

    Downgrade System.Text.Json to 4.7.0
    JoeRobich authored Mar 24, 2021
    Configuration menu
    Copy the full SHA
    ff5f51a View commit details
    Browse the repository at this point in the history
  10. Merge pull request dotnet#52096 from CyrusNajmabadi/extractQI

    Extract out common QI code for Xaml to use.
    msftbot[bot] authored Mar 24, 2021
    Configuration menu
    Copy the full SHA
    1e94706 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2cb3dc7 View commit details
    Browse the repository at this point in the history
  12. Updated XAML QuickInfo to show more info like C# by using ISymbolDisp…

    …layService and adding more documentation parts.
    mgoertz-msft committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    aa65c9f View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    1d7aabe View commit details
    Browse the repository at this point in the history
  14. Rebuild API shape (dotnet#52079)

    * Rebuild API shape
    
    This breaks up `BuildConstructor` into a simple hierarchy with both
    CSharp and Visual Basic implementations. The name `CompilationFactory`
    was chosen after a bit of offline conversation and mostly due to this
    representing a factory of sorts. As with all other API names it will be
    reviewed before making this API officially public / shipping.
    
    Note: there is no intended functional change with this PR, it is purely
    just refactoring the API shape around.
    
    * Apply suggestions from code review
    
    Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>
    
    * PR Feedback
    
    * PR feedback
    
    * PR feedback
    
    Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>
    jaredpar and RikkiGibson authored Mar 24, 2021
    Configuration menu
    Copy the full SHA
    7fea27a View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    202e9a9 View commit details
    Browse the repository at this point in the history
  16. Update src/VisualStudio/Xaml/Impl/Implementation/LanguageServer/Exten…

    …sions/SymbolExtensions.cs
    
    Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
    mgoertz-msft and CyrusNajmabadi authored Mar 24, 2021
    Configuration menu
    Copy the full SHA
    d709a40 View commit details
    Browse the repository at this point in the history
  17. Merge pull request dotnet#51846 from mgoertz-msft/dev/mgoertz/quickinfo

    XAML QuickInfo update
    msftbot[bot] authored Mar 24, 2021
    Configuration menu
    Copy the full SHA
    1360d6f View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    1756346 View commit details
    Browse the repository at this point in the history
  19. Merge pull request dotnet#51911 from dibarbet/intents

    Add intellicode API for generating code action edits from intents and
    dibarbet authored Mar 24, 2021
    Configuration menu
    Copy the full SHA
    064bf65 View commit details
    Browse the repository at this point in the history
  20. Use null instead of empty signature helps in LSP

    - The LSP specification requires that `signatures` be provided. Currently Roslyn breaks this LSP contract by returning a new signature help item. It should be returning `null`
    NTaylorMullen authored Mar 24, 2021
    Configuration menu
    Copy the full SHA
    1d66eeb View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. Configuration menu
    Copy the full SHA
    66926b5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e2f6128 View commit details
    Browse the repository at this point in the history
  3. Enable CodeActions support for XAML using its own provider and CodeAc…

    …tionCache. The handlers are actually shared with Roslyn as is. (dotnet#52129)
    
    Switch to using a path to DocumentId cache in the XamlProjectService to avoid unnecessary and sometimes dangerous transitions to the main thread during TrackDocument calls.
    mgoertz-msft authored Mar 25, 2021
    Configuration menu
    Copy the full SHA
    ef49312 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9c6ee96 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9348117 View commit details
    Browse the repository at this point in the history
  6. Merge pull request dotnet#52078 from Youssef1313/patch-54

    Update IDEDiagnosticIDConfigurationTests to be exclusive rather than inclusive
    genlu authored Mar 25, 2021
    Configuration menu
    Copy the full SHA
    d595676 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    aa4f067 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a4b27fa View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4568196 View commit details
    Browse the repository at this point in the history
  10. Fix typescript shim

    NTaylorMullen committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    9f7b220 View commit details
    Browse the repository at this point in the history
  11. F5 Hot Reload (dotnet#52101)

    * Move debugging service to debugging session
    
    * Remove warnings for edits made while app is running
    
    * Open edit sessions for both running and break states
    
    * Trigger document reanalysis after EmitSolutionUpdateAsync
    tmat authored Mar 25, 2021
    Configuration menu
    Copy the full SHA
    73d4432 View commit details
    Browse the repository at this point in the history
  12. Use OptimizedVSCompletionList in LSP scenarios.

    - The optimized completion list type offers "fast" serialization (3.7x).
    - This is dependent upon a VS LSP Platform PR getting in: https://devdiv.visualstudio.com/DevDiv/_git/VSLanguageServerClient/pullrequest/312367
    - Update language server protocol package version.
    
    Part of dotnet/aspnetcore#30232
    NTaylorMullen committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    bc81bab View commit details
    Browse the repository at this point in the history
  13. Merge pull request dotnet#52126 from dotnet/nimullen/signaturehelp

    Use `null` instead of empty signature helps in LSP
    msftbot[bot] authored Mar 25, 2021
    Configuration menu
    Copy the full SHA
    034641f View commit details
    Browse the repository at this point in the history
  14. Merge pull request dotnet#50490 from sharwell/cache-sg-api

    Replace SyntaxTree caching with IDE document state preservation
    msftbot[bot] authored Mar 25, 2021
    Configuration menu
    Copy the full SHA
    989327e View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    90333c8 View commit details
    Browse the repository at this point in the history
  16. Split BoundInterpolatedString into BoundInterpolatedString and BoundU…

    …nconvertedInterpolatedString (dotnet#52061)
    
    This is intended to be a semantics-preserving refactoring that will make later work easier. When an interpolated string is first encountered, we now bind it as a `BoundUnconvertedInterpolatedString` node, and then when we bind to the natural type we convert it to a `BoundInterpolatedString` expression. Future code to allow it to convert to non-string types will take advantage of this in the conversion step.
    333fred authored Mar 25, 2021
    Configuration menu
    Copy the full SHA
    17056f8 View commit details
    Browse the repository at this point in the history
  17. Merge remote-tracking branch 'upstream/main' into merge-main

    * upstream/main: (75 commits)
      Split BoundInterpolatedString into BoundInterpolatedString and BoundUnconvertedInterpolatedString (dotnet#52061)
      Combine VB comparers into one, and combine VB and C# comparers together (dotnet#51834)
      Use OptimizedVSCompletionList in LSP scenarios.
      F5 Hot Reload (dotnet#52101)
      Fix typescript shim
      Add tests for lazy syntax trees coming from the GeneratorDriver
      React to code review feedback.
      Simplify the lazy-initalization pattern used in GetRoot
      Remove an unnecessary override. (dotnet#52140)
      Update issue number (dotnet#52130)
      Enable CodeActions support for XAML using its own provider and CodeActionCache. The handlers are actually shared with Roslyn as is. (dotnet#52129)
      Add RestrictedIVT to dotnet watch to Features (dotnet#52087)
      Don't try to highlight operators (dotnet#52041)
      Use `null` instead of empty signature helps in LSP
      Use member type for relational pattern even in error cases (dotnet#51950)
      Update src/VisualStudio/Xaml/Impl/Implementation/LanguageServer/Extensions/SymbolExtensions.cs
      Use new QuickInfoUtilities helper
      Rebuild API shape (dotnet#52079)
      Added position parameter name
      Updated XAML QuickInfo to show more info like C# by using ISymbolDisplayService and adding more documentation parts.
      ...
    333fred committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    fd2072d View commit details
    Browse the repository at this point in the history