Use specific error message for wrong arity in async builder #54632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking my feedback 😄 |
19 tasks
cston
approved these changes
Jul 6, 2021
RikkiGibson
reviewed
Jul 7, 2021
| ? builderType.IsUnboundGenericType && builderType.ContainingType?.IsGenericType != true && builderType.Arity == 1 | ||
| : !builderType.IsGenericType; | ||
| if (isArityOk) | ||
| if (isGeneric) |
There was a problem hiding this comment.
Could you please clarify the difference between isGeneric and builderType.IsGenericType?
There was a problem hiding this comment.
Is it something like: isGeneric refers to whether the task-like thing is generic, while builderType.IsGenericType refers to whether the builder is generic?
There was a problem hiding this comment.
Correct. Whether the return type is generic or not drives the rest of the process.
RikkiGibson
approved these changes
Jul 7, 2021
ghost
modified the milestones:
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jul 8, 2021
* upstream/main: (559 commits) Remove a few unused error codes (dotnet#54663) Use specific error message for wrong arity in async builder (dotnet#54632) Update azure-pipelines-richnav.yml (dotnet#54662) Capture file content on open instead of save (dotnet#54643) Add docs Further FAR simplifications Handle enhanced #line directive in DirectiveTriviaSyntax.DirectiveNameToken (dotnet#54636) move server name outside of loop Fix functionid Reduce telemetry output from find document in workspace Ensure we don't try and build an empty table when modifying entries with no values (dotnet#54639) Feedback Ensure we don't try and build an empty table when modifying entries with no values (dotnet#54639) No need to specialized logic for determining set of projects to search Defer group computation till reporting time Handle FAR for global suppressions in a consistent fashion Update status for enhanced `#line` directive (dotnet#54581) Split IOperationTests into one part per type [LSP] Revert semantic tokens change in main (dotnet#54570) Add exceptionutilities unreachable to catch blocks that should not be hit ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan: #51999
Corresponding spec change: dotnet/csharplang#4903
FYI @stephentoub