Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable richnav on PRs #54662

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Disable richnav on PRs #54662

merged 1 commit into from
Jul 7, 2021

Conversation

RikkiGibson
Copy link
Contributor

No description provided.

@RikkiGibson
Copy link
Contributor Author

RikkiGibson commented Jul 7, 2021

@dibarbet I think it might be better to take this PR instead of #54660. RichNav team has indicated that our long run times are due to recently added features. As far as I can tell we never actually expect the task to be successful with the current timeout of 200 minutes until RichNav has the opportunity to address the perf issues. I think it would be best to just disable completely on PRs and perhaps keep an eye on it for rolling builds so that we can see if the regression gets fixed.

@dibarbet
Copy link
Member

dibarbet commented Jul 7, 2021

I think it would be best to just disable completely on PRs and perhaps keep an eye on it for rolling builds so that we can see if the regression gets fixed.

I'm fine with disabling as well, can we file an issue assigned to richnav, and have them re-enable it on PRs once the regression is fixed?

@RikkiGibson RikkiGibson marked this pull request as ready for review July 7, 2021 20:14
@RikkiGibson RikkiGibson requested a review from a team as a code owner July 7, 2021 20:14
@RikkiGibson RikkiGibson merged commit 9178bba into main Jul 7, 2021
@ghost ghost added this to the Next milestone Jul 7, 2021
333fred added a commit to 333fred/roslyn that referenced this pull request Jul 8, 2021
* upstream/main: (559 commits)
  Remove a few unused error codes (dotnet#54663)
  Use specific error message for wrong arity in async builder (dotnet#54632)
  Update azure-pipelines-richnav.yml (dotnet#54662)
  Capture file content on open instead of save (dotnet#54643)
  Add docs
  Further FAR simplifications
  Handle enhanced #line directive in DirectiveTriviaSyntax.DirectiveNameToken (dotnet#54636)
  move server name outside of loop
  Fix functionid
  Reduce telemetry output from find document in workspace
  Ensure we don't try and build an empty table when modifying entries with no values (dotnet#54639)
  Feedback
  Ensure we don't try and build an empty table when modifying entries with no values (dotnet#54639)
  No need to specialized logic for determining set of projects to search
  Defer group computation till reporting time
  Handle FAR for global suppressions in a consistent fashion
  Update status for enhanced `#line` directive (dotnet#54581)
  Split IOperationTests into one part per type
  [LSP] Revert semantic tokens change in main (dotnet#54570)
  Add exceptionutilities unreachable to catch blocks that should not be hit
  ...
@allisonchou allisonchou modified the milestones: Next, 17.0.P3 Jul 27, 2021
@RikkiGibson RikkiGibson deleted the dev/rigibson/disable-richnav-pr branch May 9, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants