Handle enhanced #line directive in DirectiveTriviaSyntax.DirectiveNameToken #54636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's no imperative to get this into preview2, right? |
jcouv
reviewed
Jul 6, 2021
| @@ -44,6 +44,8 @@ public SyntaxToken DirectiveNameToken | |||
| return ((UndefDirectiveTriviaSyntax)this).UndefKeyword; | |||
| case SyntaxKind.LineDirectiveTrivia: | |||
| return ((LineDirectiveTriviaSyntax)this).LineKeyword; | |||
| case SyntaxKind.LineSpanDirectiveTrivia: | |||
| return ((LineSpanDirectiveTriviaSyntax)this).LineKeyword; | |||
There was a problem hiding this comment.
Consider adding a direct compiler API test, since public API
Never mind, it's there :-)
RikkiGibson
reviewed
Jul 6, 2021
| } | ||
| static void A() { } | ||
| static void B() { } | ||
| static void C() { } | ||
| static void D() { } |
There was a problem hiding this comment.
Does this cause the test to exhibit the bug fixed in this PR?
There was a problem hiding this comment.
No, this test change is unrelated to the bug fix, and is only here to test a more interesting case than the line above.
RikkiGibson
approved these changes
Jul 6, 2021
ghost
added this to the
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jul 8, 2021
* upstream/main: (559 commits) Remove a few unused error codes (dotnet#54663) Use specific error message for wrong arity in async builder (dotnet#54632) Update azure-pipelines-richnav.yml (dotnet#54662) Capture file content on open instead of save (dotnet#54643) Add docs Further FAR simplifications Handle enhanced #line directive in DirectiveTriviaSyntax.DirectiveNameToken (dotnet#54636) move server name outside of loop Fix functionid Reduce telemetry output from find document in workspace Ensure we don't try and build an empty table when modifying entries with no values (dotnet#54639) Feedback Ensure we don't try and build an empty table when modifying entries with no values (dotnet#54639) No need to specialized logic for determining set of projects to search Defer group computation till reporting time Handle FAR for global suppressions in a consistent fashion Update status for enhanced `#line` directive (dotnet#54581) Split IOperationTests into one part per type [LSP] Revert semantic tokens change in main (dotnet#54570) Add exceptionutilities unreachable to catch blocks that should not be hit ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and add several missing tests.
Test plan: #54509