-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Part II: Split DuneClient Class #72
Conversation
202f26d
to
6bc5f80
Compare
fc08575
to
b84dd2c
Compare
Note that we can circle back and clean this up even more later. This is mostly just an initial proposal for the final structure and servers as a starting point from which we can move things around as we see fit. |
10b15a0
to
c21da35
Compare
b84dd2c
to
f3e948a
Compare
46959b7
to
1eed668
Compare
1eed668
to
abdc08b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost a SHIP IP, but see my suggestions and comments, they're tiny and fast to address (mostly about comments and moving functions up/down the file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just passed through your comments. Will address all the ones with thumbs up ASAP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work @bh2smith. I only did a quick pass and it looks good to me. I left a few comments, but they are nitpicks for the most part. Feel free to ignore them if you disagree.
Thanks @RichardKeo for your careful review. I will create relevant issues and make suggested changes here accordingly first thing tomorrow! |
Co-authored-by: Miguel Filipe <msf@users.noreply.github.com>
Co-authored-by: Miguel Filipe <msf@users.noreply.github.com>
Co-authored-by: Miguel Filipe <msf@users.noreply.github.com>
Co-authored-by: Miguel Filipe <msf@users.noreply.github.com>
4567baa
to
2aa3ad0
Compare
Okie, I have addressed all the comments and suggestions here (@RichardKeo). Please let me know if this is ready for 🚢 . Everything else will follow much easier from here (as everything is currently based on this branch). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
dune_client/api/extensions.py
Outdated
return self.get_execution_results_csv(job_id) | ||
|
||
def run_query_dataframe( | ||
self, query: QueryBase, performance: Optional[str] = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you still planning to add ping_frequency
here?
In light of the backlog depending on this and all the comments addressed, I will merge this now. We can always double back and make additional changes upon request. |
We split the DuneClient class up with an inheritance structure described vaguely as follows:
Note that this is based on #64 (which should be merged first).
Closes #69
cc @TheEdgeOfRage & @diegoximenes for additional review.