Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21366] Bump version to v3.0.0 #884

Merged
merged 12 commits into from
Aug 26, 2024
Merged

[21366] Bump version to v3.0.0 #884

merged 12 commits into from
Aug 26, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Jul 30, 2024

Description

This PR bumps the project version to 3.0.0 and adds the corresponding release notes.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
    -N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@elianalf elianalf requested a review from richiprosima July 30, 2024 10:56
@elianalf elianalf added this to the v3.0.0 milestone Jul 30, 2024
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes LGTM

I think we should also remove the warning here

.. TODO(eduponz): Remove this before releasing v3.0.0

@Mario-DL
Copy link
Member

Mario-DL commented Jul 31, 2024

We will also wait for the rest of the PRs pending to merge in Fast DDS

@Mario-DL Mario-DL self-requested a review August 5, 2024 05:42
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@Mario-DL Mario-DL requested review from Mario-DL and removed request for richiprosima and Mario-DL August 5, 2024 07:38
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso requested review from Mario-DL and removed request for Mario-DL August 6, 2024 12:32
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso
Copy link
Contributor

I am missing Update fastcdr thirdparty and Add new tests for testing new key hash...

The xTypes fix was introduced previously, in line 28. Fast cdr submodule update introduced in commit ccb8138

@JesusPoderoso JesusPoderoso requested a review from Mario-DL August 7, 2024 07:29
Mario-DL
Mario-DL previously approved these changes Aug 7, 2024
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Green CI

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso requested review from Mario-DL and removed request for Mario-DL August 9, 2024 08:27
Mario-DL
Mario-DL previously approved these changes Aug 9, 2024
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso JesusPoderoso added implementation-pending Marks doc PRs which corresponding implementation is not yet available on Fast DDS and removed ci-pending labels Aug 9, 2024
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso added ready-to-merge and removed ci-pending implementation-pending Marks doc PRs which corresponding implementation is not yet available on Fast DDS labels Aug 26, 2024
@JesusPoderoso JesusPoderoso merged commit 5b0ee33 into master Aug 26, 2024
4 checks passed
@JesusPoderoso JesusPoderoso deleted the release/v3.0.0 branch August 26, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants