XTypes v1.3 refactor #130

JLBuenoLopez · 2024-04-04T07:51:25Z

This PR includes changes required to generate the XTypes v1.3 IDL files and the code to register the associated TypeObjects defined in the specification. Specifically, this PR includes:

New -genapi option that prepends to the OMG IDL module names the eprosima::fastdds namespace (developer option).
Remove -cdr option because from this point onward only Fast CDR v2 is going to be supported.
New -default-container-prealloc-size option to select how many elements to preallocate in the generated code for unbounded collections.
New -no-typeobject-support option to disable the TypeObject code generation.
Infrastructure to add tests for TypeObject generated code.
Several refactors for typecodes:
- Unions: discriminator and default value.
- C++ enum class
- New MemberAppliedAnnotations class to apply annotations to collection elements (partially supported. Collection element annotations are not yet parsed in the grammar and added to the element).
- Correctly register builtin annotations defined in IDL v4.2 and XTypes v1.3 specifications. Add API to access and check builtin annotations.
- Fix collections API to return correct TypeIdentifier discriminator depending on the bound size.
- Extend primitive Typecode API to check primitive kind.
- API to return collection's size.
STGroup template configuration
Improve documentation

src/main/java/com/eprosima/idl/context/Context.java

src/main/java/com/eprosima/idl/parser/tree/Annotation.java

src/main/java/com/eprosima/idl/parser/typecode/MemberAppliedAnnotations.java

richiware · 2024-04-05T09:24:12Z

src/main/java/com/eprosima/idl/parser/typecode/MemberedTypeCode.java

+    {
+        return m_members.size();
+    }
+
    public boolean addMember(
            Member member) throws ParseException
    {
        // Check annotations.
        if (member.isAnnotationOptional() && Kind.KIND_STRUCT != getKind())


sort alphabetically by annotation name

Done in d0f6d82

JLBuenoLopez

LGTM though I have left a small nitpick. Nevertheless, if the CI is green, this could be merge.

JLBuenoLopez · 2024-04-08T08:18:43Z

src/main/java/com/eprosima/idl/parser/typecode/MemberedTypeCode.java

        {
            throw new ParseException(null, "Error in member " + member.getName() +
-                    ": @" + Annotation.optional_str +" annotations only supported for structure's members.");
+                    ": @bit_bound annotations only supported for enumeration's members or bitmask's members.");


Nitpick: Now that every builtin annotation has its name defined in a variable, maybe we can use it in these methods. Some of them are using the variables and some others not.

* Refs #19944. Context uses TemplateManager Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #19944. Fix setting scope Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19932: fix union discriminator Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #19932: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> --------- Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

…ns API (#107) * Refs #19968: refactor Member and ContainerTypeCode to use common applied member annotations API Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #19968: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> --------- Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>