Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[null] Incomplete handling of @NonNullByDefault - fixes #682 #683

Merged
merged 1 commit into from
Feb 2, 2023

Commits on Feb 1, 2023

  1. [null] Incomplete handling of @NonNullByDefault - fixes eclipse-jdt#682

    + applying @NNBD to a type parameter needs to know, whether on demand
      resolving has already happened (to detect explicit null annotations)
      - ASTNode.resolveAnnotations
      - STB.maybeMarkTypeParametersNonNull
    + better distinction if null tag bits result from @NNBD or explicit anno
      - ASTNode.mergeAnnotationsIntoType
        - may now report redundance
        - fix withdrawal of contradiction null annots after these changes
    + more detection of redundance below @NNBD
      - TypeParameter.resolveAnnotations
      - TypeReference.resolveAnnotations - one focus on annots on dimensions
      - MethodBinding.fillInDefaultNonNullness18 - less reporting here
      - ProblemReporter.nullAnnotationIsRedundant
        - 2 more overloads
        - fine tuning of error positions
    + be careful not to apply @NNBD to typevar (when using TYPE_USE)
      - new methods {Scope,STB}.hasDefaultNullnessForType()
    + expect redundance warning in may more tests
      - NullTypeAnnotationTest
      - NullAnnotationBatchCompilerTest
    + ignore newly reported warnings in other tests:
      - IncrementalTests18.testBug483744_remove
      - ExternalAnnotations18Test (several)
    + new tests from Bugs 522142 and 499596
    stephan-herrmann committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    422a9b5 View commit details
    Browse the repository at this point in the history