Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random failing VirtualTableViewerTest.testRenameWithSorter and VirtualTableViewerTest.testContains #1005

Closed
HeikoKlare opened this issue Aug 11, 2023 · 3 comments · Fixed by #1862
Closed

Random failing VirtualTableViewerTest.testRenameWithSorter and VirtualTableViewerTest.testContains #1005

HeikoKlare opened this issue Aug 11, 2023 · 3 comments · Fixed by #1862
Labels
help wanted Extra attention is needed test junit test related things

Comments

@HeikoKlare
Copy link
Contributor

The test org.eclipse.jface.tests.viewers.VirtualTableViewerTest.testRenameWithSorter randomly fails, e.g. https://download.eclipse.org/eclipse/downloads/drops4/I20230810-1800/testresults/html/org.eclipse.jface.tests_ep429I-unit-macM1-java17_macosx.cocoa.aarch64_17.html

sorted first expected:<0-[0 name-999]9> but was:<0-[9 name-]9>

junit.framework.ComparisonFailure: sorted first expected:<0-[0 name-999]9> but was:<0-[9 name-]9>
at junit.framework.Assert.assertEquals(Assert.java:100)
at junit.framework.TestCase.assertEquals(TestCase.java:253)
at org.eclipse.jface.tests.viewers.VirtualTableViewerTest.testRenameWithSorter(VirtualTableViewerTest.java:244)
@HeikoKlare HeikoKlare changed the title Random failing VirtualTableViewerTest.testRenameWithSorter Random failing VirtualTableViewerTest.testRenameWithSorter and VirtualTableViewerTest.testContains Sep 12, 2023
@HeikoKlare
Copy link
Contributor Author

The test org.eclipse.jface.tests.viewers.VirtualTableViewerTest.testContains also randomly fails, e.g.,
https://github.com/eclipse-platform/eclipse.platform.ui/pull/1086/checks?check_run_id=16671995346

element must be available on the viewer
junit.framework.AssertionFailedError: element must be available on the viewer
	at junit.framework.Assert.fail(Assert.java:57)
	at junit.framework.Assert.assertTrue(Assert.java:22)
	at junit.framework.TestCase.assertTrue(TestCase.java:192)
	at org.eclipse.jface.tests.viewers.TableViewerTest.testContains(TableViewerTest.java:200)

@HeikoKlare HeikoKlare mentioned this issue Sep 12, 2023
Merged
@HeikoKlare HeikoKlare mentioned this issue Sep 29, 2023
Closed
This was referenced Oct 17, 2023
Merged
Merged
@vogella
Copy link
Contributor

vogella commented Oct 18, 2023

Seems to fails all the time on Mac. @sratz could you have a look if this can be fixed or if it should be disabled on Mac?

@vogella vogella mentioned this issue Oct 18, 2023
Merged
@jukzi jukzi mentioned this issue Oct 23, 2023
Merged
@jukzi jukzi added the test junit test related things label Nov 28, 2023
@fedejeanne fedejeanne mentioned this issue Nov 29, 2023
Merged
This was referenced Nov 30, 2023
Merged
Merged
@BeckerWdf
Copy link
Contributor

also reported in #1283

@BeckerWdf BeckerWdf mentioned this issue Dec 7, 2023
Merged
jukzi pushed a commit to jukzi/eclipse.platform.ui that referenced this issue Dec 7, 2023
@EcljpseB0T
[test] improve TableViewerTest eclipse-platform#1005
3a7e8cf 
move "fViewer.getControl().update();" to front
eclipse-platform#1005
@jukzi jukzi mentioned this issue Dec 7, 2023
Closed
jukzi pushed a commit to jukzi/eclipse.platform.ui that referenced this issue Dec 7, 2023
@EcljpseB0T
[test] improve TableViewerTest eclipse-platform#1005
d802377 
move "fViewer.getControl().update();" to front
eclipse-platform#1005
@HeikoKlare HeikoKlare mentioned this issue Dec 14, 2023
Merged
@laeubi laeubi mentioned this issue Dec 19, 2023
Merged
@HeikoKlare HeikoKlare mentioned this issue Dec 21, 2023
Closed
@HeikoKlare HeikoKlare mentioned this issue Jan 18, 2024
Merged
@jukzi jukzi added the help wanted Extra attention is needed label Jan 23, 2024
@jukzi jukzi mentioned this issue Jan 23, 2024
Merged
@HeikoKlare HeikoKlare mentioned this issue Jan 29, 2024
Open
This was referenced Feb 8, 2024
Merged
Merged
@HeikoKlare HeikoKlare mentioned this issue Mar 8, 2024
Merged
This was referenced Apr 3, 2024
Merged
Merged
@Wittmaxi Wittmaxi mentioned this issue Apr 9, 2024
Merged
This was referenced Apr 18, 2024
Merged
Merged
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Apr 29, 2024
@HeikoKlare
VirtualTableViewerTest: improve table update + force active shell ecl…
438ef1b 
…ipse-platform#1005

Several test cases of VirtualTableViewerTest randomly fail. This
includes explicit failures of testRenameWithSorter() and testContains()
and silent failures of other test cases that simply return successfully
even if the test actually failed. The reason is a missing processing of
an update of the table data, which is most likely caused by the shell
not having focus.

With this change, the test execution ensures that in cases where an
update of the table data is expected, the shell is forced active. In
addition, early returns producing silent failures are replaced by
assertions leading to explicit failures in case the condition is still
not met.

Contributes to
eclipse-platform#1583
May fix eclipse-platform#1005
@HeikoKlare HeikoKlare mentioned this issue Apr 29, 2024
Merged
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Apr 29, 2024
@HeikoKlare
VirtualTableViewerTest: improve table update + force active shell ecl…
76fc596 
…ipse-platform#1005

Several test cases of VirtualTableViewerTest randomly fail. This
includes explicit failures of testRenameWithSorter() and testContains()
and silent failures of other test cases that simply return successfully
even if the test actually failed. The reason is a missing processing of
an update of the table data, which is most likely caused by the shell
not having focus.

With this change, the test execution ensures that in cases where an
update of the table data is expected, the shell is forced active. In
addition, early returns producing silent failures are replaced by
assertions leading to explicit failures in case the condition is still
not met.

Contributes to
eclipse-platform#1583
May fix eclipse-platform#1005
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Apr 29, 2024
@HeikoKlare
VirtualTableViewerTest: improve table update + force active shell ecl…
def3326 
…ipse-platform#1005

Several test cases of VirtualTableViewerTest randomly fail. This
includes explicit failures of testRenameWithSorter() and testContains()
and silent failures of other test cases that simply return successfully
even if the test actually failed. The reason is a missing processing of
an update of the table data, which is most likely caused by the shell
not having focus.

With this change, the test execution ensures that in cases where an
update of the table data is expected, the shell is forced active. In
addition, early returns producing silent failures are replaced by
assertions leading to explicit failures in case the condition is still
not met.

Contributes to
eclipse-platform#1583
May fix eclipse-platform#1005
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Apr 29, 2024
@HeikoKlare
VirtualTableViewerTest: improve table update + force active shell ecl…
ba1643e 
…ipse-platform#1005

Several test cases of VirtualTableViewerTest randomly fail. This
includes explicit failures of testRenameWithSorter() and testContains()
and silent failures of other test cases that simply return successfully
even if the test actually failed. The reason is a missing processing of
an update of the table data, which is most likely caused by the shell
not having focus.

With this change, the test execution ensures that in cases where an
update of the table data is expected, the shell is forced active and
events are processed until the data is finally set properly. In
addition, early returns producing silent failures are replaced by
assertions leading to explicit failures in case the condition is still
not met.

Contributes to
eclipse-platform#1583
May fix eclipse-platform#1005
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Apr 29, 2024
@HeikoKlare
VirtualTableViewerTest: improve table update + force active shell ecl…
c89a7de 
…ipse-platform#1005

Several test cases of VirtualTableViewerTest randomly fail. This
includes explicit failures of testRenameWithSorter() and testContains()
and silent failures of other test cases that simply return successfully
even if the test actually failed. The reason is a missing processing of
an update of the table data, which is most likely caused by the shell
not having focus.

With this change, the test execution ensures that in cases where an
update of the table data is expected, the shell is forced active and
events are processed until the data is finally set properly. In
addition, early returns producing silent failures are replaced by
assertions leading to explicit failures in case the condition is still
not met.

Contributes to
eclipse-platform#1583
May fix eclipse-platform#1005
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue May 1, 2024
@HeikoKlare
VirtualTableViewerTest: improve table update + force active shell ecl…
33c75f1 
…ipse-platform#1005

Several test cases of VirtualTableViewerTest randomly fail. This
includes explicit failures of testRenameWithSorter() and testContains()
and silent failures of other test cases that simply return successfully
even if the test actually failed. The reason is a missing processing of
an update of the table data, which is most likely caused by the shell
not having focus.

With this change, the test execution ensures that in cases where an
update of the table data is expected, the shell is forced active and
events are processed until the data is finally set properly. In
addition, early returns producing silent failures are replaced by
assertions leading to explicit failures in case the condition is still
not met.

Contributes to
eclipse-platform#1583
May fix eclipse-platform#1005
HeikoKlare added a commit that referenced this issue May 1, 2024
@HeikoKlare
VirtualTableViewerTest: improve table update + force active shell #1005
4560024 
Several test cases of VirtualTableViewerTest randomly fail. This
includes explicit failures of testRenameWithSorter() and testContains()
and silent failures of other test cases that simply return successfully
even if the test actually failed. The reason is a missing processing of
an update of the table data, which is most likely caused by the shell
not having focus.

With this change, the test execution ensures that in cases where an
update of the table data is expected, the shell is forced active and
events are processed until the data is finally set properly. In
addition, early returns producing silent failures are replaced by
assertions leading to explicit failures in case the condition is still
not met.

Contributes to
#1583
May fix #1005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed test junit test related things
Projects
None yet
Milestone
No milestone
4 participants
@vogella @HeikoKlare @BeckerWdf @jukzi