Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle case when no span is created in GRPC client interceptor #1740

Merged
merged 15 commits into from
Feb 16, 2023
Merged

handle case when no span is created in GRPC client interceptor #1740

merged 15 commits into from
Feb 16, 2023

Conversation

beniwohli
Copy link
Contributor

Related issues

closes #1739

@beniwohli beniwohli requested a review from basepi February 6, 2023 08:38
@apmmachine
Copy link
Contributor

apmmachine commented Feb 6, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-02-06T08:39:22.484+0000

  • Duration: 21 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 5087
Skipped 3679
Total 8766

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (73/73) 💚
Files 100.0% (241/241) 💚
Classes 100.0% (241/241) 💚
Lines 91.928% (18791/20441) 👍 0.007
Conditionals 75.084% (2890/3849) 👍 0.039

@beniwohli beniwohli mentioned this pull request Feb 6, 2023
Closed
reakaleek and others added 13 commits February 16, 2023 14:30
@reakaleek @beniwohli
Migrate Jenkinsfile 2 GH Actions Workflow (elastic#1731)
b4ad53d 
* Migrate Jenkinsfile to GH Actions

* Generic naming

* Upload junit test and coverage reports on success or on failure

* Better naming

* Remove cron from packages workflow

* Rename all occurences of WEBFRAMEWORK to FRAMEWORK
@basepi @beniwohli
Add a warning about BaseHTTPMiddleware to Starlette docs (elastic#1735)
9203917 
* Add a warning about BaseHTTPMiddleware to Starlette docs

Also switch to using get_client() and make the docs simpler for
environment variable configuration.

* CHANGELOG
@basepi @beniwohli
Change server_url default to avoid ipv6 ambiguity (elastic#1744)
40cd08a 
* Change `server_url` default to avoid ipv6 ambiguity

* Fix failing test and another minor doc fix
@basepi @beniwohli
Add service.agent.activation_method to metadata (elastic#1743)
1444a90 
* Add activation_method to metadata

* Add test

* Move activation_method default above start_threads

* CHANGELOG
@reakaleek @beniwohli
Fix nightly scheduled test (elastic#1747)
d66b12e 
* Split matrix items into chunks

to bypass the 256 limit of matrix items in github actions

* cleanup

* Add comments
@reakaleek @beniwohli
Add update-specs updatcli workflow (elastic#1745)
8798092 
* Add update-specs updatcli workflow

* Fix paths
@reakaleek @beniwohli
Required Status Check (elastic#1749)
611b586 
* Create single status check that can be set as required

* Let windows test runs exit with the correct exit code

* Set the exit code

* Formatting

* fix

* More readable jq query
@reakaleek @beniwohli
Set status check to success in case it's an only-docs PR (elastic#1753)
f4d5a35 
* Set status check to success in case it's a only-docs PR

* Set permissions

* fix path patterns

* Add comments
@reakaleek @beniwohli
Update badge (elastic#1752)
ead96a2
@basepi @beniwohli
Add dynamic config tag to more supported options (elastic#1750)
a4553b0
@reakaleek @beniwohli
Fix sha source (elastic#1754)
44fcc86
@beniwohli
update changelog
d7775eb
@basepi
Merge branch 'main' into fix-1739
e7139e2
@basepi basepi merged commit 124f9dc into elastic:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basepi basepi basepi approved these changes

Assignees
No one assigned
Labels
agent-python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GRPC] Handle the null span case
4 participants
@beniwohli @apmmachine @basepi @reakaleek