Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly scheduled test #1747

Merged

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Feb 8, 2023

What does this pull request do?

Split the matrix items into chunks and run on multiple jobs to bypass the matrix max limit of 256 when running the full matrix.

image

How to test

Tested with the diff

index 2738f926..364a7cee 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -28,9 +28,9 @@ jobs:
         uses: elastic/apm-pipeline-library/.github/actions/version-framework@current
         with:
           # Use .ci/.matrix_python_full.yml if it's a scheduled workflow, otherwise use .ci/.matrix_python.yml
-          versionsFile: .ci/.matrix_python${{ github.event_name == 'schedule' && '_full' || '' }}.yml
+          versionsFile: .ci/.matrix_python_full.yml
           # Use .ci/.matrix_framework_full.yml if it's a scheduled workflow, otherwise use .ci/.matrix_framework.yml
-          frameworksFile: .ci/.matrix_framework${{ github.event_name == 'schedule' && '_full' || '' }}.yml
+          frameworksFile: .ci/.matrix_framework_full.yml
           excludedFile: .ci/.matrix_exclude.yml
       - name: Split matrix
         shell: python

Related issues

Closes https://github.com/elastic/observability-robots/issues/1566

@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Feb 8, 2023
to bypass the 256 limit of matrix items in github actions
@reakaleek reakaleek force-pushed the feature/fix-nightly-scheduled-test branch from d9c27db to 06aa464 Compare February 8, 2023 16:32
@reakaleek reakaleek self-assigned this Feb 8, 2023
@reakaleek reakaleek requested review from a team February 8, 2023 16:33
@reakaleek reakaleek marked this pull request as ready for review February 8, 2023 16:34
@reakaleek reakaleek merged commit 552fed1 into elastic:main Feb 9, 2023
@reakaleek reakaleek deleted the feature/fix-nightly-scheduled-test branch February 9, 2023 08:10
beniwohli pushed a commit to beniwohli/apm-agent-python that referenced this pull request Feb 16, 2023
* Split matrix items into chunks

to bypass the 256 limit of matrix items in github actions

* cleanup

* Add comments
basepi added a commit that referenced this pull request Feb 16, 2023
* handle case when no span is created in GRPC client interceptor

closes #1739

* Migrate Jenkinsfile 2 GH Actions Workflow (#1731)

* Migrate Jenkinsfile to GH Actions

* Generic naming

* Upload junit test and coverage reports on success or on failure

* Better naming

* Remove cron from packages workflow

* Rename all occurences of WEBFRAMEWORK to FRAMEWORK

* Add a warning about BaseHTTPMiddleware to Starlette docs (#1735)

* Add a warning about BaseHTTPMiddleware to Starlette docs

Also switch to using get_client() and make the docs simpler for
environment variable configuration.

* CHANGELOG

* Change `server_url` default to avoid ipv6 ambiguity (#1744)

* Change `server_url` default to avoid ipv6 ambiguity

* Fix failing test and another minor doc fix

* Add service.agent.activation_method to metadata (#1743)

* Add activation_method to metadata

* Add test

* Move activation_method default above start_threads

* CHANGELOG

* Fix nightly scheduled test (#1747)

* Split matrix items into chunks

to bypass the 256 limit of matrix items in github actions

* cleanup

* Add comments

* Add update-specs updatcli workflow (#1745)

* Add update-specs updatcli workflow

* Fix paths

* Required Status Check (#1749)

* Create single status check that can be set as required

* Let windows test runs exit with the correct exit code

* Set the exit code

* Formatting

* fix

* More readable jq query

* Set status check to success in case it's an only-docs PR (#1753)

* Set status check to success in case it's a only-docs PR

* Set permissions

* fix path patterns

* Add comments

* Update badge (#1752)

* Add dynamic config tag to more supported options (#1750)

* Fix sha source (#1754)

* update changelog

---------

Co-authored-by: Jan Calanog <nejcalanog@gmail.com>
Co-authored-by: Colton Myers <colton@basepi.net>
Co-authored-by: Jan Calanog <jan.calanog@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-python community Issues opened by the community triage Issues awaiting triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants