-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily disable data stream check in TestFleet*IntegrationRecipe e2e tests in 8.12.0 #7491
Temporarily disable data stream check in TestFleet*IntegrationRecipe e2e tests in 8.12.0 #7491
Conversation
buildkite test this -f p=gke,t=TestFleet -m s=8.12.0,s=8.13.0-SNAPSHOT |
buildkite test this -f p=gke,t=TestFleet -m s=8.11.0,s=8.12.0,s=8.13.0-SNAPSHOT |
920798b
to
2828a7a
Compare
buildkite test this -f p=gke,t=TestFleet -m s=8.11.0,s=8.12.0,s=8.13.0-SNAPSHOT |
2828a7a
to
de0a1bc
Compare
buildkite test this -f p=gke,t=TestFleet -m s=8.11.0,s=8.12.0,s=8.13.0-SNAPSHOT |
test/e2e/agent/config_test.go
Outdated
WithDefaultESValidation(agent.HasWorkingDataStream(agent.MetricsType, "elastic_agent.metricbeat", "default")) | ||
|
||
// https://github.com/elastic/cloud-on-k8s/issues/7389 | ||
if v.LT(version.MinFor(8, 12, 0)) && v.GE(version.MinFor(8, 14, 0)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if v.LT(version.MinFor(8, 12, 0)) && v.GE(version.MinFor(8, 14, 0)) { | |
if v.LT(version.MinFor(8, 12, 0)) || v.GE(version.MinFor(8, 14, 0)) { |
I think you meant OR here, and the others as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! 🤦
Thanks.
buildkite test this -f p=gke,t=TestFleet -m s=8.11.0,s=8.12.0,s=8.13.0-SNAPSHOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
… and 8.13 (#7491) This disables the check of the existence of the data stream `metrics-elastic_agent.filebeat-default` with stack version `8.12.x and 8.13.x` in the following e2e tests: - TestFleetAgentWithoutTLS - TestFleetMode - TestFleetKubernetesIntegrationRecipe - TestFleetAPMIntegrationRecipe
This disables the check of the existence of the data stream
metrics-elastic_agent.filebeat-default
with stack version8.12.x and 8.13.x
in the following e2e tests:Relates to #7389.