Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable data stream check in TestFleet*IntegrationRecipe e2e tests in 8.12.0 #7491

Merged
merged 6 commits into from
Jan 23, 2024

Conversation

thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Jan 22, 2024

This disables the check of the existence of the data stream metrics-elastic_agent.filebeat-default with stack version 8.12.x and 8.13.x in the following e2e tests:

  • TestFleetAgentWithoutTLS
  • TestFleetMode
  • TestFleetKubernetesIntegrationRecipe
  • TestFleetAPMIntegrationRecipe

Relates to #7389.

@thbkrkr
Copy link
Contributor Author

thbkrkr commented Jan 22, 2024

buildkite test this -f p=gke,t=TestFleet -m s=8.12.0,s=8.13.0-SNAPSHOT

@thbkrkr
Copy link
Contributor Author

thbkrkr commented Jan 22, 2024

buildkite test this -f p=gke,t=TestFleet -m s=8.11.0,s=8.12.0,s=8.13.0-SNAPSHOT

@thbkrkr thbkrkr marked this pull request as draft January 22, 2024 13:20
@thbkrkr thbkrkr force-pushed the disable-flaky-check-for-TestFleetIntegrationRecipe branch from 920798b to 2828a7a Compare January 22, 2024 13:51
@thbkrkr
Copy link
Contributor Author

thbkrkr commented Jan 22, 2024

buildkite test this -f p=gke,t=TestFleet -m s=8.11.0,s=8.12.0,s=8.13.0-SNAPSHOT

@thbkrkr thbkrkr force-pushed the disable-flaky-check-for-TestFleetIntegrationRecipe branch from 2828a7a to de0a1bc Compare January 22, 2024 16:05
@thbkrkr
Copy link
Contributor Author

thbkrkr commented Jan 22, 2024

buildkite test this -f p=gke,t=TestFleet -m s=8.11.0,s=8.12.0,s=8.13.0-SNAPSHOT

@thbkrkr thbkrkr marked this pull request as ready for review January 22, 2024 19:45
@thbkrkr thbkrkr requested a review from naemono January 22, 2024 19:45
@thbkrkr thbkrkr enabled auto-merge (squash) January 22, 2024 19:50
WithDefaultESValidation(agent.HasWorkingDataStream(agent.MetricsType, "elastic_agent.metricbeat", "default"))

// https://github.com/elastic/cloud-on-k8s/issues/7389
if v.LT(version.MinFor(8, 12, 0)) && v.GE(version.MinFor(8, 14, 0)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if v.LT(version.MinFor(8, 12, 0)) && v.GE(version.MinFor(8, 14, 0)) {
if v.LT(version.MinFor(8, 12, 0)) || v.GE(version.MinFor(8, 14, 0)) {

I think you meant OR here, and the others as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! 🤦
Thanks.

@thbkrkr
Copy link
Contributor Author

thbkrkr commented Jan 23, 2024

buildkite test this -f p=gke,t=TestFleet -m s=8.11.0,s=8.12.0,s=8.13.0-SNAPSHOT

Copy link
Contributor

@naemono naemono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thbkrkr thbkrkr merged commit fe3886f into main Jan 23, 2024
6 checks passed
@thbkrkr thbkrkr deleted the disable-flaky-check-for-TestFleetIntegrationRecipe branch January 23, 2024 14:27
thbkrkr added a commit that referenced this pull request Jan 30, 2024
… and 8.13 (#7491)

This disables the check of the existence of the data stream `metrics-elastic_agent.filebeat-default` with stack version `8.12.x and 8.13.x` in the following e2e tests:
- TestFleetAgentWithoutTLS
- TestFleetMode
- TestFleetKubernetesIntegrationRecipe
- TestFleetAPMIntegrationRecipe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants