Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorization by introducing WithFleetAgentDataStreamsValidation() #7497

Merged

Conversation

thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Jan 24, 2024

TestAgentVersionUpgradeToLatest8x is also affected by #7389.

This commit refactors all validations done in Fleet E2E tests with disabling the problematic validation based on version, so that all tests benefit from it.

Relates to #7491, #7389.

@thbkrkr
Copy link
Contributor Author

thbkrkr commented Jan 24, 2024

buildkite test this -f p=gke,E2E_TAGS=agent -m s=8.11.0,s=8.12.0,s=8.13.0-SNAPSHOT

WithDefaultESValidation(HasWorkingDataStream(LogsType, "elastic_agent.metricbeat", "default")).
WithDefaultESValidation(HasWorkingDataStream(MetricsType, "elastic_agent.elastic_agent", "default")).
WithDefaultESValidation(HasWorkingDataStream(MetricsType, "elastic_agent.fleet_server", "default")).
WithDefaultESValidation(HasWorkingDataStream(MetricsType, "elastic_agent.metricbeat", "default"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the two following:

		WithDefaultESValidation(HasWorkingDataStream(LogsType, "elastic_agent", "default")).
		WithDefaultESValidation(HasWorkingDataStream(MetricsType, "elastic_agent.fleet_server", "default")).

were not always done in all Fleet* E2E tests, but I don't think there is a good reason why we shouldn't do them.

@thbkrkr thbkrkr enabled auto-merge (squash) January 24, 2024 16:01
Copy link
Contributor

@naemono naemono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense, and when we have to make changes to fleet e2e tests (common) they are more centralized. ty

@thbkrkr thbkrkr merged commit 447ea8a into main Jan 24, 2024
6 checks passed
@thbkrkr thbkrkr deleted the disable-failing-check-for-TestAgentVersionUpgradeToLatest8x branch January 24, 2024 16:12
thbkrkr added a commit that referenced this pull request Jan 31, 2024
…7497)

This commit refactors all validations done in Fleet E2E tests with
disabling the problematic validation based on version, so that all tests
benefit from it (in particular `TestAgentVersionUpgradeToLatest8x` 
which is affected by #7389).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants