Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove data stream check for Fleet/Agent e2e tests #7522

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Remove data stream check for Fleet/Agent e2e tests #7522

merged 3 commits into from
Jan 31, 2024

Conversation

thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Jan 31, 2024

@thbkrkr
Temporarily disable broken Fleet e2e tests (#7416)
5074ade
@thbkrkr
Temporarily disable data stream check in TestFleet* e2e tests in 8.12…
b14a007 
… and 8.13 (#7491)

This disables the check of the existence of the data stream `metrics-elastic_agent.filebeat-default` with stack version `8.12.x and 8.13.x` in the following e2e tests:
- TestFleetAgentWithoutTLS
- TestFleetMode
- TestFleetKubernetesIntegrationRecipe
- TestFleetAPMIntegrationRecipe
@thbkrkr
Factorization by introducing WithFleetAgentDataStreamsValidation() (#…
ede4d51 
…7497)

This commit refactors all validations done in Fleet E2E tests with
disabling the problematic validation based on version, so that all tests
benefit from it (in particular `TestAgentVersionUpgradeToLatest8x` 
which is affected by #7389).
@thbkrkr thbkrkr added >test Related to unit/integration/e2e tests backport For backport PRs labels Jan 31, 2024
@thbkrkr thbkrkr requested a review from naemono January 31, 2024 08:56
barkbay
barkbay approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thbkrkr thbkrkr merged commit 643286a into 2.11.1-wip Jan 31, 2024
5 checks passed
@thbkrkr thbkrkr deleted the disable-datastream-check-test-fleet-agent branch January 31, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barkbay barkbay barkbay approved these changes

@naemono naemono Awaiting requested review from naemono

Assignees
No one assigned
Labels
backport For backport PRs >test Related to unit/integration/e2e tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thbkrkr @barkbay