Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple legend and tooltip from XYChart #486

Closed
2 tasks done
markov00 opened this issue Dec 5, 2019 · 1 comment · Fixed by #616
Closed
2 tasks done

Decouple legend and tooltip from XYChart #486

markov00 opened this issue Dec 5, 2019 · 1 comment · Fixed by #616
Assignees
@markov00
Labels
enhancement New feature or request :legend Legend related issue released Issue released publicly :tooltip Related to hover tooltip

Comments

@markov00
Copy link
Member

markov00 commented Dec 5, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
The current implementation of Legend and the tooltip is partially coupled with XYChart type.
We should decouple it to allow reusing the Legend and the tooltip freely among all chart types.

Describe the solution you'd like
Move Legend and Tooltip into the global component folder, decouple LegendItems and associated types from XYChart.

  • Tooltip
  • Legend
@markov00 markov00 added the enhancement New feature or request label Dec 5, 2019
@markov00 markov00 self-assigned this Feb 26, 2020
@markov00 markov00 added :legend Legend related issue :tooltip Related to hover tooltip labels Mar 26, 2020
@markov00 markov00 mentioned this issue Apr 9, 2020
Merged
4 tasks
markov00 added a commit that referenced this issue Apr 14, 2020
@markov00
feat(partition): add legend and highlighters (#616)
6a4247e 
This commit adds the legend and highlighters to partition charts.
Two new options are added to the <Settings/> components: `flatLegend` will flat the legend for pie/tree hierarchical legend and `legendMaxDepth` will limit the legend hierarchy to a maximum depth value: 1 is the root level (can be combined with the `flatLegend`).

close #486, close #532
markov00 pushed a commit that referenced this issue Apr 15, 2020
@semantic-release-bot
chore(release): 18.3.0 [skip ci]
1e3a130 
# [18.3.0](v18.2.2...v18.3.0) (2020-04-15)

### Bug Fixes

* remove series with undefined splitSeriesAccessor values ([#627](#627)) ([59f0f6e](59f0f6e))

### Features

* gauge, goal and bullet graph (alpha) ([#614](#614)) ([5669178](5669178))
* **partition:** add legend and highlighters ([#616](#616)) ([6a4247e](6a4247e)), closes [#486](#486) [#532](#532)
@markov00
Copy link
Member Author

🎉 This issue has been resolved in version 18.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Apr 15, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 18.3.0 [skip ci]
784ff64 
# [18.3.0](elastic/elastic-charts@v18.2.2...v18.3.0) (2020-04-15)

### Bug Fixes

* remove series with undefined splitSeriesAccessor values ([opensearch-project#627](elastic/elastic-charts#627)) ([e8bd5ea](elastic/elastic-charts@e8bd5ea))

### Features

* gauge, goal and bullet graph (alpha) ([opensearch-project#614](elastic/elastic-charts#614)) ([4191664](elastic/elastic-charts@4191664))
* **partition:** add legend and highlighters ([opensearch-project#616](elastic/elastic-charts#616)) ([b939596](elastic/elastic-charts@b939596)), closes [opensearch-project#486](elastic/elastic-charts#486) [opensearch-project#532](elastic/elastic-charts#532)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
enhancement New feature or request :legend Legend related issue released Issue released publicly :tooltip Related to hover tooltip
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(partition): add legend and highlighters markov00/elastic-charts
1 participant
@markov00