-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove series with undefined splitSeriesAccessor values #627
fix: remove series with undefined splitSeriesAccessor values #627
Conversation
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
=======================================
Coverage 67.78% 67.79%
=======================================
Files 236 236
Lines 6914 6916 +2
Branches 1275 1276 +1
=======================================
+ Hits 4687 4689 +2
Misses 2208 2208
Partials 19 19
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good. Tested storybook and looks good.
Would we ever want in the future to enable this functionality under other
if a prop were passed, say includeMissingSplitGroups
or something?
- change logic to exclude only if no splits are found but accessor is defined - remove all unnecessary split series accessors, per the new constraint above - add tooltip vrt for multple split and y accessors - remove tooltip visibility on 2y2g story - update necessary screenshots
This commit removes every series generated from a partial datum where all the values accessed by the splitSeriesAccessors array are null or undefined. Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com>
# [18.3.0](v18.2.2...v18.3.0) (2020-04-15) ### Bug Fixes * remove series with undefined splitSeriesAccessor values ([#627](#627)) ([59f0f6e](59f0f6e)) ### Features * gauge, goal and bullet graph (alpha) ([#614](#614)) ([5669178](5669178)) * **partition:** add legend and highlighters ([#616](#616)) ([6a4247e](6a4247e)), closes [#486](#486) [#532](#532)
# [18.3.0](elastic/elastic-charts@v18.2.2...v18.3.0) (2020-04-15) ### Bug Fixes * remove series with undefined splitSeriesAccessor values ([opensearch-project#627](elastic/elastic-charts#627)) ([e8bd5ea](elastic/elastic-charts@e8bd5ea)) ### Features * gauge, goal and bullet graph (alpha) ([opensearch-project#614](elastic/elastic-charts#614)) ([4191664](elastic/elastic-charts@4191664)) * **partition:** add legend and highlighters ([opensearch-project#616](elastic/elastic-charts#616)) ([b939596](elastic/elastic-charts@b939596)), closes [opensearch-project#486](elastic/elastic-charts#486) [opensearch-project#532](elastic/elastic-charts#532)
Summary
This PR removes every series generated from a partial
datum
where some or all the values accessed by thesplitSeriesAccessors
array arenull
orundefined
.fix #594
Checklist
Delete any items that are not applicable to this PR.