Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Short URL missing link redirection error #169935

Closed
vadimkibana opened this issue Oct 26, 2023 · 4 comments · Fixed by #171679
Closed

Better Short URL missing link redirection error #169935

vadimkibana opened this issue Oct 26, 2023 · 4 comments · Fixed by #171679
Assignees
@tsullivan
Labels
Feature:SharingURLs Short URLs and Share URL features Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@vadimkibana
Copy link
Contributor

vadimkibana commented Oct 26, 2023 •
edited by tsullivan
Loading

When a short URL is missing (there is no backing saved object), the following error is shown:

image

Description of the issue

This issue came to us from feedback about the friendliness and usefulness of the page.

[This is] quite a violent error message considering it really means "Unknown URL" ..

  1. The messaging should be "softer": get rid of the red, add some text that is on-brand.
    • Explain the issue is a matter of lost a Saved Object document.
  2. The screen should be "recoverable": include a link back to home
  3. If an illustration can be provided in place of the red X icon, use that.
@vadimkibana vadimkibana added Feature:SharingURLs Short URLs and Share URL features Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Oct 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@tsullivan
Copy link
Member

quick mockup for a new proposed design:
image

@tsullivan tsullivan mentioned this issue Nov 21, 2023
Merged
6 tasks
tsullivan added a commit that referenced this issue Nov 30, 2023
@tsullivan @kibanamachine
Update page for missing Short URL (#171679)
e6f3f06 
## Summary

Closes #169935

### Screenshots
<details>
<summary>Before</summary>
<img width="1259" alt="image"
src="https://github.com/elastic/kibana/assets/908371/dbc91683-4088-48df-a402-1432615a2ff4">
</details>

<details>
<summary>After</summary>
<img width="1260" alt="image"
src="https://github.com/elastic/kibana/assets/908371/a1efabba-9402-4e97-935e-93656069c650">
</details>


### Testing

1. Create a simple dashboard
2. Use the Share > Short URL feature to create a short link to the
dashboard.
3. Copy the shortened URL link to the clipboard, create a browser
bookmark using the link.
4. Navigate to Saved Objects Management and delete the backing saved
object of the short link
5. Click the new bookmark to try to open the shortened URL
6. Land on this new page

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@tsullivan
Copy link
Member

re-opened via #171679 (comment)

@tsullivan tsullivan reopened this Dec 1, 2023
@petrklapka
Copy link
Member

Closed by #172422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsullivan tsullivan

Labels
Feature:SharingURLs Short URLs and Share URL features Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update page for missing Short URL tsullivan/kibana
4 participants
@tsullivan @elasticmachine @petrklapka @vadimkibana