Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update page for missing Short URL Part II #172422

Merged
merged 19 commits into from
Dec 5, 2023

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Dec 2, 2023

Summary

This PR re-opens #171679 which had to be reverted due to CI instability at the time it was originally mergted.

@tsullivan tsullivan changed the title Short urls/new error page Update page for missing Short URL Part II Dec 3, 2023
@tsullivan tsullivan marked this pull request as ready for review December 3, 2023 22:46
@tsullivan tsullivan requested review from a team as code owners December 3, 2023 22:46
@tsullivan tsullivan added Feature:SharingURLs Short URLs and Share URL features release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Dec 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@tsullivan tsullivan self-assigned this Dec 3, 2023
Copy link
Contributor

@vadimkibana vadimkibana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review only.

@jbudz
Copy link
Member

jbudz commented Dec 4, 2023

buildkite test this

@jbudz
Copy link
Member

jbudz commented Dec 4, 2023

@jbudz
Copy link
Member

jbudz commented Dec 4, 2023

The most recent CI run here re-used the last working build. I expect a new commit with the recently added ci:build-canvas-shareable-runtime will fail similar to the snapshot build.

@tsullivan tsullivan requested a review from a team as a code owner December 4, 2023 21:52
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
share 73 78 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
share 5.6KB 7.3KB +1.7KB

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5666 +5666
total size - 5.9MB +5.9MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
share 52.2KB 52.4KB +180.0B
Unknown metric groups

async chunk count

id before after diff
share 1 3 +2

ESLint disabled line counts

id before after diff
share 7 8 +1

miscellaneous assets size

id before after diff
share 0.0B 387.0KB ⚠️ +387.0KB

Total ESLint disabled count

id before after diff
share 9 10 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tsullivan

@tsullivan tsullivan merged commit 1e93160 into elastic:main Dec 5, 2023
35 checks passed
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Dec 5, 2023
@tsullivan tsullivan deleted the short-urls/new-error-page branch April 30, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:build-canvas-shareable-runtime Feature:SharingURLs Short URLs and Share URL features release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants