Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inventory] Remove tooltip message for the action column #199500

Closed
jennypavlova opened this issue Nov 8, 2024 · 6 comments · Fixed by #201231
Closed

[Inventory] Remove tooltip message for the action column #199500

jennypavlova opened this issue Nov 8, 2024 · 6 comments · Fixed by #201231
Assignees
@rmyz
Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@jennypavlova
Copy link
Member

jennypavlova commented Nov 8, 2024 •
edited
Loading

We want to remove the action column tooltip.

Image

AC

  • The actions column should be visible without a tooltip button/message
@jennypavlova jennypavlova added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Nov 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@jennypavlova jennypavlova mentioned this issue Nov 8, 2024
Merged
@cauemarcondes
Copy link
Contributor

Does it make sense to add a tooltip to the actions column? My immediate answer would be no, the actions themselves must be self-explanatory.

jennypavlova added a commit that referenced this issue Nov 8, 2024
@jennypavlova @kibanamachine
[ObsUx][Inventory] Add actions column with link to discover for inven…
fcc3b06 
…tory (#199306)

Closes #199025 
## Summary

This PR adds an actions column with a link to discover for inventory. It
is available in the inventory grid(s) in both the group view and the
unified inventory view.

The column header tooltip text will change when it's available:
[issue](#199500) added

⚠️ If the discover link is not available I added a logic to hide the
whole actions column as this is the only available option for now. Once
we add more actions we should refactor that to just not add the action
and to keep the column visible (which doesn't make sense atm)

## Testing
- Enable the Inventory
- Check with/without grouping both the action link and the button
   - combination of kuery / drop-down filter
   - without any filters
   - With just one kuery or drop-down filter 
- When the link is clicked from the table we should see a filter by
identity field in the query in discover (like `service.name: 'test'`,
`conteainer.id: 'test'`)
  


https://github.com/user-attachments/assets/bb4a89f5-2b30-457f-bf13-7580ff162a7e



https://github.com/user-attachments/assets/2894ef5c-6622-4488-ab84-c453f5b6e318

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Nov 11, 2024
@jennypavlova @kibanamachine @CAWilson94
[ObsUx][Inventory] Add actions column with link to discover for inven…
27a97a1 
…tory (elastic#199306)

Closes elastic#199025 
## Summary

This PR adds an actions column with a link to discover for inventory. It
is available in the inventory grid(s) in both the group view and the
unified inventory view.

The column header tooltip text will change when it's available:
[issue](elastic#199500) added

⚠️ If the discover link is not available I added a logic to hide the
whole actions column as this is the only available option for now. Once
we add more actions we should refactor that to just not add the action
and to keep the column visible (which doesn't make sense atm)

## Testing
- Enable the Inventory
- Check with/without grouping both the action link and the button
   - combination of kuery / drop-down filter
   - without any filters
   - With just one kuery or drop-down filter 
- When the link is clicked from the table we should see a filter by
identity field in the query in discover (like `service.name: 'test'`,
`conteainer.id: 'test'`)
  


https://github.com/user-attachments/assets/bb4a89f5-2b30-457f-bf13-7580ff162a7e



https://github.com/user-attachments/assets/2894ef5c-6622-4488-ab84-c453f5b6e318

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@roshan-elastic
Copy link

@cauemarcondes would it make sense to work on the basis that EEM would provide names and tooltips (if we need them) as part of 'presentational' details from an EEM API?

Obviously, we wouldn't want 'actions' to come from them but I feel like decoupling as much 'hard coding' into Inventory would be more efficient.

I'd be happy to forego polish in the UI for now (esp if we think the best place for this to live will be EEM).

@cauemarcondes
Copy link
Contributor

would it make sense to work on the basis that EEM would provide names and tooltip

This doesn't change the fact that we don't need a tooltip on the actions column, IMHO.

@jennypavlova
Copy link
Member Author

Thanks @cauemarcondes and @roshan-elastic !
I will change the issue to cover removing the tooltip here - it makes sense as it's also not in the design but I was thinking that we want every table column to have it.

@jennypavlova jennypavlova changed the title [ObsUx] Add tooltip message for the action column [ObsUx] Remove tooltip message for the action column Nov 11, 2024
@roshan-elastic
Copy link

Sorry, yes @cauemarcondes @jennypavlova - we don't need the tooltip at all for this column.

cauemarcondes pushed a commit to cauemarcondes/kibana that referenced this issue Nov 12, 2024
@jennypavlova
[ObsUx][Inventory] Add actions column with link to discover for inven…
1268d01 
…tory (elastic#199306)

Closes elastic#199025
## Summary

This PR adds an actions column with a link to discover for inventory. It
is available in the inventory grid(s) in both the group view and the
unified inventory view.

The column header tooltip text will change when it's available:
[issue](elastic#199500) added

⚠️ If the discover link is not available I added a logic to hide the
whole actions column as this is the only available option for now. Once
we add more actions we should refactor that to just not add the action
and to keep the column visible (which doesn't make sense atm)

## Testing
- Enable the Inventory
- Check with/without grouping both the action link and the button
   - combination of kuery / drop-down filter
   - without any filters
   - With just one kuery or drop-down filter
- When the link is clicked from the table we should see a filter by
identity field in the query in discover (like `service.name: 'test'`,
`conteainer.id: 'test'`)

https://github.com/user-attachments/assets/bb4a89f5-2b30-457f-bf13-7580ff162a7e

https://github.com/user-attachments/assets/2894ef5c-6622-4488-ab84-c453f5b6e318

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit fcc3b06)
cauemarcondes added a commit that referenced this issue Nov 12, 2024
@cauemarcondes @jennypavlova
[8.x] [ObsUx][Inventory] Add actions column with link to discover for…
94bde2c 
… inventory (#199306) (#199789)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ObsUx][Inventory] Add actions column with link to discover for
inventory (#199306)](#199306)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2024-11-08T18:18:07Z","message":"[ObsUx][Inventory]
Add actions column with link to discover for inventory
(#199306)\n\nCloses #199025 \r\n## Summary\r\n\r\nThis PR adds an
actions column with a link to discover for inventory. It\r\nis available
in the inventory grid(s) in both the group view and the\r\nunified
inventory view.\r\n\r\nThe column header tooltip text will change when
it's
available:\r\n[issue](#199500)
added\r\n\r\n⚠️ If the discover link is not available I added a logic to
hide the\r\nwhole actions column as this is the only available option
for now. Once\r\nwe add more actions we should refactor that to just not
add the action\r\nand to keep the column visible (which doesn't make
sense atm)\r\n\r\n## Testing\r\n- Enable the Inventory\r\n- Check
with/without grouping both the action link and the button\r\n -
combination of kuery / drop-down filter\r\n - without any filters\r\n -
With just one kuery or drop-down filter \r\n- When the link is clicked
from the table we should see a filter by\r\nidentity field in the query
in discover (like `service.name: 'test'`,\r\n`conteainer.id:
'test'`)\r\n
\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bb4a89f5-2b30-457f-bf13-7580ff162a7e\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2894ef5c-6622-4488-ab84-c453f5b6e318\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"fcc3b0654525d67d34cc5916b4b6f7351892f650","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-infra_services"],"number":199306,"url":"https://github.com/elastic/kibana/pull/199306","mergeCommit":{"message":"[ObsUx][Inventory]
Add actions column with link to discover for inventory
(#199306)\n\nCloses #199025 \r\n## Summary\r\n\r\nThis PR adds an
actions column with a link to discover for inventory. It\r\nis available
in the inventory grid(s) in both the group view and the\r\nunified
inventory view.\r\n\r\nThe column header tooltip text will change when
it's
available:\r\n[issue](#199500)
added\r\n\r\n⚠️ If the discover link is not available I added a logic to
hide the\r\nwhole actions column as this is the only available option
for now. Once\r\nwe add more actions we should refactor that to just not
add the action\r\nand to keep the column visible (which doesn't make
sense atm)\r\n\r\n## Testing\r\n- Enable the Inventory\r\n- Check
with/without grouping both the action link and the button\r\n -
combination of kuery / drop-down filter\r\n - without any filters\r\n -
With just one kuery or drop-down filter \r\n- When the link is clicked
from the table we should see a filter by\r\nidentity field in the query
in discover (like `service.name: 'test'`,\r\n`conteainer.id:
'test'`)\r\n
\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bb4a89f5-2b30-457f-bf13-7580ff162a7e\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2894ef5c-6622-4488-ab84-c453f5b6e318\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"fcc3b0654525d67d34cc5916b4b6f7351892f650"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199306","number":199306,"mergeCommit":{"message":"[ObsUx][Inventory]
Add actions column with link to discover for inventory
(#199306)\n\nCloses #199025 \r\n## Summary\r\n\r\nThis PR adds an
actions column with a link to discover for inventory. It\r\nis available
in the inventory grid(s) in both the group view and the\r\nunified
inventory view.\r\n\r\nThe column header tooltip text will change when
it's
available:\r\n[issue](#199500)
added\r\n\r\n⚠️ If the discover link is not available I added a logic to
hide the\r\nwhole actions column as this is the only available option
for now. Once\r\nwe add more actions we should refactor that to just not
add the action\r\nand to keep the column visible (which doesn't make
sense atm)\r\n\r\n## Testing\r\n- Enable the Inventory\r\n- Check
with/without grouping both the action link and the button\r\n -
combination of kuery / drop-down filter\r\n - without any filters\r\n -
With just one kuery or drop-down filter \r\n- When the link is clicked
from the table we should see a filter by\r\nidentity field in the query
in discover (like `service.name: 'test'`,\r\n`conteainer.id:
'test'`)\r\n
\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bb4a89f5-2b30-457f-bf13-7580ff162a7e\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2894ef5c-6622-4488-ab84-c453f5b6e318\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"fcc3b0654525d67d34cc5916b4b6f7351892f650"}}]}]
BACKPORT-->

Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
@jennypavlova jennypavlova changed the title [ObsUx] Remove tooltip message for the action column [Inventory] Remove tooltip message for the action column Nov 18, 2024
@rmyz rmyz self-assigned this Nov 21, 2024
@rmyz rmyz mentioned this issue Nov 21, 2024
Merged
rmyz added a commit that referenced this issue Nov 22, 2024
@rmyz
[Inventory] Remove Actions tooltip (#201231)
62fad39 
## Summary

Closes #199500

This PR removes the Actions tooltip in the Entities Table.

## Screenshots
| Before | After |

|-------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------|

|![image](https://github.com/user-attachments/assets/c661245a-7d07-4203-b832-a59acc20259c)|<img
width="1441" alt="image"
src="https://github.com/user-attachments/assets/29884aa1-3d82-4e0e-ae88-222fc8edf438">|

## How to test
1. Go to Inventory
2. Check the columns of the Entities table, the tooltip + help button
should now be gone.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 22, 2024
@rmyz
[Inventory] Remove Actions tooltip (elastic#201231)
165b13a 
## Summary

Closes elastic#199500

This PR removes the Actions tooltip in the Entities Table.

## Screenshots
| Before | After |

|-------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------|

|![image](https://github.com/user-attachments/assets/c661245a-7d07-4203-b832-a59acc20259c)|<img
width="1441" alt="image"
src="https://github.com/user-attachments/assets/29884aa1-3d82-4e0e-ae88-222fc8edf438">|

## How to test
1. Go to Inventory
2. Check the columns of the Entities table, the tooltip + help button
should now be gone.

(cherry picked from commit 62fad39)
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this issue Nov 26, 2024
@rmyz @paulinashakirova
[Inventory] Remove Actions tooltip (elastic#201231)
b78e901 
## Summary

Closes elastic#199500

This PR removes the Actions tooltip in the Entities Table.

## Screenshots
| Before | After |

|-------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------|

|![image](https://github.com/user-attachments/assets/c661245a-7d07-4203-b832-a59acc20259c)|<img
width="1441" alt="image"
src="https://github.com/user-attachments/assets/29884aa1-3d82-4e0e-ae88-222fc8edf438">|

## How to test
1. Go to Inventory
2. Check the columns of the Entities table, the tooltip + help button
should now be gone.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@rmyz @CAWilson94
[Inventory] Remove Actions tooltip (elastic#201231)
0645b32 
## Summary

Closes elastic#199500

This PR removes the Actions tooltip in the Entities Table.

## Screenshots
| Before | After |

|-------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------|

|![image](https://github.com/user-attachments/assets/c661245a-7d07-4203-b832-a59acc20259c)|<img
width="1441" alt="image"
src="https://github.com/user-attachments/assets/29884aa1-3d82-4e0e-ae88-222fc8edf438">|

## How to test
1. Go to Inventory
2. Check the columns of the Entities table, the tooltip + help button
should now be gone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmyz rmyz

Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Inventory] Remove Actions tooltip rmyz/kibana
5 participants
@jennypavlova @elasticmachine @rmyz @cauemarcondes @roshan-elastic