Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [ObsUx][Inventory] Add actions column with link to discover for inventory (#199306) #199789

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

cauemarcondes
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…tory (elastic#199306)

Closes elastic#199025
## Summary

This PR adds an actions column with a link to discover for inventory. It
is available in the inventory grid(s) in both the group view and the
unified inventory view.

The column header tooltip text will change when it's available:
[issue](elastic#199500) added

⚠️ If the discover link is not available I added a logic to hide the
whole actions column as this is the only available option for now. Once
we add more actions we should refactor that to just not add the action
and to keep the column visible (which doesn't make sense atm)

## Testing
- Enable the Inventory
- Check with/without grouping both the action link and the button
   - combination of kuery / drop-down filter
   - without any filters
   - With just one kuery or drop-down filter
- When the link is clicked from the table we should see a filter by
identity field in the query in discover (like `service.name: 'test'`,
`conteainer.id: 'test'`)

https://github.com/user-attachments/assets/bb4a89f5-2b30-457f-bf13-7580ff162a7e

https://github.com/user-attachments/assets/2894ef5c-6622-4488-ab84-c453f5b6e318

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit fcc3b06)
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

There are no new commits on the base branch.

@cauemarcondes
Copy link
Contributor Author

buildkite test this

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 12, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 1268d01
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-199789-1268d012164f

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #12 / PackagePolicyInputPanel When agentless is enabled should render inputs specific to env

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
inventory 239 245 +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inventory 231.8KB 233.8KB +2.0KB

History

@cauemarcondes cauemarcondes merged commit 94bde2c into elastic:8.x Nov 12, 2024
35 checks passed
@cauemarcondes cauemarcondes deleted the backport/8.x/pr-199306 branch November 13, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants